From patchwork Thu Sep 21 18:44:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 817151 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-462732-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="jKNySMG3"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xylsM2WqBz9sP1 for ; Fri, 22 Sep 2017 04:44:54 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=ht/UumbaQfK6B0dQ+HXyuggSHuiHXRJs/eaYgQxT8ikmZM pypFA9pXEaQK2aGjfpDiGcEdxNhu4ZsIzy46843AyGcCdEAClif6BBDYpwAvXYnC 4UTmZn8N8//nNAsEZ2i0b5NN+eF6Y3LGJOHjBU3OxuM2IdOjP/3aNLQgz6AOo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=8sNpzHce2gbcy96f55WFlH19z3I=; b=jKNySMG33k6A02MlzWoG lQV9FsEkpT9S+nMjQ0lPqCpYn5dRLFgBnCaOmCpTz3cc4KSmcVTlE2SyAYene0MX YStHmCpkV/h8YPNEVBEtOI49JWToPKXLfcHjXTkQ7hsoi2f6otoBCT7wTUqKvvwg /5WRk/34LuJPa8N/Bp5y89A= Received: (qmail 110479 invoked by alias); 21 Sep 2017 18:44:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 110468 invoked by uid 89); 21 Sep 2017 18:44:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 18:44:45 +0000 Received: by mail-wm0-f50.google.com with SMTP id m72so4365863wmc.1 for ; Thu, 21 Sep 2017 11:44:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=cLLEJg+JlRSjELB1Vqgrn8sOTlxiQuqTRUY28yJkg1I=; b=fBnPPDbhh3k4RpOx+KOaGZVq0hC+jUeXBxE7NE6nCs4g62brSCqji9yqy2T6v3L9wd DAfN1ZZiFDwTbr0nwc+3MqFnE5eSGoE538cCKQxqt2Gxv6m4/GXqVWeIuB45PwEsQ6N3 tUf8yyUaRaso7/ECR2XGM8u4X9aNHBCa54CJDHq5YSJ4MvZv363FJMxksUiQ/aZTRTsI Z4IyCZO7UAM9hh/vjEXtO7tv7IQ7WvqJn7DJZHaYmq0EJgkqZt1PjwYWbizMhbTaBszg vxVCfJ5zIPTb/EpY+Q67jelbnqK8k5TBxPr4f4WGLUpUoBe34WHrHmGFjlvJ21tQ8Wnv sZWQ== X-Gm-Message-State: AHPjjUgMAcBr+wM23Mfz5gwVbDQcdGJTqJ2/zExDH/TyS/oOdiadNQCF Kx8POe9foAMfitpYDqP/sFzEU7OMen74K71Fshu2xumq X-Google-Smtp-Source: AOwi7QAIqvix4rxuYc0XbqOxFxSd1BG2G6j+5KVconIx/97ZSo0FCPQbMyK42Er6AoaVbP0ziduu5UwWR73RcmIOK2Q= X-Received: by 10.80.180.227 with SMTP id x32mr2154182edd.192.1506019482799; Thu, 21 Sep 2017 11:44:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.179.240 with HTTP; Thu, 21 Sep 2017 11:44:40 -0700 (PDT) From: Ian Lance Taylor Date: Thu, 21 Sep 2017 11:44:40 -0700 Message-ID: Subject: libbacktrace patch committed: Fix uninitialized field To: gcc-patches , "gofrontend-dev@googlegroups.com" I somehow failed to initialize the exe_filename field of phdr_data, which most likely led to PR 82284. Bootstrapped and ran libbacktrace tests for this obvious fix. Committed to mainline. Ian 2017-09-21 Ian Lance Taylor PR go/82284 * elf.c (backtrace_initialize): Set pd.exe_filename. Index: elf.c =================================================================== --- elf.c (revision 253076) +++ elf.c (working copy) @@ -1489,6 +1489,7 @@ pd.fileline_fn = &elf_fileline_fn; pd.found_sym = &found_sym; pd.found_dwarf = &found_dwarf; + pd.exe_filename = filename; pd.exe_descriptor = ret < 0 ? descriptor : -1; dl_iterate_phdr (phdr_callback, (void *) &pd);