From patchwork Thu Oct 13 04:20:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 681594 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3svcwW34nSz9snm for ; Thu, 13 Oct 2016 15:20:42 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=O180pU8T; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=t79nAUqI4rGnP/q 3Vyj1BWfHPm1z92oAWMxCZTTbvD0JH+sayRpA6QAATzNj5X93Fnbc1PrVmuwTV1X O8fWdeMFsPQyvuU/e6f7O1dtU0uKsuqQqRvGX28dAo7JKbm+CEm5mp4bhtUdcbQq 20u21yqQ80eCmCrA57RG+/+gyKhw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=S6v1+yVXJDp6PKJUTxMSW 5UU1Uc=; b=O180pU8T4dJxq+WmAsaSNKDvucKldY+f5gScfpFCq8f7bgL5ww7Xm LNyXuxfhApRNYS+lr0MsO0G5HmW7jtikgJASnObIHZdF9v5td0XXFmXt9l0z08z7 jj3GKKO1ustLJ7ZBVU28oqSqZLVrYCoiWY4oVQyTIFkf//V4Umj5A4= Received: (qmail 6625 invoked by alias); 13 Oct 2016 04:20:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6610 invoked by uid 89); 13 Oct 2016 04:20:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL, BAYES_40, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=U*pinskia, sk:pinskia, gofrontend, MERGE X-HELO: mail-it0-f49.google.com Received: from mail-it0-f49.google.com (HELO mail-it0-f49.google.com) (209.85.214.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 04:20:22 +0000 Received: by mail-it0-f49.google.com with SMTP id e203so110539698itc.0 for ; Wed, 12 Oct 2016 21:20:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lcGQ3FxCUEAV2Rg1X44tmj8pK24FbjaJiKN1eaJ9Bqs=; b=e/D9tPtuVxoMvt7uibxvQTteCHMKStchNOJgS5hZjI0LqoeKLCnczrEdmn2/8bbStJ O5VqsfYoqc6uxhcRiSfNbirIqYoPOcoBBY/oCv3jr75m55pnr+QGpaL9TIEng+MhYHId YbYxJGsEotoZhmSz/tX351uLgsP/y3W4tb/NZwJTl2z0Hh9CYWE3fxNDNItaex9liuSn Tsns9E/UFbg89tuJh42PBKFA/MS0HYfoKnDa9qf6LEko0SPw8dGNBoJuDrk7rOVdeiJT lWTBOspwG0QvU/aQYyjeoEiVFV5uE8fE+UwZVcJi6AdwadKwMkEDVqZwc5ntXEb4UMru O+3A== X-Gm-Message-State: AA6/9RkaN8NyS+susJeZMqTw7zqrb5I3dBF/i7qAjM0eMi0UD+btNgc5Fz90AfZ+vkEMpuLc9kWiND9kV+nbSQ== X-Received: by 10.36.77.75 with SMTP id l72mr6034924itb.95.1476332420389; Wed, 12 Oct 2016 21:20:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.154.155 with HTTP; Wed, 12 Oct 2016 21:20:18 -0700 (PDT) In-Reply-To: References: From: Ian Lance Taylor Date: Wed, 12 Oct 2016 21:20:18 -0700 Message-ID: Subject: Re: libgo patch committed: Fixes for sparc64 To: Andrew Pinski Cc: gcc-patches , "gofrontend-dev@googlegroups.com" On Wed, Oct 12, 2016 at 8:03 PM, Andrew Pinski wrote: > On Wed, Oct 12, 2016 at 10:43 AM, Ian Lance Taylor wrote: >> On Wed, Oct 12, 2016 at 7:28 AM, Ian Lance Taylor wrote: >>> This patch to libgo by James Clarke fixes libgo for sparc64. The >>> getrandom syscall was being ignored because the file was named >>> "sparc". The clone syscall apparently needs special attention on >>> SPARC. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. >>> Committed to mainline. >> >> And a followup: mark the new rawClone function as no_split_stack. >> Bootstrapped and tested on x86_64-pc-linux-gnu, committed to mainline. > > This breaks the build on Ubuntu 1604 on aarch64-linux-gnu: > > ../../../gcc/libgo/go/syscall/clone_linux.c:14:28: warning: ‘struct > pt_regs’ declared inside parameter list will not be visible outside of > this definition or declaration > > void *ctid, struct pt_regs *regs) > > ^~~~~~~ > > ../../../gcc/libgo/go/syscall/clone_linux.c:19:82: warning: ‘struct > pt_regs’ declared inside parameter list will not be visible outside of > this definition or declaration rawClone (unsigned long flags, void > *child_stack, void *ptid, void *ctid, struct pt_regs *regs) > > > ^~~~~~~ > > ../../../gcc/libgo/go/syscall/clone_linux.c:19:1: error: conflicting > types for ‘rawClone’ > > rawClone (unsigned long flags, void *child_stack, void *ptid, void > *ctid, struct pt_regs *regs) ^~~~~~~~ > > ../../../gcc/libgo/go/syscall/clone_linux.c:13:6: note: previous > declaration of ‘rawClone’ was here long rawClone (unsigned long > flags, void *child_stack, void *ptid, > > ^~~~~~~~ Bother. Fixed like so. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =================================================================== --- gcc/go/gofrontend/MERGE (revision 241074) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -f38ba8837a0c961e18d982930e192132870f3836 +6c9070324d5b7c8483bc7c17b0a8faaa1fb1ae30 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. Index: libgo/go/syscall/clone_linux.c =================================================================== --- libgo/go/syscall/clone_linux.c (revision 241072) +++ libgo/go/syscall/clone_linux.c (working copy) @@ -5,18 +5,17 @@ license that can be found in the LICENSE file. */ #include -#include #include #include "runtime.h" long rawClone (unsigned long flags, void *child_stack, void *ptid, - void *ctid, struct pt_regs *regs) + void *ctid, void *regs) __asm__ (GOSYM_PREFIX "syscall.rawClone") __attribute__ ((no_split_stack)); long -rawClone (unsigned long flags, void *child_stack, void *ptid, void *ctid, struct pt_regs *regs) +rawClone (unsigned long flags, void *child_stack, void *ptid, void *ctid, void *regs) { #if defined(__arc__) || defined(__aarch64__) || defined(__arm__) || defined(__mips__) || defined(__hppa__) || defined(__powerpc__) || defined(__score__) || defined(__i386__) || defined(__xtensa__) // CLONE_BACKWARDS