From patchwork Thu Oct 30 14:51:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 405070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3512F14007D for ; Fri, 31 Oct 2014 01:51:58 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:content-type; q=dns; s=default; b=mjHT4YYb7aHEhlt/5sctH OBIR7OWddEviEzDKfQVYDVHGKRSY676SrPMRlfDZySBVip73QtJwNNjQoxO0y0uh L0Fza55nsu8RWA2WSA+bW6pNe/q0ACZD9I1XiAwj0GK0p74E9g5iTyoQCWP0VLbk awTrmeG9JsKB/rxcCDafug= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:content-type; s=default; bh=igtrQE5ugXVgmexelIkUv6hmAZ0 =; b=QNKpjjhf70kkISWr4LBtyMaRxwh2GqGymMBmOE/Vd83erz4Kl3S2sPM85Zq n0jMt4nF3BuQDrLfA4SdK7WdspX6ik3RMvJ81DeM75v6YrKA2nwTwkSeBqW/2tXt s23IfC+H+s1S7qQ4+rEMdcCQNUlc4snbp55ANV8jHr1KELVQ= Received: (qmail 16526 invoked by alias); 30 Oct 2014 14:51:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 16515 invoked by uid 89); 30 Oct 2014 14:51:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f53.google.com Received: from mail-yh0-f53.google.com (HELO mail-yh0-f53.google.com) (209.85.213.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 30 Oct 2014 14:51:48 +0000 Received: by mail-yh0-f53.google.com with SMTP id z6so1699280yhz.12 for ; Thu, 30 Oct 2014 07:51:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=UlXq0uSMvDLDlk67skvPsauy9shjdeKbf0A/28kjCZA=; b=OK8MocqVMLctUGwWqwy3IcrI4zsqD/QrK6K6LSUBhchcJED5zoWtHJv5pvs2hqY2hm oSArhM6aN0hLbPAnKWRonV4/rU7ig1+K7Wf5uapZ/EKEDitFn03IWI9cVMePvJy3mhRc FSBla8Fj97qj/YhC1DabkBUQtO9eXadCyL2feTMqRmPeO2fyL8kVsA4bLdQdxdSyOxlI 97CJTkNa/xNNQs0j+Sig/VTYI5GQ+i49HjdVhBdADzGxZdS5muovffCt0PE3eHm2QqoO oFCDuNn8g4bOXgwZC1U94LtDbJJ+wtcsub0dNO4XPiClWO+yOixFlFBzcbf85mCa2Che jcCw== X-Gm-Message-State: ALoCoQnzNDC0XqIVay8lVV72ZZqifkGfllBKOIq2VThV8QHohK2KPxAB45g0Y3J+5LmrJKiGR+RS MIME-Version: 1.0 X-Received: by 10.236.231.98 with SMTP id k92mr3117259yhq.161.1414680705800; Thu, 30 Oct 2014 07:51:45 -0700 (PDT) Received: by 10.170.233.132 with HTTP; Thu, 30 Oct 2014 07:51:45 -0700 (PDT) In-Reply-To: <20141030072534.GA5946@linux.vnet.ibm.com> References: <20140909124446.GA25290@linux.vnet.ibm.com> <20140909130207.GA29442@linux.vnet.ibm.com> <20141030072534.GA5946@linux.vnet.ibm.com> Date: Thu, 30 Oct 2014 07:51:45 -0700 Message-ID: Subject: Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I From: Ian Taylor To: vogt@linux.vnet.ibm.com, "gofrontend-dev@googlegroups.com" , gcc-patches On Thu, Oct 30, 2014 at 12:25 AM, Dominik Vogt wrote: > On Wed, Oct 29, 2014 at 10:16:40AM -0700, Ian Taylor wrote: >> Thanks. Part of the problem is that the m68k max alignment is 16 >> bits, but the godump test expects it to be at least 64 bits. This is >> BIGGEST_ALIGNMENT in config/m68k/m68k.h. Another part of the problem >> seems to be that structs are sometimes aligned to 16 bits although >> there is no obvious reason for that. I'm not sure where that is >> coming from. > > Hm, the test cases make assumptions about the Abi (structure > padding and alignment) that are true on x86, x64_64 and s390[x]. > That may not be the case on other platforms and hence the tests > fail. Another candidate for test failures is the effect of > bitfields (named or anonymous) on structure layout. > >> We could disable the test on m68k or make it more accepting. > > Since the point of some of the tests is to make sure that the Go > structure layout matches the C layout, making the tests accept > deviations seems to be rather pointless. It's possible to add > target selectors to all the "scan-file" lines, but that is a lot > of work and will likely become unmaintainable very soon when more > platforms need to be added. Personally I cannot provide fixed > tests for all the Abis either, so my suggestion is to "xfail" the > test on all targets except s390[x] and x86_64 and leave it to the > people who know the other platforms to decide whether the test > should work there or how the test could be modified to work. > > See attached patch. I don't mind skipping the test on other platforms, but xfail is not correct. When an xfail test passes, we get an XPASS error from the testsuite. We need dg-skip-if. I committed this patch. Ian 2014-10-30 Dominik Vogt * gcc.misc-tests/godump-1.c: Skip -fdump-go-spec tests for all platforms except s390[x] and x86_64. Index: gcc.misc-tests/godump-1.c =================================================================== --- gcc.misc-tests/godump-1.c (revision 216840) +++ gcc.misc-tests/godump-1.c (working copy) @@ -2,6 +2,7 @@ /* { dg-options "-c -fdump-go-spec=godump-1.out" } */ /* { dg-do compile } */ +/* { dg-skip-if "not supported for target" { ! "s390*-*-* x86_64-*-*" } } */ #include