From patchwork Thu Nov 30 05:05:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 842879 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-468194-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="yZlQTCos"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ynQRC1VPVz9t2V for ; Thu, 30 Nov 2017 16:08:38 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=dnKpAXZWTWdYojgMATHYi38tv45DRY2DHW4lDDw/Beawss 4aqADzwD2G8IvVPYoYRZwzpekBVKt5xBGIw5W4tOPvueVaT3wFGpPCs05SlnMnj/ ZwRnXGGebrnEIvyvNBFUHUQz2+/8/PT4jOgE+1aYhX0Hp3zcHTFRGjQJm9LL8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=2hkzvdKladh1t4cn4cd1p5RLcfM=; b=yZlQTCosPtvnC+VUOC5c KLylcgImnPqiKrJG7FBNMKwYmhFwtBa/O00rMn+LIs+FweKrJfWeD6Rje+6a/W4M nCDrGp8phZa59SXQ5Ua+9mHTKAJjFJ/Rdd/7RjrUPotdDRIPcBZVFjpBfJoLdXon eJUHuAj1nHgr946cSsR07p0= Received: (qmail 74189 invoked by alias); 30 Nov 2017 05:08:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 68129 invoked by uid 89); 30 Nov 2017 05:05:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*googlegroups.com, H*Ad:D*googlegroups.com X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Nov 2017 05:05:20 +0000 Received: by mail-wm0-f52.google.com with SMTP id i71so10515815wmf.2 for ; Wed, 29 Nov 2017 21:05:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QvoV3+T2ZuOIHvMHR/OphpOr6IrwzDHMRmAuGzawWFk=; b=KsFP+0y8AZwOtQvH1Wr6gSoDt8cOIwqyy1uDdPFq5OG/87Je8fw5AY3zPdsyIrQjOd E9oZmSLYte96nbbwKeV9EJJBtcaiPA4RWsgJbIdjl+fbdFAU36PclZ0VGDzeXKIBTtOo ZrnEZQyswyjdbiFS619sX57rjz4X7nMUh6oMtkBiaal/I6MvvxQEVQPn7zFu8LexQ89K 6PpTtrXntEx3jBkBSaLkUZvkuwow4sWROfybc87UenXWeTgGtZ5ospRG3KKynIafAKlw 5kUZ2x97FbqKcso8t6o3gEf9joKOCVePf+XrIn1BY9lyxkB6ZsyiZ2N5NJrsym2ZbXK4 fdOA== X-Gm-Message-State: AJaThX72aHd9+coQxg4gxWjuvmHG7OYInDVRM7vG+aXDDXhuMP6byb7L n04LNuX91O19aCVMZV9uCpD2LmZZ6KUoHV6eobFmmGGn X-Google-Smtp-Source: AGs4zMY3VmTBHCK6mFn4h/rEdOIISG1of4v9jeAn1UlOnC1ulODCt7+aUmxNrOfDWT6BQNwuNej/689HmnNzm5Ospp4= X-Received: by 10.80.135.26 with SMTP id i26mr11055803edb.31.1512018317650; Wed, 29 Nov 2017 21:05:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.179.221 with HTTP; Wed, 29 Nov 2017 21:05:16 -0800 (PST) From: Ian Lance Taylor Date: Wed, 29 Nov 2017 21:05:16 -0800 Message-ID: Subject: Go patch committed: Don't make map zero value constant To: gcc-patches , "gofrontend-dev@googlegroups.com" This patch changes the Go frontend to not make the map zero value constant. The map zero value is a common symbol, and it doesn't really make sense to have a constant common symbol. Current GCC has started to reject this case, probably as part of the fix for PR 83100. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =================================================================== --- gcc/go/gofrontend/MERGE (revision 255090) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -57adb928c3cc61ac8fa47554394670a1c455afc2 +0d6b3abcbfe04949db947081651a503ceb12fe6e The first line of this file holds the git revision number of the last merge done from the gofrontend repository. Index: gcc/go/gofrontend/types.cc =================================================================== --- gcc/go/gofrontend/types.cc (revision 254748) +++ gcc/go/gofrontend/types.cc (working copy) @@ -7717,10 +7717,10 @@ Map_type::backend_zero_value(Gogo* gogo) std::string asm_name(go_selectively_encode_id(zname)); Bvariable* zvar = gogo->backend()->implicit_variable(zname, asm_name, - barray_type, false, true, true, - Map_type::zero_value_align); + barray_type, false, false, true, + Map_type::zero_value_align); gogo->backend()->implicit_variable_set_init(zvar, zname, barray_type, - false, true, true, NULL); + false, false, true, NULL); return zvar; }