From patchwork Sat Mar 13 04:07:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 1452458 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=h0Krzt6l; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dy8KC4H0Rz9sRR for ; Sat, 13 Mar 2021 15:07:25 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29BA33840C1E; Sat, 13 Mar 2021 04:07:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29BA33840C1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1615608439; bh=Fd2gECAun64M0GiUdr3NG4RqDKDuszegG8CweOz/aus=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=h0Krzt6lTYLbejzuC3343/3pUGuavafk+h2Zh3S66G/ix5auBpCh59IjVQguzDK7d wMVt/lAxKLJGWdhp2j71WNYnC2O2JT9keDqlACewOMgzwWXd//cfCyZnyxAOQJM3on C+UuX4hzeMA1RqRiXj3/OqfwoUNJLhySgfwkjQPk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 007C9386185D for ; Sat, 13 Mar 2021 04:07:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 007C9386185D Received: by mail-ej1-x630.google.com with SMTP id c10so57135660ejx.9 for ; Fri, 12 Mar 2021 20:07:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Fd2gECAun64M0GiUdr3NG4RqDKDuszegG8CweOz/aus=; b=srTBouidWc+UczeSs19/C+na8MkCZZd1oahpCA2hxMljND9/Ewvc2bfkmRx03Ch6B+ JsoLVXOxgnqVINWGO2zAgVFwzA6MOkm30NOAWky4iPsdK6TaRE35fLy+5o20iVr9zarM rNTWoKHlGyiHX6JY7uwCMW/o4gtfhXdML/zSy1iNIgmZ1ACV9AvlRKWoX09p4UnO1sbQ CXnnQSUynk7mMQg3yy3gptQNS6MMlFjxZ1FMKfQH7+f5bmdc39dhQ1wbQyVu9PiOPuFv PTkMWREyzzdnNtAx2ZrLXu8QzN/YodkeW25328Eg1nHWFge7tnxBw5qPa1LX4DhE0Y/k wRWQ== X-Gm-Message-State: AOAM532QHcqLHHqEIXDmsWsvM1FC+NLJO5aK/+GSIKMHElwkmV4koZWG ljsVEdJJIru9tsEfloeZ9QeIITvRlWFz+j8n1752mz8dsE3yog== X-Google-Smtp-Source: ABdhPJyK93f5xEHU7rKr5u/3ogvrbHIcDF99/HyBXBm1q0fuM3PLmFBgQ+I1n20Ibj4TviWU5BUPbo8VAmcKSw+D84E= X-Received: by 2002:a17:906:405b:: with SMTP id y27mr12356175ejj.332.1615608435915; Fri, 12 Mar 2021 20:07:15 -0800 (PST) MIME-Version: 1.0 Date: Fri, 12 Mar 2021 20:07:04 -0800 Message-ID: Subject: libgo patch committed: Don't use == for string equality in C code To: gcc-patches , gofrontend-dev X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ian Lance Taylor via Gcc-patches From: Ian Lance Taylor Reply-To: Ian Lance Taylor Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" This patch to libgo avoids using == for string equality in C code. This is a backport of https://golang.org/cl/300993. This is for GCC PR 99553. Bootstrapped and ran gotools testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian eb7eb29c37b1326bd4c8af7e5c35439a5d4521d4 diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 58c881a7872..e5756c6662c 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -bf35249a7c752836741b1cab43a312f87916fcb0 +2f281eb24ef256a2d3bb9fc1a7ef964d82b40182 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/libgo/misc/cgo/testcarchive/testdata/main_unix.c b/libgo/misc/cgo/testcarchive/testdata/main_unix.c index b23ac1c2428..bd00f9d2339 100644 --- a/libgo/misc/cgo/testcarchive/testdata/main_unix.c +++ b/libgo/misc/cgo/testcarchive/testdata/main_unix.c @@ -36,7 +36,7 @@ int install_handler() { return 2; } // gccgo does not set SA_ONSTACK for SIGSEGV. - if (getenv("GCCGO") == "" && (osa.sa_flags&SA_ONSTACK) == 0) { + if (getenv("GCCGO") == NULL && (osa.sa_flags&SA_ONSTACK) == 0) { fprintf(stderr, "Go runtime did not install signal handler\n"); return 2; }