From patchwork Fri Sep 14 19:43:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 970066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-485680-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=golang.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="VljD4hdt"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=golang-org.20150623.gappssmtp.com header.i=@golang-org.20150623.gappssmtp.com header.b="kB1ole9T"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42BmDH1rySz9s4V for ; Sat, 15 Sep 2018 05:43:57 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=QnH7SxrQLKGDZWBm0dIKsx9Ij5vOo3hCM6RhkExCL0p4uY eLMqzRI0MmIXn9v7EFtEFCeVFyO9rfh4atQWO0IkviO0TljtO1BJtTZEEmD+Hhaq KSBw9HemG4mhk+H95CmMy6FwadYFPbSw1q+FkdRITVl/SmapNX3dYr6v91kvc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=I0+4SsGNXiSAiC+rf31Kc8R0kYI=; b=VljD4hdtjCbnw3hydB/E cKzHenQS6+L650m911Qioo6nmhyJKdDQOsc4my8LFi9u9UrxlGlAI53+S4Xfcr7e 5YQ8hbIYjT6v1tN6YHZAjl6Mf4m6pFtW4mq2JkwjIBYv2MfnKiPyNq01zjGZKNS9 ZEljQE2AX0+fuz+Z+7WUE7c= Received: (qmail 129276 invoked by alias); 14 Sep 2018 19:43:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 129266 invoked by uid 89); 14 Sep 2018 19:43:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1579 X-HELO: mail-lj1-f182.google.com Received: from mail-lj1-f182.google.com (HELO mail-lj1-f182.google.com) (209.85.208.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Sep 2018 19:43:48 +0000 Received: by mail-lj1-f182.google.com with SMTP id j19-v6so8428875ljc.7 for ; Fri, 14 Sep 2018 12:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=KnOJ32FZy7YezBHhdhgHSqan1pFfqDYWdQqXgm08cCI=; b=kB1ole9T6WA14yXN33MVMnvE6iNG4GeUtHNUghkr2CYUXRdSNOYsUmMrGqJCjIBj6N pJYhrBV/vG01ruNWLLevYI3hhQoJRQPO7fcaHgorBuKb+D7p1nOLUiwgxCkbAzzIlkb5 7sDIRtEnObX6oV7cIryaavw4DdfosV/Cb8D/b6GhozOIe0o96eufmDbKb9k25FfBBig/ 4KZs7y8Y304RlAj2IYJeqxnEY2KMmdAk2afG7ahSw9RiXa40Eo/IH1yguZoiR+T4Nafa q8/sARReowIV6TxImDSgrJAZeR2TozrGkUkVwvuV624K3EZA5eq+1eM+vGGjXKdbc+Eg Ksag== MIME-Version: 1.0 Received: by 2002:ab3:5609:0:0:0:0:0 with HTTP; Fri, 14 Sep 2018 12:43:44 -0700 (PDT) From: Ian Lance Taylor Date: Fri, 14 Sep 2018 12:43:44 -0700 Message-ID: Subject: libgo patch committed: Correct gccgo buildid file on ARM To: gcc-patches , gofrontend-dev@googlegroups.com This libgo patch changes the go tool to use %progbits rather than @progbits on ARM. This is necessary because gas on ARM uses @ as a comment character. This is a copy of https://golang.org/cl/135297 in the master sources. This fixes GCC PR 87260. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline and GCC 8 branch. Ian Index: gcc/go/gofrontend/MERGE =================================================================== --- gcc/go/gofrontend/MERGE (revision 264325) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -3fd61802286c81e5fb672f682d9e661181184d1f +92a14213215fd93df7240fa9d376a1213b1d5a74 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. Index: libgo/go/cmd/go/internal/work/buildid.go =================================================================== --- libgo/go/cmd/go/internal/work/buildid.go (revision 264245) +++ libgo/go/cmd/go/internal/work/buildid.go (working copy) @@ -337,8 +337,12 @@ func (b *Builder) gccgoBuildIDELFFile(a } fmt.Fprintf(&buf, "\n") if cfg.Goos != "solaris" { - fmt.Fprintf(&buf, "\t"+`.section .note.GNU-stack,"",@progbits`+"\n") - fmt.Fprintf(&buf, "\t"+`.section .note.GNU-split-stack,"",@progbits`+"\n") + secType := "@progbits" + if cfg.Goarch == "arm" { + secType = "%progbits" + } + fmt.Fprintf(&buf, "\t"+`.section .note.GNU-stack,"",%s`+"\n", secType) + fmt.Fprintf(&buf, "\t"+`.section .note.GNU-split-stack,"",%s`+"\n", secType) } if cfg.BuildN || cfg.BuildX {