From patchwork Wed May 28 11:33:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Stupachenko X-Patchwork-Id: 353374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6D6ED1400D8 for ; Wed, 28 May 2014 21:33:32 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=MQTO+xsgoMQ2bh8YDv H9JrT+kfQo1t7BWGdoY2UCHYciHQFKFnsizp3tLukHYjY/yZ1ZGappDy+Mi6fNjd bVYjaJhXcpY0LAj0I4rvl7IMaQ/OZJ69d/k8EnAD5Q830Rizw4pZtwDtPgnaII3H UbGTLbZTEtxBN7YoMSNlleLSI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=iwSrz5r8QPROIVj0JfnLySEP SmI=; b=UiUkXzl1gmAXbyhjMBYpnm7lpsPGJqxZdpbc4uGsjvARPFNVLqctlmPN DEjGcVy3SHZyEvBjC+bU5Aze97xp9jZOpVctZSUMglMSouSgt/mDlBTIBhbGHHPE okq0Z8N9A6VP1xWD8M7JBudn7Ztx3fBZ9kVpkDyILZWLBgf2ok8= Received: (qmail 7529 invoked by alias); 28 May 2014 11:33:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7520 invoked by uid 89); 28 May 2014 11:33:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f170.google.com Received: from mail-ob0-f170.google.com (HELO mail-ob0-f170.google.com) (209.85.214.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 28 May 2014 11:33:17 +0000 Received: by mail-ob0-f170.google.com with SMTP id uy5so10737131obc.1 for ; Wed, 28 May 2014 04:33:16 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.81.200 with SMTP id c8mr19225782oey.75.1401276795981; Wed, 28 May 2014 04:33:15 -0700 (PDT) Received: by 10.76.18.209 with HTTP; Wed, 28 May 2014 04:33:15 -0700 (PDT) In-Reply-To: <20140528105536.GA10386@tucnak.redhat.com> References: <20140516132154.GA10386@tucnak.redhat.com> <20140528105536.GA10386@tucnak.redhat.com> Date: Wed, 28 May 2014 15:33:15 +0400 Message-ID: Subject: Re: [PATCH, PR52252] Vectorization for load/store groups of size 3. From: Evgeny Stupachenko To: Jakub Jelinek Cc: Rainer Orth , Richard Biener , GCC Patches , Uros Bizjak X-IsSubscribed: yes Ok. Fixed. Test still passes on x86: /* { dg-final { cleanup-tree-dump "vect" } } */ On Wed, May 28, 2014 at 2:55 PM, Jakub Jelinek wrote: > On Wed, May 28, 2014 at 02:51:57PM +0400, Evgeny Stupachenko wrote: >> Does the following fix ok? >> >> 2014-05-28 Evgeny Stupachenko >> >> * gcc.dg/vect/pr52252-ld.c: Fix target and options for the test. >> >> diff --git a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >> b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >> index 6e3cb52..57e8468 100644 >> --- a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >> +++ b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >> @@ -1,6 +1,6 @@ >> /* { dg-do compile } */ >> -/* { dg-options "-O2 -g -ftree-vectorize -mssse3 >> -fdump-tree-vect-details" { target { i?86-*-* x86_64-* >> - >> +/* { dg-options "-O2 -g -ftree-vectorize -fdump-tree-vect-details" } */ > > dg-options should not be used in g*.dg/vect/* at all. > Not sure about -g, but the other options are provided by default already, > and shouldn't be overriden. > > Jakub diff --git a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c index 6e3cb52..e37b177 100644 --- a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c +++ b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c @@ -1,6 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -g -ftree-vectorize -mssse3 -fdump-tree-vect-details" { target { i?86-*-* x86_64-*-* } } } */ - +/* { dg-additional-options "-mssse3" { target { i?86-*-* x86_64-*-* } } } */ #define byte unsigned char void @@ -26,5 +25,5 @@ matrix_mul (byte *in, byte *out, int size) } } -/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */ +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target { i?86-*-* x86_64-*-* } } } } */