| Message ID | CAO2gOZWR6aa7zbVK-DzwbTMrGSw6-TYCQv_02d3-ehfJu4ENvw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
ok. David On Wed, Feb 26, 2014 at 3:43 PM, Dehao Chen <dehao@google.com> wrote: > Yes, patch updated: > > Index: gcc/auto-profile.c > =================================================================== > --- gcc/auto-profile.c (revision 207970) > +++ gcc/auto-profile.c (working copy) > @@ -1371,8 +1371,7 @@ afdo_vpt_for_early_inline (stmt_set *promoted_stmt > calculate_dominance_info (CDI_DOMINATORS); > rebuild_cgraph_edges (); > update_ssa (TODO_update_ssa); > - compute_inline_parameters (cgraph_get_node (current_function_decl), > - false); > + compute_inline_parameters (cgraph_get_node > (current_function_decl), true); > return true; > } > else > @@ -1533,6 +1532,7 @@ auto_profile (void) > early_inliner (); > } > > + compute_inline_parameters (cgraph_get_node > (current_function_decl), true); > early_inliner (); > autofdo::afdo_annotate_cfg (promoted_stmts); > compute_function_frequency (); > > Dehao > > On Wed, Feb 26, 2014 at 3:25 PM, Xinliang David Li <davidxl@google.com> wrote: >> On Wed, Feb 26, 2014 at 3:23 PM, Dehao Chen <dehao@google.com> wrote: >>> This patch fixes the bug of not calling compute_inline_parameters >>> before early_inliner, which would lead to ICE. >>> >>> Testing on going, OK for google-4_8 if test passes? >>> >>> Thanks, >>> Dehao >>> >>> Index: gcc/auto-profile.c >>> =================================================================== >>> --- gcc/auto-profile.c (revision 207970) >>> +++ gcc/auto-profile.c (working copy) >>> @@ -1533,6 +1533,8 @@ auto_profile (void) >>> early_inliner (); >>> } >>> >>> + compute_inline_parameters (cgraph_get_node (current_function_decl), >>> + false); >> >> false --> true ? >> >> David >> >>> early_inliner (); >>> autofdo::afdo_annotate_cfg (promoted_stmts); >>> compute_function_frequency ();
Index: gcc/auto-profile.c =================================================================== --- gcc/auto-profile.c (revision 207970) +++ gcc/auto-profile.c (working copy) @@ -1371,8 +1371,7 @@ afdo_vpt_for_early_inline (stmt_set *promoted_stmt calculate_dominance_info (CDI_DOMINATORS); rebuild_cgraph_edges (); update_ssa (TODO_update_ssa); - compute_inline_parameters (cgraph_get_node (current_function_decl), - false); + compute_inline_parameters (cgraph_get_node (current_function_decl), true); return true; }
Yes, patch updated: else @@ -1533,6 +1532,7 @@ auto_profile (void) early_inliner (); } + compute_inline_parameters (cgraph_get_node (current_function_decl), true); early_inliner (); autofdo::afdo_annotate_cfg (promoted_stmts); compute_function_frequency (); Dehao On Wed, Feb 26, 2014 at 3:25 PM, Xinliang David Li <davidxl@google.com> wrote: > On Wed, Feb 26, 2014 at 3:23 PM, Dehao Chen <dehao@google.com> wrote: >> This patch fixes the bug of not calling compute_inline_parameters >> before early_inliner, which would lead to ICE. >> >> Testing on going, OK for google-4_8 if test passes? >> >> Thanks, >> Dehao >> >> Index: gcc/auto-profile.c >> =================================================================== >> --- gcc/auto-profile.c (revision 207970) >> +++ gcc/auto-profile.c (working copy) >> @@ -1533,6 +1533,8 @@ auto_profile (void) >> early_inliner (); >> } >> >> + compute_inline_parameters (cgraph_get_node (current_function_decl), >> + false); > > false --> true ? > > David > >> early_inliner (); >> autofdo::afdo_annotate_cfg (promoted_stmts); >> compute_function_frequency ();