From patchwork Tue Sep 6 18:06:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Gallager X-Patchwork-Id: 666681 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sTF0k5vtnz9sCg for ; Wed, 7 Sep 2016 04:06:46 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=PvFk2AvE; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=I3jkjHw5vkDcdr5 lzjiBBJtk2NSgG3Qj9h796eItmDW7wPHjcbmPcGSPxjc+umvjep9crC64DzC/zP/ 05k6EyOGyPiv16WmZSaidWfZrGz+6+lQEF7MAq38ULvr8c5u3q6ypzBIG8cTW2Ym us3Ce54f1uBG+s8XYudehdPGr+Qw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=BQ0rbnee9k586AHtypmGu yisZVI=; b=PvFk2AvEsYSBtGLMQVK5a9OaZA50FJzwLtuAwzFfxddiaMZDE/CyU iNZKSZwwDpzq+z2QozRrtIuxI+2THUOdWLMZx3gkMbj63tXVpZqwAPzFCe0RN6Zf 0UQUQQs0cAUdsgZC8EJ8jq1ucO5lgwRyHfe+BaxeS64TfTjAlvZMxU= Received: (qmail 46193 invoked by alias); 6 Sep 2016 18:06:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 46184 invoked by uid 89); 6 Sep 2016 18:06:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.5 required=5.0 tests=BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=promotes, sk:bc0570d, optsc, i386.c X-HELO: mail-oi0-f65.google.com Received: from mail-oi0-f65.google.com (HELO mail-oi0-f65.google.com) (209.85.218.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Sep 2016 18:06:25 +0000 Received: by mail-oi0-f65.google.com with SMTP id w78so10554216oie.0 for ; Tue, 06 Sep 2016 11:06:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xDOaG02w3+vsWfVoq7NIgDgEIxU/dPzluzpGUQsdltU=; b=SJhISyIK0Osmfn11twaNTwoZ6CYrC48BFx+NHSDDtzmHawuM8jDfTjvQGTeDUcCDV7 kCnBDDdSDLm4qk4PtSsMxGoXgUUJvw57l4b2VS4jrF7eanhnhMYOasUDkOuiXngiDFu3 /rlA9wzrvPD6rX+TFtRg2wX1RgCXCKDhpasJDoPo1n1WZsfE49k4C8oZ3qXgoWtgBqQk D9oWhNJW5SeFLLw8Kn7JpquJv1twVkCO1iOtimQhTxfMO1uzdZlag46hahIqrnJ/K3iS c1SCqjpqqpBSjgjvsvmg6YwjeWCajCrulD4CsxLoivivcuw73FCYnUyhVn6wWRwiHvNw l+gw== X-Gm-Message-State: AE9vXwNtfvM/U2WITrWrw5YMtS86kYbHriCJmdE7ZO7xI3RYgCRJDVLiLsZki15Pb+G3x0d5o/Hxlx+6tE5x9iyj X-Received: by 10.36.40.130 with SMTP id h124mr31240358ith.89.1473185183797; Tue, 06 Sep 2016 11:06:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.98.148 with HTTP; Tue, 6 Sep 2016 11:06:23 -0700 (PDT) In-Reply-To: References: From: Eric Gallager Date: Tue, 6 Sep 2016 14:06:23 -0400 Message-ID: Subject: Re: [PING] Re: [PATCH, i386] Fix some warnings/errors that appear when enabling -Wnarrowing when building gcc To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes On 9/6/16, Uros Bizjak wrote: > On Tue, Sep 6, 2016 at 5:33 PM, Eric Gallager wrote: >> Ping? CC-ing an i386 maintainer since the patch mostly touches >> i386-specific files. Also, to clarify, I say "warnings/errors" because >> they start off as warnings in stage 1 but then become errors in stage >> 2. Note also that my patch leaves out the part where I modify the >> configure script to enable -Wnarrowing, because the rest of the code >> isn't quite ready for that yet. > > You are probably referring to [1]? It looks OK, modulo: > > +DEF_TUNE (X86_TUNE_QIMODE_MATH, "qimode_math", ~(0U)) > > where parenthesis are not needed. > > > Please resubmit the patch with a ChangeLog entry, as instructed in [2] > > [1] https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02129.html > [2] https://gcc.gnu.org/contribute.html#patches > > Uros. > Okay, reattached. Here's a ChangeLog entry to put in gcc/ChangeLog: 2016-09-06 Eric Gallager * config/i386/i386.c: Add 'U' suffix to constants to avoid -Wnarrowing. * config/i386/x86-tune.def: Likewise. * opts.c: Likewise. (Please also note that I don't have commit access.) Thanks, Eric gcc/config/i386/i386.c | 60 ++++++++++++++++++++++---------------------- gcc/config/i386/x86-tune.def | 6 ++--- gcc/opts.c | 4 +-- 3 files changed, 35 insertions(+), 35 deletions(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 4531647..181fc39 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -2162,45 +2162,45 @@ const struct processor_costs *ix86_tune_cost = &pentium_cost; const struct processor_costs *ix86_cost = &pentium_cost; /* Processor feature/optimization bitmasks. */ -#define m_386 (1<