From patchwork Thu Oct 13 21:39:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 681984 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sw3z13CWhz9srZ for ; Fri, 14 Oct 2016 08:39:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=KNcYZ3e3; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=dBwsS6gRitRu6jg Kp/oFldtpHtepK/oPInxvUWwpMefhl2RwyNPsTvLd3nttNa7lDWMLS8vT2ARlOWC t6edk6EjlKSvDAPI1oGrcNOmi/5zd3onmNadoYhwRIKuR7r4HcLtHuPJiQ7wIJ7E tPYGbQnTTSXULozFBHkZ9+8+dEFk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=C8Z93peCZVqR6odyypv1z WfcKDI=; b=KNcYZ3e3nkMmKQkD5bGKsBOLG92UL55LilAYhvatDe9heniN2GdMu 5/qyV6ESQNbwtZSDnFRog+/f65+VAmFpPwhoTJtRaP4n3wnpkg5lEIW/oGl18YMp 93wtcWXXTx9Ur2J88GntameJZrliCLb9cwNBS6jS2evp7UonyWyd2c= Received: (qmail 84779 invoked by alias); 13 Oct 2016 21:39:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 84760 invoked by uid 89); 13 Oct 2016 21:39:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL, BAYES_50, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=sk:andrew, RCS, Mask, 5* X-HELO: mail-qk0-f174.google.com Received: from mail-qk0-f174.google.com (HELO mail-qk0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 21:39:03 +0000 Received: by mail-qk0-f174.google.com with SMTP id z190so117400821qkc.2 for ; Thu, 13 Oct 2016 14:39:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YkdWlpIF9WC5kgzSMC9Z8l9OqIFFdzi89YVVG7JU10A=; b=iWmDCyJRVIxN7O/9d4J5h19tHCgjX2KOk/kVdtJELEuOqIus63epQZP4k/rhg0tI97 ZZqcmGlgewSGnoN3Jl8u7pNimt3gFOku6RsCXh832rM5ON3xN8nRSk0RUtT0FT8a2ViS lFFawZ+BdhVU7ww3P9SlZl8Uv6f0Blt6paHdVd2aG5QbCayEBNRQBvaxMLPVQOu71e6k xkzWU4Om72/O8uGiILOyhzBdz71TN0yzW6JFlY6s/6sIEyLU105T/4RVa5vnctmUvAqk YTcvrDnU6Ag5MGAErkId3tyE+e+/WeveuQ3GaPsVjGu4r5YqgEmVYXdVhjg6VjJPbwWO gxeA== X-Gm-Message-State: AA6/9RnzRVJbTJNJ6U0hkl8uJjhLZoGOph0wc98ebLRRq19p3XziphApe2L3V+SlRux8DprdBAaiLBLl+oK+ZA== X-Received: by 10.55.189.132 with SMTP id n126mr9485072qkf.275.1476394742167; Thu, 13 Oct 2016 14:39:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.169.16 with HTTP; Thu, 13 Oct 2016 14:39:01 -0700 (PDT) In-Reply-To: References: From: "H.J. Lu" Date: Thu, 13 Oct 2016 14:39:01 -0700 Message-ID: Subject: Re: [PATCH] Remove x86 pcommit instruction To: Andrew Senkevich Cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes On Thu, Oct 13, 2016 at 5:09 AM, Andrew Senkevich wrote: > 2016-10-11 20:09 GMT+03:00 H.J. Lu : >> On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich >> wrote: >>> 2016-10-06 1:07 GMT+03:00 H.J. Lu : >>>> On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich >>>> wrote: >>>>> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : >>>>>> On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich >>>>>> wrote: >>>>>>>> -mpcommit >>>>>>>> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save >>>>>>>> -Support PCOMMIT instruction. >>>>>>>> - >>>>>>>> >>>>>>>> You should not simply delete a option that was in the released >>>>>>>> compiler, but a warning should be emitted instead. Please see how >>>>>>>> msse5 is handled in i386.opt. >>>>>>> >>>>>>> Thank you, it is fixed in patch below. Ok for trunk? >>>>>> >>>>>> OK. >>>>>> >>>>>>> Is it subject for backport for 5.* and 6.* releases? >>>>>> >>>>>> Yes, but please wait a couple of days if any problem arises in trunk. >>>>>> >>>>>> (Please also provide an entry for Release Changes, since this is >>>>>> user-facing change. Also for release branches.) >>>>> >>>>> Hi HJ, >>>>> >>>>> could you please commit this patch for trunk since I have no commit rights. >>>>> Attached in format for git am. >>>>> >>>>> >>>> >>>> Done. >>> >>> Thanks, HJ! >>> >>> Should I ask you or somebody else for backports for to 5.* and 6.* or >>> may be I can somehow get commit after approval rights to don't disturb >>> others with commits? I am preparing several patches. >>> >> >> Please provide patches for GCC 5 and 6. > > Attached. I checked them into GCC 5 and GCC 6 branches. > Have you possibility to update according changes.html files? > Here is the patch for GCC 7. I am not sure what to do with GCC 5 and 6. Index: gcc-7/changes.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v retrieving revision 1.18 diff -u -p -r1.18 changes.html --- gcc-7/changes.html 12 Oct 2016 11:08:25 -0000 1.18 +++ gcc-7/changes.html 13 Oct 2016 21:37:18 -0000 @@ -318,7 +318,14 @@ const int* get_address (unsigned idx) - +

IA-32/x86-64

+
    +
  • + Support for + deprecated + pcommit instruction has been removed. +
    • +