From patchwork Tue Jan 13 23:25:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 428750 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CF9FD140161 for ; Wed, 14 Jan 2015 10:25:22 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=X6mg1izIqvj2oymD96 rZLCIyjiAK/xTwTNx8xoKeABuqARJv1IczPTBLVYPDP+ZqcHBAlw+SuVfis7ymiJ cc6T/9/rLmBFQ5UNuoVlnB6wFdkgwZOffDaeWW7AH64kYPuBb5Xm3iv6B5rPEwyI ZBkdLho9KmXob6oF9ng1/tRag= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=75lShw12MrQeTDwW62/2UvDd 4Vo=; b=rqPutk3NpK6r8l/+Kv/3JTiA8R2dY9ogKCX7btwmao1y/aHcbq3+FnWT zKfsqeDDm4xd6Hwyccv/kvH9G70nxIM+xWPzip76EEjmVvVhtxtFR6Xwcoksz0dB MFwMLiX9qU00qMcsKmwEGoS/zDnKiHj2IWUIAxgNXkCr5nf99ek= Received: (qmail 29176 invoked by alias); 13 Jan 2015 23:25:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 29163 invoked by uid 89); 13 Jan 2015 23:25:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f175.google.com Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 13 Jan 2015 23:25:10 +0000 Received: by mail-ob0-f175.google.com with SMTP id va8so994422obc.6 for ; Tue, 13 Jan 2015 15:25:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.202.191.194 with SMTP id p185mr549954oif.128.1421191508197; Tue, 13 Jan 2015 15:25:08 -0800 (PST) Received: by 10.76.185.7 with HTTP; Tue, 13 Jan 2015 15:25:08 -0800 (PST) In-Reply-To: <20150113130327.GA18618@gmail.com> References: <4827012.p4mTkPPu1h@laptop1.gw.ume.nu> <2546517.6r217PbQ20@laptop1.gw.ume.nu> <3640063.8rDKLvUbS6@laptop1.gw.ume.nu> <1625902.vd5h90ZESU@laptop1.gw.ume.nu> <20150112161023.GA6392@gmail.com> <20150113130327.GA18618@gmail.com> Date: Tue, 13 Jan 2015 15:25:08 -0800 Message-ID: Subject: Re: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option From: "H.J. Lu" To: Joseph Myers Cc: Richard Biener , Magnus Granberg , GCC Patches , danielmicay X-IsSubscribed: yes On Tue, Jan 13, 2015 at 5:03 AM, H.J. Lu wrote: > On Mon, Jan 12, 2015 at 11:50:41PM +0000, Joseph Myers wrote: >> On Mon, 12 Jan 2015, H.J. Lu wrote: >> >> > +if test x$enable_default_pie = xyes; then >> > + AC_MSG_CHECKING(if $target supports default PIE) >> > + enable_default_pie=no >> > + case $target in >> > + i?86*-*-linux* | x86_64*-*-linux*) >> > + saved_LDFLAGS="$LDFLAGS" >> > + saved_CFLAGS="$CFLAGS" >> > + CFLAGS="$CFLAGS -fPIE" >> > + LDFLAGS="$LDFLAGS -fPIE -pie" >> > + AC_TRY_LINK(,,[enable_default_pie=yes],) >> > + LDFLAGS="$saved_LDFLAGS" >> > + CFLAGS="$saved_CFLAGS" >> > + ;; >> > + *) >> > + ;; >> > + esac >> >> There should not be any such hardcoding of targets here without concrete >> evidence that the targets for which this sets enable_default_pie=no really >> cannot support PIE. In particular, there is no reason at all for this to >> be architecture-specific; all GNU/Linux architectures should support PIE. >> >> I believe AC_TRY_LINK here will test for the host, whereas what you want >> to know is what's supported for the target (but it's not possible to run >> link tests for the target at this point; the compiler for the target >> hasn't even been built). >> >> So: just presume that if the user passes --enable-default-pie then they >> know what they are doing, and don't try to override their choice. >> >> > diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi >> > index c9e3bf1..89fc305 100644 >> > --- a/gcc/doc/install.texi >> > +++ b/gcc/doc/install.texi >> > @@ -1583,6 +1583,10 @@ not be built. >> > Specify that the run-time libraries for stack smashing protection >> > should not be built. >> > >> > +@item --enable-default-pie >> > +Turn on @option{-fPIE} and @option{-pie} by default if supported. >> > +Currently supported targets are i?86-*-linux* and x86-64-*-linux*. >> >> The "if supported" and target list can then be removed here. >> > > Here is the updated patch. To support --enable-default-pie, each target > must update STARTFILE_SPEC to support PIE_SPEC and NO_PIE_SPEC. I can > provide STARTFILE_SPEC patch if needed. > > Thanks. > > > H.J. > --- > gcc/ > > 2015-01-12 Magnus Granberg > H.J. Lu > > * Makefile.in (COMPILER): Add @NO_PIE_CFLAGS@. > (LINKER): Add @NO_PIE_FLAG@. > (libgcc.mvars): Set NO_PIE_CFLAGS to -fno-PIE for > --enable-default-pie. > * common.opt (fPIE): Initialize to -1. > (fpie): Likewise. > (static): Add "RejectNegative Negative(shared)". > (no-pie): New option. > (pie): Replace "Negative(shared)" with "Negative(no-pie)". > * configure.ac: Add --enable-default-pie. > (NO_PIE_CFLAGS): New. Check if -fno-PIE works. AC_SUBST. > (NO_PIE_FLAG): New. Check if -no-pie works. AC_SUBST. > * defaults.h (DEFAULT_FLAG_PIE): New. Default PIE to -fPIE. > * gcc.c (NO_PIE_SPEC): New. > (PIE_SPEC): Likewise. > (LD_PIE_SPEC): Likewise. > (LINK_PIE_SPEC): Handle -no-pie. Use PIE_SPEC and LD_PIE_SPEC. > * opts.c (DEFAULT_FLAG_PIE): New. Set to 0 if ENABLE_DEFAULT_PIE > is undefined. > (finish_options): Update opts->x_flag_pie if it is -1. > * config/gnu-user.h (FVTABLE_VERIFY_SPEC): New. > (GNU_USER_TARGET_STARTFILE_SPEC): Use FVTABLE_VERIFY_SPEC. Use > NO_PIE_SPEC and NO_PIE_SPEC if ENABLE_DEFAULT_PIE is defined. > (GNU_USER_TARGET_STARTFILE_SPEC): Use FVTABLE_VERIFY_SPEC. > * doc/install.texi: Document --enable-default-pie. > * doc/invoke.texi: Document -no-pie. > * config.in: Regenerated. > * configure: Likewise. > > gcc/ada/ > > 2015-01-12 H.J. Lu > > * gcc-interface/Makefile.in (TOOLS_LIBS): Add @NO_PIE_FLAG@. > > libgcc/ > > 2015-01-12 H.J. Lu > > * Makefile.in (CRTSTUFF_CFLAGS): Add $(NO_PIE_CFLAGS). > This is the updated patch. I fixed the -r regression. LTO tests pass now. gcc/ 2015-01-12 Magnus Granberg H.J. Lu * Makefile.in (COMPILER): Add @NO_PIE_CFLAGS@. (LINKER): Add @NO_PIE_FLAG@. (libgcc.mvars): Set NO_PIE_CFLAGS to -fno-PIE for --enable-default-pie. * common.opt (fPIE): Initialize to -1. (fpie): Likewise. (no-pie): New option. (pie): Replace "Negative(shared)" with "Negative(no-pie)". * configure.ac: Add --enable-default-pie. (NO_PIE_CFLAGS): New. Check if -fno-PIE works. AC_SUBST. (NO_PIE_FLAG): New. Check if -no-pie works. AC_SUBST. * defaults.h (DEFAULT_FLAG_PIE): New. Default PIE to -fPIE. * gcc.c (NO_PIE_SPEC): New. (PIE_SPEC): Likewise. (LD_PIE_SPEC): Likewise. (LINK_PIE_SPEC): Handle -no-pie. Use PIE_SPEC and LD_PIE_SPEC. * opts.c (DEFAULT_FLAG_PIE): New. Set to 0 if ENABLE_DEFAULT_PIE is undefined. (finish_options): Update opts->x_flag_pie if it is -1. * config/gnu-user.h (FVTABLE_VERIFY_SPEC): New. (GNU_USER_TARGET_STARTFILE_SPEC): Use FVTABLE_VERIFY_SPEC. Use PIE_SPEC and NO_PIE_SPEC if ENABLE_DEFAULT_PIE is defined. (GNU_USER_TARGET_STARTFILE_SPEC): Use FVTABLE_VERIFY_SPEC. * doc/install.texi: Document --enable-default-pie. * doc/invoke.texi: Document -no-pie. * config.in: Regenerated. * configure: Likewise. gcc/ada/ 2015-01-12 H.J. Lu * gcc-interface/Makefile.in (TOOLS_LIBS): Add @NO_PIE_FLAG@. libgcc/ 2015-01-12 H.J. Lu * Makefile.in (CRTSTUFF_CFLAGS): Add $(NO_PIE_CFLAGS). diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 5f9261f..180751f 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -252,6 +252,12 @@ LINKER = $(CC) LINKER_FLAGS = $(CFLAGS) endif +# We don't want to compile the compiler with -fPIE, it make PCH fail. +COMPILER += @NO_PIE_CFLAGS@ + +# Link with -no-pie since we compile the compiler with -fno-PIE. +LINKER += @NO_PIE_FLAG@ + # Like LINKER, but use a mutex for serializing front end links. ifeq (@DO_LINK_MUTEX@,true) LLINKER = $(SHELL) $(srcdir)/lock-and-run.sh linkfe.lck $(LINKER) @@ -1854,6 +1860,12 @@ libgcc.mvars: config.status Makefile specs xgcc$(exeext) echo GCC_CFLAGS = '$(GCC_CFLAGS)' >> tmp-libgcc.mvars echo INHIBIT_LIBC_CFLAGS = '$(INHIBIT_LIBC_CFLAGS)' >> tmp-libgcc.mvars echo TARGET_SYSTEM_ROOT = '$(TARGET_SYSTEM_ROOT)' >> tmp-libgcc.mvars + if test @enable_default_pie@ = yes; then \ + NO_PIE_CFLAGS="-fno-PIE"; \ + else \ + NO_PIE_CFLAGS=; \ + fi; \ + echo NO_PIE_CFLAGS = "$$NO_PIE_CFLAGS" >> tmp-libgcc.mvars mv tmp-libgcc.mvars libgcc.mvars diff --git a/gcc/ada/gcc-interface/Makefile.in b/gcc/ada/gcc-interface/Makefile.in index 870cfab..a446d48 100644 --- a/gcc/ada/gcc-interface/Makefile.in +++ b/gcc/ada/gcc-interface/Makefile.in @@ -267,6 +267,9 @@ TOOLS_LIBS = ../link.o ../targext.o ../../ggc-none.o ../../libcommon-target.a \ ../../libcommon.a ../../../libcpp/libcpp.a $(LIBGNAT) $(LIBINTL) $(LIBICONV) \ ../$(LIBBACKTRACE) ../$(LIBIBERTY) $(SYSLIBS) $(TGT_LIB) +# Add -no-pie to TOOLS_LIBS since some of them are compiled with -fno-PIE. +TOOLS_LIBS += @NO_PIE_FLAG@ + # Specify the directories to be searched for header files. # Both . and srcdir are used, in that order, # so that tm.h and config.h will be found in the compilation diff --git a/gcc/common.opt b/gcc/common.opt index e104269..47f9fa2 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -1755,7 +1755,7 @@ Common Report Var(flag_pic,2) Negative(fPIE) Generate position-independent code if possible (large mode) fPIE -Common Report Var(flag_pie,2) Negative(fpic) +Common Report Var(flag_pie,2) Negative(fpic) Init(-1) Generate position-independent code for executables if possible (large mode) fpic @@ -1763,7 +1763,7 @@ Common Report Var(flag_pic,1) Negative(fpie) Generate position-independent code if possible (small mode) fpie -Common Report Var(flag_pie,1) Negative(fPIC) +Common Report Var(flag_pie,1) Negative(fPIC) Init(-1) Generate position-independent code for executables if possible (small mode) fplugin= @@ -2823,8 +2823,12 @@ Driver symbolic Driver -pie +no-pie Driver RejectNegative Negative(shared) +Don't create a position independent executable + +pie +Driver RejectNegative Negative(no-pie) Create a position independent executable z diff --git a/gcc/config.in b/gcc/config.in index f34adb5..3fc018a 100644 --- a/gcc/config.in +++ b/gcc/config.in @@ -89,6 +89,12 @@ #endif +/* Define if your target supports default PIE and it is enabled. */ +#ifndef USED_FOR_TARGET +#undef ENABLE_DEFAULT_PIE +#endif + + /* Define if you want more run-time sanity checks for dataflow. */ #ifndef USED_FOR_TARGET #undef ENABLE_DF_CHECKING diff --git a/gcc/config/gnu-user.h b/gcc/config/gnu-user.h index 2faa2e5..5cbe5da 100644 --- a/gcc/config/gnu-user.h +++ b/gcc/config/gnu-user.h @@ -41,19 +41,29 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see object constructed before entering `main'. */ #if defined HAVE_LD_PIE -#define GNU_USER_TARGET_STARTFILE_SPEC \ - "%{!shared: %{pg|p|profile:gcrt1.o%s;pie:Scrt1.o%s;:crt1.o%s}} \ - crti.o%s %{static:crtbeginT.o%s;shared|pie:crtbeginS.o%s;:crtbegin.o%s} \ - %{fvtable-verify=none:%s; \ +#define FVTABLE_VERIFY_SPEC \ + "%{fvtable-verify=none:%s; \ fvtable-verify=preinit:vtv_start_preinit.o%s; \ fvtable-verify=std:vtv_start.o%s}" +#if defined ENABLE_DEFAULT_PIE +#define GNU_USER_TARGET_STARTFILE_SPEC \ + "%{!shared: %{pg|p|profile:gcrt1.o%s;: \ + %{" PIE_SPEC ":Scrt1.o%s} %{" NO_PIE_SPEC ":crt1.o%s}}} \ + crti.o%s %{static:crtbeginT.o%s;: %{shared:crtbeginS.o%s} \ + %{" PIE_SPEC ":crtbeginS.o%s} \ + %{" NO_PIE_SPEC ":crtbegin.o%s}}" \ + FVTABLE_VERIFY_SPEC +#else +#define GNU_USER_TARGET_STARTFILE_SPEC \ + "%{!shared: %{pg|p|profile:gcrt1.o%s;pie:Scrt1.o%s;:crt1.o%s}} \ + crti.o%s %{static:crtbeginT.o%s;shared|pie:crtbeginS.o%s;:crtbegin.o%s}" \ + FVTABLE_VERIFY_SPEC +#endif #else #define GNU_USER_TARGET_STARTFILE_SPEC \ "%{!shared: %{pg|p|profile:gcrt1.o%s;:crt1.o%s}} \ - crti.o%s %{static:crtbeginT.o%s;shared|pie:crtbeginS.o%s;:crtbegin.o%s} \ - %{fvtable-verify=none:%s; \ - fvtable-verify=preinit:vtv_start_preinit.o%s; \ - fvtable-verify=std:vtv_start.o%s}" + crti.o%s %{static:crtbeginT.o%s;shared|pie:crtbeginS.o%s;:crtbegin.o%s}" \ + FVTABLE_VERIFY_SPEC #endif #undef STARTFILE_SPEC #define STARTFILE_SPEC GNU_USER_TARGET_STARTFILE_SPEC diff --git a/gcc/configure b/gcc/configure index 1bf4358..980c680 100755 --- a/gcc/configure +++ b/gcc/configure @@ -600,6 +600,9 @@ ac_includes_default="\ ac_subst_vars='LTLIBOBJS LIBOBJS +NO_PIE_FLAG +NO_PIE_CFLAGS +enable_default_pie PICFLAG enable_host_shared enable_plugin @@ -937,6 +940,7 @@ enable_host_shared enable_libquadmath_support with_linker_hash_style with_diagnostics_color +enable_default_pie ' ac_precious_vars='build_alias host_alias @@ -1665,6 +1669,7 @@ Optional Features: --enable-host-shared build host code as shared libraries --disable-libquadmath-support disable libquadmath support for Fortran + --enable-default-pie enable Position Independent Executable as default Optional Packages: --with-PACKAGE[=ARG] use PACKAGE [ARG=yes] @@ -18147,7 +18152,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 18150 "configure" +#line 18155 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -18253,7 +18258,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 18256 "configure" +#line 18261 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -28432,6 +28437,76 @@ cat > gcc-driver-name.h <>confdefs.h + +fi + + +# Check if -fno-PIE works. +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fno-PIE option" >&5 +$as_echo_n "checking for -fno-PIE option... " >&6; } +if test "${gcc_cv_c_no_fpie+set}" = set; then : + $as_echo_n "(cached) " >&6 +else + saved_CFLAGS="$CFLAGS" + CFLAGS="$CFLAGS -fno-PIE" + cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ +int main(void) {return 0;} +_ACEOF +if ac_fn_c_try_compile "$LINENO"; then : + gcc_cv_c_no_fpie=yes +else + gcc_cv_c_no_fpie=no +fi +rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext + CFLAGS="$saved_CFLAGS" +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_c_no_fpie" >&5 +$as_echo "$gcc_cv_c_no_fpie" >&6; } +if test "$gcc_cv_c_no_fpie" = "yes"; then + NO_PIE_CFLAGS="-fno-PIE" +fi + + +# Check if -no-pie works. +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -no-pie option" >&5 +$as_echo_n "checking for -no-pie option... " >&6; } +if test "${gcc_cv_no_pie+set}" = set; then : + $as_echo_n "(cached) " >&6 +else + saved_LDFLAGS="$LDFLAGS" + LDFLAGS="$LDFLAGS -no-pie" + cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ +int main(void) {return 0;} +_ACEOF +if ac_fn_c_try_link "$LINENO"; then : + gcc_cv_no_pie=yes +else + gcc_cv_no_pie=no +fi +rm -f core conftest.err conftest.$ac_objext \ + conftest$ac_exeext conftest.$ac_ext + LDFLAGS="$saved_LDFLAGS" +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_no_pie" >&5 +$as_echo "$gcc_cv_no_pie" >&6; } +if test "$gcc_cv_no_pie" = "yes"; then + NO_PIE_FLAG="-no-pie" +fi + + # Configure the subdirectories # AC_CONFIG_SUBDIRS($subdirs) diff --git a/gcc/configure.ac b/gcc/configure.ac index 102dab9..e6da960 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -5759,6 +5759,46 @@ cat > gcc-driver-name.h <x_flag_section_anchors = 0; } +#ifndef ENABLE_DEFAULT_PIE +#undef DEFAULT_FLAG_PIE +#define DEFAULT_FLAG_PIE 0 +#endif + if (!opts->x_flag_opts_finished) { + /* We initialize opts->x_flag_pie to -1 so that targets can set a + default value. */ + if (opts->x_flag_pie == -1) + { + if (opts->x_flag_pic == 0) + opts->x_flag_pie = DEFAULT_FLAG_PIE; + else + opts->x_flag_pie = 0; + } if (opts->x_flag_pie) opts->x_flag_pic = opts->x_flag_pie; if (opts->x_flag_pic && !opts->x_flag_pie) diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in index f693883..8d10386 100644 --- a/libgcc/Makefile.in +++ b/libgcc/Makefile.in @@ -284,7 +284,7 @@ INTERNAL_CFLAGS = $(CFLAGS) $(LIBGCC2_CFLAGS) $(HOST_LIBGCC2_CFLAGS) \ # Options to use when compiling crtbegin/end. CRTSTUFF_CFLAGS = -O2 $(GCC_CFLAGS) $(INCLUDES) $(MULTILIB_CFLAGS) -g0 \ - -finhibit-size-directive -fno-inline -fno-exceptions \ + $(NO_PIE_CFLAGS) -finhibit-size-directive -fno-inline -fno-exceptions \ -fno-zero-initialized-in-bss -fno-toplevel-reorder -fno-tree-vectorize \ -fbuilding-libgcc -fno-stack-protector $(FORCE_EXPLICIT_EH_REGISTRY) \ $(INHIBIT_LIBC_CFLAGS)