diff mbox

[Fortran] Extend (lib)coarray API/ABI documentation

Message ID CAMe9rOraZqE8O8KBTurbkA1oVpCVRiaVhHp2gUnpT9AYDrt46Q@mail.gmail.com
State New
Headers show

Commit Message

H.J. Lu March 21, 2015, 2:28 p.m. UTC 
On Sat, Mar 21, 2015 at 6:19 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> Dear Tobias,
>
> Revision r221550 break bootstrap on platforms with recent makeinfo (mine is 5.2):
> see https://gcc.gnu.org/ml/gcc-regression/2015-03/. The error is
>
> ../../work/gcc/fortran/gfortran.texi:3850: @code missing close brace
> ../../work/gcc/fortran/gfortran.texi:3851: misplaced }
> ../../work/gcc/fortran/Make-lang.in:185: recipe for target 'doc/gfortran.info' failed
>
> and is fixed with the following patch
>
> --- ../_clean/gcc/fortran/gfortran.texi 2015-03-21 10:40:46.000000000 +0100
> +++ gcc/fortran/gfortran.texi   2015-03-21 11:27:20.000000000 +0100
> @@ -3847,8 +3847,8 @@ an error message; may be NULL
>  @item @var{errmsg_len} @tab the buffer size of errmsg.
>  @end multitable
>
> -@item @emph{NOTE} A simple implementation could be a simple @code{__asm__
> -__volatile__ ("":::"memory)} to prevent code movements.
> +@item @emph{NOTE} A simple implementation could be a simple
> +@code{__asm__ __volatile__ ("":::"memory)} to prevent code movements.
>  @end table
>

I checked in this to restore gcc build.

Comments

Iain Sandoe March 21, 2015, 9:16 p.m. UTC | #1 
Dear Tobias,

On 21 Mar 2015, at 14:28, H.J. Lu wrote:

> On Sat, Mar 21, 2015 at 6:19 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:

a couple of minor nits that Dominique and I spotted while discussing this : 

> -@item @emph{NOTE} A simple implementation could be a simple @code{__asm__

maybe  
"A simple implementation could be "
... would read more smoothly?

> -__volatile__ ("":::"memory)} to prevent code movements.
> +@item @emph{NOTE} A simple implementation could be a simple
> +@code{__asm__ __volatile__ ("":::"memory)} to prevent code movements.
> @end table

also:
@code{__asm__ __volatile__ ("":::"memory)} <= seems to be missing a quotation mark.
i.e. __asm__ __volatile__ ("" ::: "memory")

I wonder if the latter was somehow confusing the newer edition of texinfo?
cheers,
Iain
diff mbox

Patch

Index: ChangeLog
===================================================================
--- ChangeLog (revision 221551)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@ 
+2015-03-21  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * gfortran.texi (_gfortran_caf_sync_memory): Put @{xxx} in one
+ line.
+
 2015-03-21  Tobias Burnus  <burnus@net-b.de>

  * gfortran.texi (_gfortran_caf_sync_all, _gfortran_caf_sync_images,
Index: gfortran.texi
===================================================================
--- gfortran.texi (revision 221551)
+++ gfortran.texi (working copy)
@@ -3847,8 +3847,8 @@ 
 @item @var{errmsg_len} @tab the buffer size of errmsg.
 @end multitable

-@item @emph{NOTE} A simple implementation could be a simple @code{__asm__
-__volatile__ ("":::"memory)} to prevent code movements.
+@item @emph{NOTE} A simple implementation could be a simple
+@code{__asm__ __volatile__ ("":::"memory)} to prevent code movements.
 @end table