From patchwork Wed Jul 20 13:18:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 105685 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E73D1B6F64 for ; Wed, 20 Jul 2011 23:19:28 +1000 (EST) Received: (qmail 13427 invoked by alias); 20 Jul 2011 13:19:23 -0000 Received: (qmail 13391 invoked by uid 22791); 20 Jul 2011 13:19:18 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, TW_VZ, TW_ZB, TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 13:18:29 +0000 Received: by qwh5 with SMTP id 5so115100qwh.20 for ; Wed, 20 Jul 2011 06:18:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.86.72 with SMTP id r8mr6915302qcl.84.1311167908052; Wed, 20 Jul 2011 06:18:28 -0700 (PDT) Received: by 10.229.98.193 with HTTP; Wed, 20 Jul 2011 06:18:27 -0700 (PDT) In-Reply-To: References: <20110719044537.GA3605@intel.com> <4E25BAF5.1000900@redhat.com> <4E25BE14.8010306@redhat.com> Date: Wed, 20 Jul 2011 06:18:27 -0700 Message-ID: Subject: Re: PATCH [7/n] X32: Handle address output and calls patterns From: "H.J. Lu" To: Uros Bizjak Cc: Richard Henderson , gcc-patches@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, Jul 20, 2011 at 1:19 AM, Uros Bizjak wrote: > On Wed, Jul 20, 2011 at 9:53 AM, Uros Bizjak wrote: > >>>>>> since Pmode is used in non-PIC tablejump, we have to put 64bit value for >>>>>> labels with 0 upper 32bits in tablejump for x32. >>>>> >>>>> The mode is completely controled by CASE_VECTOR_MODE. >>>>> >>>> >>>> Here is the updated patch.  OK for trunk? >>>> >>> >>> A small change.  It always use 64bit register for indirect branch. >> >> -         ix86_print_operand (file, x, 0); >> +         /* Always use 64bit register for indirect branch.  */ >> +         ix86_print_operand (file, x, >> +                             REG_P (x) && TARGET_64BIT ? 'q' : 0); >>          return; >> >> /* Always use 64bit register for indirect branch.  */ >> if (REG_P (x) && TARGET_64BIT) >>  print_reg (x, 'q', file); >> else >>  ix86_print_operand (file, x, 0); >> >>  (define_insn "*indirect_jump" >> -  [(set (pc) (match_operand:P 0 "nonimmediate_operand" "rm"))] >> +  [(set (pc) (match_operand:P 0 "x32_indirect_branch_operand" "rm"))] >> >> Just name it "indirect_branch_operand". >> >>  (define_insn_and_split "*call_vzeroupper" >> -  [(call (mem:QI (match_operand:P 0 "call_insn_operand" "zm")) >> +  [(call (mem:QI (match_operand:P 0 "x32_call_insn_operand" "zm")) >> >> Don't introduce new predicate, change call_insn_operand instead to >> conditionally disable memory_operand on x32. You will need to change >> "zm" register constraint to "z" on x32, otherwise you will get >> ICEs. > > Use new constraint here, something like (untested): > > Index: constraints.md > =================================================================== > --- constraints.md      (revision 176494) > +++ constraints.md      (working copy) > @@ -127,6 +127,11 @@ >   "@internal Constant call address operand." >   (match_operand 0 "constant_call_address_operand")) > > +(define_constraint "w" > +  "@internal Call memory operand." > +  (and (match_test "!TARGET_X32") > +       (match_operand 0 "memory_operand")) > + >  ;; Integer constant constraints. >  (define_constraint "I" >   "Integer constant in the range 0 @dots{} 31, for 32-bit shifts." > > Uros. > Here is the updated patch. OK for trunk? Thanks. diff --git a/gcc/config/i386/constraints.md b/gcc/config/i386/constraints.md index 099c2e1..0b53c76 100644 --- a/gcc/config/i386/constraints.md +++ b/gcc/config/i386/constraints.md @@ -19,7 +19,7 @@ ;;; Unused letters: ;;; B H T W -;;; h jk vw +;;; h jk v ;; Integer register constraints. ;; It is not necessary to define 'r' here. @@ -127,6 +127,11 @@ "@internal Constant call address operand." (match_operand 0 "constant_call_address_operand")) +(define_constraint "w" + "@internal Call memory operand." + (and (match_test "!TARGET_X32") + (match_operand 0 "memory_operand"))) + ;; Integer constant constraints. (define_constraint "I" "Integer constant in the range 0 @dots{} 31, for 32-bit shifts." diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 814250f..931b066 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -13430,7 +13482,11 @@ ix86_print_operand (FILE *file, rtx x, int code) gcc_unreachable (); } - ix86_print_operand (file, x, 0); + /* Always use 64bit register for indirect branch. */ + if (REG_P (x) && TARGET_64BIT) + print_reg (x, 'q', file); + else + ix86_print_operand (file, x, 0); return; @@ -14852,7 +14908,7 @@ ix86_output_addr_vec_elt (FILE *file, int value) const char *directive = ASM_LONG; #ifdef ASM_QUAD - if (TARGET_64BIT) + if (TARGET_LP64) directive = ASM_QUAD; #else gcc_assert (!TARGET_64BIT); diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h index 47c1388..20c9a8f 100644 --- a/gcc/config/i386/i386.h +++ b/gcc/config/i386/i386.h @@ -1674,7 +1674,7 @@ typedef struct ix86_args { /* Specify the machine mode that this machine uses for the index in the tablejump instruction. */ #define CASE_VECTOR_MODE \ - (!TARGET_64BIT || (flag_pic && ix86_cmodel != CM_LARGE_PIC) ? SImode : DImode) + (!TARGET_LP64 || (flag_pic && ix86_cmodel != CM_LARGE_PIC) ? SImode : DImode) /* Define this as 1 if `char' should by default be signed; else as 0. */ #define DEFAULT_SIGNED_CHAR 1 diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index cf0fdf4..708cfa5 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -10966,7 +10985,7 @@ [(set (pc) (match_operand 0 "nonimmediate_operand" ""))]) (define_insn "*indirect_jump" - [(set (pc) (match_operand:P 0 "nonimmediate_operand" "rm"))] + [(set (pc) (match_operand:P 0 "indirect_branch_operand" "rw"))] "" "jmp\t%A0" [(set_attr "type" "ibr") @@ -11011,12 +11030,20 @@ }) (define_insn "*tablejump_1" - [(set (pc) (match_operand:P 0 "nonimmediate_operand" "rm")) + [(set (pc) (match_operand:P 0 "indirect_branch_operand" "rw")) (use (label_ref (match_operand 1 "" "")))] "" "jmp\t%A0" [(set_attr "type" "ibr") (set_attr "length_immediate" "0")]) + +(define_insn "*tablejump_1_x32" + [(set (pc) (match_operand:SI 0 "register_operand" "r")) + (use (label_ref (match_operand 1 "" "")))] + "TARGET_X32" + "jmp\t%A0" + [(set_attr "type" "ibr") + (set_attr "length_immediate" "0")]) ;; Convert setcc + movzbl to xor + setcc if operands don't overlap. @@ -11099,7 +11126,7 @@ }) (define_insn_and_split "*call_vzeroupper" - [(call (mem:QI (match_operand:P 0 "call_insn_operand" "zm")) + [(call (mem:QI (match_operand:P 0 "call_insn_operand" "zw")) (match_operand 1 "" "")) (unspec [(match_operand 2 "const_int_operand" "")] UNSPEC_CALL_NEEDS_VZEROUPPER)] @@ -11111,7 +11138,7 @@ [(set_attr "type" "call")]) (define_insn "*call" - [(call (mem:QI (match_operand:P 0 "call_insn_operand" "zm")) + [(call (mem:QI (match_operand:P 0 "call_insn_operand" "zw")) (match_operand 1 "" ""))] "!SIBLING_CALL_P (insn)" "* return ix86_output_call_insn (insn, operands[0]);" @@ -11119,7 +11146,7 @@ (define_insn_and_split "*call_rex64_ms_sysv_vzeroupper" [(parallel - [(call (mem:QI (match_operand:DI 0 "call_insn_operand" "rzm")) + [(call (mem:QI (match_operand:DI 0 "call_insn_operand" "rzw")) (match_operand 1 "" "")) (unspec [(const_int 0)] UNSPEC_MS_TO_SYSV_CALL) (clobber (reg:TI XMM6_REG)) @@ -11144,7 +11171,7 @@ [(set_attr "type" "call")]) (define_insn "*call_rex64_ms_sysv" - [(call (mem:QI (match_operand:DI 0 "call_insn_operand" "rzm")) + [(call (mem:QI (match_operand:DI 0 "call_insn_operand" "rzw")) (match_operand 1 "" "")) (unspec [(const_int 0)] UNSPEC_MS_TO_SYSV_CALL) (clobber (reg:TI XMM6_REG)) @@ -11275,7 +11302,7 @@ (define_insn_and_split "*call_value_vzeroupper" [(set (match_operand 0 "" "") - (call (mem:QI (match_operand:P 1 "call_insn_operand" "zm")) + (call (mem:QI (match_operand:P 1 "call_insn_operand" "zw")) (match_operand 2 "" ""))) (unspec [(match_operand 3 "const_int_operand" "")] UNSPEC_CALL_NEEDS_VZEROUPPER)] @@ -11288,7 +11315,7 @@ (define_insn "*call_value" [(set (match_operand 0 "" "") - (call (mem:QI (match_operand:P 1 "call_insn_operand" "zm")) + (call (mem:QI (match_operand:P 1 "call_insn_operand" "zw")) (match_operand 2 "" "")))] "!SIBLING_CALL_P (insn)" "* return ix86_output_call_insn (insn, operands[1]);" @@ -11318,7 +11345,7 @@ (define_insn_and_split "*call_value_rex64_ms_sysv_vzeroupper" [(parallel [(set (match_operand 0 "" "") - (call (mem:QI (match_operand:DI 1 "call_insn_operand" "rzm")) + (call (mem:QI (match_operand:DI 1 "call_insn_operand" "rzw")) (match_operand 2 "" ""))) (unspec [(const_int 0)] UNSPEC_MS_TO_SYSV_CALL) (clobber (reg:TI XMM6_REG)) @@ -11344,7 +11371,7 @@ (define_insn "*call_value_rex64_ms_sysv" [(set (match_operand 0 "" "") - (call (mem:QI (match_operand:DI 1 "call_insn_operand" "rzm")) + (call (mem:QI (match_operand:DI 1 "call_insn_operand" "rzw")) (match_operand 2 "" ""))) (unspec [(const_int 0)] UNSPEC_MS_TO_SYSV_CALL) (clobber (reg:TI XMM6_REG)) @@ -11666,7 +11693,7 @@ (unspec:DI [(label_ref (match_operand 1 "" ""))] UNSPEC_SET_GOT_OFFSET))] - "TARGET_64BIT" + "TARGET_LP64" "movabs{q}\t{$_GLOBAL_OFFSET_TABLE_-%l1, %0|%0, OFFSET FLAT:_GLOBAL_OFFSET_TABLE_-%l1}" [(set_attr "type" "imov") (set_attr "length_immediate" "0") diff --git a/gcc/config/i386/predicates.md b/gcc/config/i386/predicates.md index 2c75147..8b87753 100644 --- a/gcc/config/i386/predicates.md +++ b/gcc/config/i386/predicates.md @@ -563,11 +569,18 @@ (ior (match_operand 0 "register_no_elim_operand") (match_operand 0 "immediate_operand"))) +;; Test for a valid operand for indirect branch. +(define_predicate "indirect_branch_operand" + (if_then_else (match_test "TARGET_X32") + (match_operand 0 "register_operand") + (match_operand 0 "nonimmediate_operand"))) + ;; Test for a valid operand for a call instruction. (define_predicate "call_insn_operand" (ior (match_operand 0 "constant_call_address_operand") (match_operand 0 "call_register_no_elim_operand") - (match_operand 0 "memory_operand"))) + (and (match_test "!TARGET_X32") + (match_operand 0 "memory_operand")))) ;; Similarly, but for tail calls, in which we cannot allow memory references. (define_predicate "sibcall_insn_operand"