From patchwork Fri Sep 26 15:28:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 393854 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C346514008C for ; Sat, 27 Sep 2014 01:28:15 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=OXklt8JAyKvvteilJM bxC5cBFiL1UJYq7NjNBostR3baAuwTr57OTT9ON/99aG6RHzX0uvV8Y55SbRY0gl Dz8dhFo34kqVTnh5cimsyGon0J8g5S3QK/WOu3j/b3L1IU5TNZg2Cm9enpqg82lG pUwO1nhjAuXE4i7TamXBZ8t98= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=V7vQYfLts8ATU+eeB0AB8e2N n+I=; b=ljVWTJlB5VxPCpFWlFJT3EbD4PwiuJxQKOKO1gb6qgJoc883micHXurO DYXu3XZo5Jq8ugEFXh23ulARieiNUxXCSmtcU2dNUDqd4AFENJvYA3gcCIl2rKFu HH2AxmoyQNC0DDWBPGjaIYI1kn/CHdTQygTlwYcTGrp1f01ZauY= Received: (qmail 17571 invoked by alias); 26 Sep 2014 15:28:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17556 invoked by uid 89); 26 Sep 2014 15:28:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f180.google.com Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 26 Sep 2014 15:28:06 +0000 Received: by mail-ob0-f180.google.com with SMTP id wn1so9579421obc.25 for ; Fri, 26 Sep 2014 08:28:02 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.119.98 with SMTP id kt2mr22252863oeb.13.1411745281925; Fri, 26 Sep 2014 08:28:01 -0700 (PDT) Received: by 10.76.72.4 with HTTP; Fri, 26 Sep 2014 08:28:01 -0700 (PDT) In-Reply-To: <542582D9.3040206@arm.com> References: <54170583.4040002@arm.com> <000001cfd17b$25ec75f0$71c561d0$@arm.com> <541BC46F.8050401@redhat.com> <541C131B.7080805@arm.com> <541C50A0.9050807@redhat.com> <541C53B2.1020007@arm.com> <541C578E.9080606@redhat.com> <541FF8D2.2070807@arm.com> <54206191.5050703@redhat.com> <542309BF.9010507@arm.com> <000001cfd89e$112e67c0$338b3740$@arm.com> <54242F1B.7060909@arm.com> <542441A7.1060504@redhat.com> <54244634.9050702@arm.com> <542582D9.3040206@arm.com> Date: Fri, 26 Sep 2014 08:28:01 -0700 Message-ID: Subject: Re: [COMMITTED][PATCH, 2/2] shrink wrap a function with a single loop: split live_edge From: "H.J. Lu" To: Jiong Wang Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes On Fri, Sep 26, 2014 at 8:14 AM, Jiong Wang wrote: > > On 26/09/14 16:05, H.J. Lu wrote: >> >> On Thu, Sep 25, 2014 at 9:43 AM, Jiong Wang wrote: >>> >>> On 25/09/14 17:24, Jeff Law wrote: >>>> >>>> On 09/25/14 09:04, Jiong Wang wrote: >>>>> >>>>> new patch updated. >>>>> >>>>> pass bootstrap and no regression, both check-gcc and check-g++, on the >>>>> x86. >>>>> >>>>> OK for trunk? >>>>> >>>>> thanks. >>>>> >>>>> gcc/ >>>>> * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the >>>>> live-in >>>>> of >>>>> new created BB as the intersection of live-in from "old_dest" and >>>>> live-out >>>>> from "bb". >>>> >>>> Please include a ChangeLog entry for the testsuite. Something like: >>>> >>>> * gcc.target/i386/shrink_wrap_1.c: New test. >> >> This fails on Linux/x86 and with -m32 on Linux/x86-64. > > sorry, my test machine is x86-64, I think the shrink wrap test itself is > very fragile because > it's highly related insn generated. > > could you mark that testcase using something like > "dg-require-effective-target lp64"? I checked in this patch to skip it on ia32. Index: ChangeLog =================================================================== --- ChangeLog (revision 215644) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-09-26 H.J. Lu + + * gcc.target/i386/shrink_wrap_1.c: Skip ia32. + 2014-09-26 Jakub Jelinek * g++.dg/compat/struct-layout-1_generate.c: Add -Wno-abi Index: gcc.target/i386/shrink_wrap_1.c =================================================================== --- gcc.target/i386/shrink_wrap_1.c (revision 215644) +++ gcc.target/i386/shrink_wrap_1.c (working copy) @@ -1,4 +1,4 @@ -/* { dg-do compile } */ +/* { dg-do compile { target { ! ia32 } } } */ /* { dg-options "-O2 -fdump-rtl-pro_and_epilogue" } */ enum machine_mode