diff mbox

XFAIL a couple of gnat.dg testcases on MIPS

Message ID CAMe9rOq0=pt4WDm9tuqtJp9OOekCOSXp7oJ-WkyZGzN6RduzNA@mail.gmail.com
State New
Headers show

Commit Message

H.J. Lu Nov. 13, 2013, 9:12 p.m. UTC 
On Wed, Nov 13, 2013 at 12:27 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Oct 21, 2012 at 1:26 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> They are reported as failing with the n32 ABI, but the failures are spurious.
>>
>> Tested on mips64el-linux-gnu, applied on the mainline and 4.7 branch.
>>
>>
>> 2012-10-21  Eric Botcazou  <ebotcazou@adacore.com>
>>
>>         * gnat.dg/specs/atomic1.ads: XFAIL on MIPS.
>>         * gnat.dg/specs/addr1.ads: Likewise.
>>
>
> They are also failing on x32, which similar to n32:
>
> FAIL: gnat.dg/specs/addr1.ads  (test for bogus messages, line 24)
> FAIL: gnat.dg/specs/atomic1.ads  (test for errors, line 9)
> FAIL: gnat.dg/specs/atomic1.ads  (test for errors, line 13)
>

Here is a patch.  OK to install?

Thanks.

Comments

Eric Botcazou Nov. 14, 2013, 11:51 a.m. UTC | #1 
> Here is a patch.  OK to install?

Yes, thanks.
H.J. Lu Nov. 14, 2013, 10:40 p.m. UTC | #2 
On Thu, Nov 14, 2013 at 3:51 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Here is a patch.  OK to install?
>
> Yes, thanks.
>
> --
> Eric Botcazou

It doesn't work:

ERROR: gnat.dg/specs/addr1.ads: syntax error in target selector "xfail
mips*-*-* { { i?86-*-* x86_64-*-* } && x32 }" for " dg-bogus 24
"(alignment|erroneous)" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* }
&& x32 } } "

I couldn't find a way to make it to xfail for mips or x32.
I reverted it.
diff mbox

Patch

2013-11-13  H.J. Lu  <hongjiu.lu@intel.com>

	* gnat.dg/specs/addr1.ads: XFAIL on x32.
	* gnat.dg/specs/atomic1.ads: Likewise.

diff --git a/gcc/testsuite/gnat.dg/specs/addr1.ads b/gcc/testsuite/gnat.dg/specs/addr1.ads
index bcb833b..b357115 100644
--- a/gcc/testsuite/gnat.dg/specs/addr1.ads
+++ b/gcc/testsuite/gnat.dg/specs/addr1.ads
@@ -21,7 +21,7 @@  package Addr1 is
   for Obj1'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" }
 
   Obj2: Rec2;
-  for Obj2'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" "" { xfail mips*-*-* } }
+  for Obj2'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
 
   Obj3: Rec1;
   for Obj3'Address use A(1)'Address; -- { dg-bogus "(alignment|erroneous)" }
diff --git a/gcc/testsuite/gnat.dg/specs/atomic1.ads b/gcc/testsuite/gnat.dg/specs/atomic1.ads
index 02e98b6..2994f2a 100644
--- a/gcc/testsuite/gnat.dg/specs/atomic1.ads
+++ b/gcc/testsuite/gnat.dg/specs/atomic1.ads
@@ -6,11 +6,11 @@  package Atomic1 is
   type UA is access all Arr;
 
   U : UA;
-  pragma Atomic (U);  -- { dg-error "atomic access" "" { xfail mips*-*-* } }
+  pragma Atomic (U);  -- { dg-error "atomic access" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
 
   type R is record
     U : UA;
-    pragma Atomic (U);  -- { dg-error "atomic access" "" { xfail mips*-*-* } }
+    pragma Atomic (U);  -- { dg-error "atomic access" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
   end record;
 
 end Atomic1;
-- 
1.8.3.1