From patchwork Tue Sep 16 18:00:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 390130 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7B85014010B for ; Wed, 17 Sep 2014 04:00:25 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=iLFRV+dhsmr9S12Pn5 03Wtu0k2VsS7+sUGSZbK+ZPIiC37I83QaUsaMSjZFbxYbxq1AFjM/NfR7zihzj// eJ/5iNvW85sIaR1lNx28R08L2mfq5nmzAzejNvhOkI7SSQ7CgojIF8qXbUL9RKyz Hxqc9hv2rulmT3MGp57SbkZX0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=69LUQW6JRVPTbyvTnAg1OAd8 aks=; b=RaiI8ZvMyu3dffSCWqaBRncdlGNwi4/nrv3PdNWKy46uagDuuzte5DtL DDzeG7KyoCPeIWUXnpcWI1lv3eGAiDW5AqFpRVMn/h2l52nlG6lR33D+njokZqCP krmsXXufV8VgqkBMYvlRiIyaw0vmjszLhFvNK7/cSJhq4wWjRvg= Received: (qmail 27321 invoked by alias); 16 Sep 2014 18:00:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27289 invoked by uid 89); 16 Sep 2014 18:00:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 16 Sep 2014 18:00:14 +0000 Received: by mail-ob0-f177.google.com with SMTP id wp4so173867obc.22 for ; Tue, 16 Sep 2014 11:00:12 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.44.135 with SMTP id e7mr37471970obm.18.1410890412780; Tue, 16 Sep 2014 11:00:12 -0700 (PDT) Received: by 10.76.72.4 with HTTP; Tue, 16 Sep 2014 11:00:12 -0700 (PDT) In-Reply-To: References: <1410532377-13147-1-git-send-email-andi@firstfloor.org> <1410532377-13147-2-git-send-email-andi@firstfloor.org> <20140915155958.GS5387@tassilo.jf.intel.com> Date: Tue, 16 Sep 2014 11:00:12 -0700 Message-ID: Subject: Re: [PATCH 2/2] Add some more test cases for fentry and pg From: "H.J. Lu" To: Andi Kleen Cc: Richard Biener , Andi Kleen , GCC Patches X-IsSubscribed: yes On Tue, Sep 16, 2014 at 8:36 AM, H.J. Lu wrote: > On Mon, Sep 15, 2014 at 8:59 AM, Andi Kleen wrote: >> On Mon, Sep 15, 2014 at 11:29:50AM +0200, Richard Biener wrote: >>> On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen wrote: >>> > From: Andi Kleen >>> > >>> > Test fentry and no_instrument_function overriding. >>> > >>> > No test cases for the LTO test for now, as the LTO >>> > harness doesn't seem to support different flags for the final >>> > link. >>> >>> Sure it does - via dg-extra-ld-options (you have to negate compile-time >>> opts to "remove" them). >> >> Ok. I'll add test cases for that too then. >> >>> >>> Are you sure the tests are target independent enough? That is, >>> 'mcount' is really 'mcount' on all targets? >> >> I'm not. I'll make them x86 only. >> >> Thanks, >> >> -Andi > > Tested on Linux/x86-64. I checked in this to fix: > > https://gcc.gnu.org/ml/gcc-regression/2014-09/msg00084.html > > -- > H.J. > --- > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 215300) > +++ ChangeLog (working copy) > @@ -1,3 +1,7 @@ > +2014-09-16 H.J. Lu > + > + * gcc.dg/pg.c: Fix a typo. > + > 2014-09-16 Richard Biener > > PR testsuite/63258 > Index: gcc.dg/pg.c > =================================================================== > --- gcc.dg/pg.c (revision 215300) > +++ gcc.dg/pg.c (working copy) > @@ -1,6 +1,6 @@ > /* Test -fprofile override */ > /* { dg-do compile } */ > -/* { dg-options "-fprofile" { target { { i686-*-* x86_64-*-* } } } } */ > +/* { dg-options "-fprofile" { target i?86-*-* x86_64-*-* } } */ > /* { dg-final { scan-assembler-not "mcount" } } */ > /* Origin: Andi Kleen */ > extern void foobar(const char *); Here is another one: Index: ChangeLog =================================================================== --- ChangeLog (revision 215303) +++ ChangeLog (working copy) @@ -1,5 +1,9 @@ 2014-09-16 H.J. Lu + * gcc.dg/pg-override.c: Fix a typo. + +2014-09-16 H.J. Lu + * gcc.dg/pg.c: Fix a typo. 2014-09-16 Richard Biener Index: gcc.dg/pg-override.c =================================================================== --- gcc.dg/pg-override.c (revision 215303) +++ gcc.dg/pg-override.c (working copy) @@ -1,6 +1,6 @@ /* Test -fprofile override */ /* { dg-do compile } */ -/* { dg-options "-fprofile" { target { { i686-*-* x86_64-*-* } } } } */ +/* { dg-options "-fprofile" { target i?86-*-* x86_64-*-* } } */ /* { dg-final { scan-assembler-not "mcount" } } */ /* Origin: Andi Kleen */ extern void foobar(const char *);