From patchwork Tue Feb 11 17:46:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 319372 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 766742C00B0 for ; Wed, 12 Feb 2014 04:46:49 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=vi5diKiC7JKG9CJj4s 5vU/VQOSK6d00d1aWDz+oSz6CjBw/WafLkcQwiI182GZrKE287hSwZlHMpKCqqQn 4flvQObGldgj27gdnG2+nk7KdIRzDBXZNh8p8RqzCTxwbgaOPEIQu1ZJTPF+nHqr PPTbQexb6LoJMt/Td6vdRLDGs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=cELmVX6NDt6Mwcs5oJsC3zgC 6J0=; b=n1zptK6KM9ThzO6sRdiV5jyNnlVJyU8VYx/FC1mhFpjsb66Q20Eow93R KBGZRr+ewSA2x3UDmwN7Q2shbHGdy2Y2M882FBRMnUCuarp5sNnVE0boRv0YjRIn C055QlgJ/Jpv6CbSQK7rHb9N/BJY1D+6pgfjH5+ndzL++zwO+LA= Received: (qmail 1996 invoked by alias); 11 Feb 2014 17:46:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1987 invoked by uid 89); 11 Feb 2014 17:46:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f180.google.com Received: from mail-ob0-f180.google.com (HELO mail-ob0-f180.google.com) (209.85.214.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 11 Feb 2014 17:46:41 +0000 Received: by mail-ob0-f180.google.com with SMTP id wp4so9125474obc.39 for ; Tue, 11 Feb 2014 09:46:39 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.196.3 with SMTP id ii3mr32664319obc.11.1392140799407; Tue, 11 Feb 2014 09:46:39 -0800 (PST) Received: by 10.76.3.114 with HTTP; Tue, 11 Feb 2014 09:46:39 -0800 (PST) In-Reply-To: <52F8DBE7.20101@arm.com> References: <52EFBC49.7050200@arm.com> <52F8DBE7.20101@arm.com> Date: Tue, 11 Feb 2014 09:46:39 -0800 Message-ID: Subject: Re: [PING]Re: [PATCH][ARM]fix potential testsuite/gcc.target/arm/fixed_float_conversion.c regression From: "H.J. Lu" To: Renlin Li Cc: "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Ramana Radhakrishnan X-IsSubscribed: yes On Mon, Feb 10, 2014 at 6:02 AM, Renlin Li wrote: > On 03/02/14 15:56, Renlin Li wrote: >> >> Hi all, >> >> This patch will ensure testsuite/gcc.target/arm/fixed_float_conversion.c >> is checked only when "-mfpu=vfp3 -mfloat-abi=softfp" is applicable for the >> target. >> >> Accordingly, two procs (check_effective_target_arm_vfp3_ok and >> add_options_for_arm_vfp3) are added into >> gcc/testsuite/lib/target-supports.exp. >> >> I have also update related documentation. >> >> Okay for trunk? >> >> Kind regards, >> Renlin Li >> >> >> gcc/testsuite/ChangeLog: >> >> 2014-02-03 Renlin Li >> >> * gcc.target/arm/fixed_float_conversion.c: Add arm_vfp3 option to the >> test case. >> * lib/target-supports.exp: check_effective_target_arm_vfp3_ok: New. >> add_options_for_arm_vfp3: New. >> >> >> gcc/ChangeLog: >> >> 2014-02-03 Renlin Li >> >> * doc/sourcebuild.texi: Document check_effective_target_arm_vfp3_ok >> and >> add_options_for_arm_vfp3 > > > Hi, > > Anybody help me to review this patch? > This breaks bootstrap: ../../src-trunk/gcc/doc/sourcebuild.texi:1963: @ref reference to nonexistent node `arm_vfp3_ok' I am checking in this as an obvious fix. diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi index 1ea5753..85ef819 100644 --- a/gcc/doc/sourcebuild.texi +++ b/gcc/doc/sourcebuild.texi @@ -1552,6 +1552,7 @@ ARM target supports @code{-mfpu=vfp -mfloat-abi=softfp}. Some multilibs may be incompatible with these options. @item arm_vfp3_ok +@anchor{arm_vfp3_ok} ARM target supports @code{-mfpu=vfp3 -mfloat-abi=softfp}. Some multilibs may be incompatible with these options.