From patchwork Sat Nov 24 01:13:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 201434 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D94732C0040 for ; Sat, 24 Nov 2012 12:14:02 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354324443; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=Fm1QbRZaIUz4ofcLb2MAazSvdrg=; b=vIWYcACYtkcIlQwks38UUVO0ePtivtLyhRbF1bgRpXWHiHqTbNfKtA+nixqWrA AGXKkSDNKy5meWCDSZClUK9+JFfHLItBpJcq6bqTa2dApxP48mg0HOGcp93M8TcF NM6j8QjG76xHJXbSv2vYckDObJcUNZkPF0bzhltqH1X6A= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Mocl1BFsH1dw0Hf3ZTcP8Xz1hPzEYJHROq47g1rES3CJVasUZu2yGOlKuek53e 1/hqK1o+ULrKrknVlTQe4yW+3sqlaBIV8QuZpFu7Cp3DXxDUt61lD2QlaCepi4A5 QNt7wgXLKDFDpwRE2T7llm1gwOHcGd+WmOI3W6ijY8yPo=; Received: (qmail 22785 invoked by alias); 24 Nov 2012 01:13:58 -0000 Received: (qmail 22777 invoked by uid 22791); 24 Nov 2012 01:13:57 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, TW_IB X-Spam-Check-By: sourceware.org Received: from mail-qc0-f175.google.com (HELO mail-qc0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Nov 2012 01:13:54 +0000 Received: by mail-qc0-f175.google.com with SMTP id j3so7041697qcs.20 for ; Fri, 23 Nov 2012 17:13:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.49.73.232 with SMTP id o8mr6355635qev.0.1353719633601; Fri, 23 Nov 2012 17:13:53 -0800 (PST) Received: by 10.49.12.210 with HTTP; Fri, 23 Nov 2012 17:13:53 -0800 (PST) In-Reply-To: References: <50AFF4B7.3030601@net-b.de> Date: Fri, 23 Nov 2012 17:13:53 -0800 Message-ID: Subject: Re: [Patch, libquadmath, committed] Updated the I/O related part of libquadmath From: "H.J. Lu" To: Tobias Burnus Cc: gcc patches X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Fri, Nov 23, 2012 at 4:59 PM, H.J. Lu wrote: > On Fri, Nov 23, 2012 at 3:38 PM, H.J. Lu wrote: >> On Fri, Nov 23, 2012 at 3:21 PM, H.J. Lu wrote: >>> On Fri, Nov 23, 2012 at 2:12 PM, Tobias Burnus wrote: >>>> As suggested by Joseph, it uses fegetround instead of trying to get the >>>> information elsewhere (which glibc does to avoid mixing libm with libc). >>>> >>>> Build and tested on x86-64-gnu-linux. Committed as Rev. 193770. >>>> >>>> Tobias >>> >>> This caused: >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55455 >> >> I checked in the missing libquadmath/quadmath-rounding-mode.h. >> Hopefully, it will fix the problem. > > No, it doesn't. I got > > In file included from ../../../src-trunk/libquadmath/printf/printf_fphex.c:28:0: > ../../../src-trunk/libquadmath/quadmath-rounding-mode.h: In function > 'get_rounding_mode': > ../../../src-trunk/libquadmath/quadmath-rounding-mode.h:36:22: error: > expected expression before 'void' > return fegetround (void); > ^ > ../../../src-trunk/libquadmath/quadmath-rounding-mode.h:36:22: error: > too many arguments to function 'fegetround' > In file included from > ../../../src-trunk/libquadmath/quadmath-rounding-mode.h:28:0, > from ../../../src-trunk/libquadmath/printf/printf_fphex.c:28: > /usr/include/fenv.h:86:12: note: declared here > extern int fegetround (void) __THROW; > ^ I checked in this patch to fix it. Index: ChangeLog =================================================================== --- ChangeLog (revision 193774) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2012-11-23 H.J. Lu + + PR bootstrap/55455 + * quadmath-rounding-mode.h (get_rounding_mode): Don't pass + void to fegetround. + 2012-11-23 Tobias Burnus Joseph Myers Index: quadmath-rounding-mode.h =================================================================== --- quadmath-rounding-mode.h (revision 193774) +++ quadmath-rounding-mode.h (working copy) @@ -33,7 +33,7 @@ { #if defined(HAVE_FENV_H) && (defined(FE_DOWNWARD) || defined(FE_TONEAREST) \ || defined(FE_TOWARDZERO) || defined(FE_UPWARD)) - return fegetround (void); + return fegetround (); #else return 0; #endif