From patchwork Mon Oct 1 23:31:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sharad Singhai X-Patchwork-Id: 188365 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6C38B2C00E0 for ; Tue, 2 Oct 2012 09:32:36 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349739157; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:From:Date:Message-ID:Subject:To:Cc: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=OMqki8z VQ3RtE9AEIvv9XirAM8w=; b=Bx62SYVHCqFUwLwfJzEGF69CrPBUD1AYxVJo1rf CdOvrwcGV+7fcBkQ8qCyTFhLvlQL5PWvWjzUJpEQ5TdP+ZNzyUDE531FdMJf+gju 5GmJ+uv9pJCK060+pB4MpThVZZjcI5/slYhJBsk+RnOmjUGjgmihxS9R7zy2iW24 HqrI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:MIME-Version:Received:From:Date:Message-ID:Subject:To:Cc:Content-Type:X-System-Of-Record:X-Gm-Message-State:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=iybLeVzHgl9fTKy249KVok5/Ti2Vm4e+81vzvU4Z+A/Obr1lw01jvq0AQKpf5d qWxXCY87mlxcUsHK/k7/7yCyTadsjR79YkAB0UwzrTfjf/W3uaDqxOvktoRGbhyy 99i2/ELdGoFuIA+MVF9/oKZD6bvI8U5qsxlWIMkFLkdHc=; Received: (qmail 15105 invoked by alias); 1 Oct 2012 23:32:33 -0000 Received: (qmail 15096 invoked by uid 22791); 1 Oct 2012 23:32:32 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, TW_TM X-Spam-Check-By: sourceware.org Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 23:32:26 +0000 Received: by vcqp1 with SMTP id p1so7344706vcq.20 for ; Mon, 01 Oct 2012 16:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc:content-type :x-system-of-record:x-gm-message-state; bh=2Tfa8qbmgYfl1bENAJqjlcFd9UQWI1V3Jk8g+XL7P7g=; b=iAchuyP9vxPm8Xz6OF+N7BAnKqwDW0zwnFi0b6uqKyT1PnFKGHk95mbPYE+1BKLSCK /lK/MzYuFIWQ6qTFrKLnQoAih3cXFpXQJL4uz/DeVSv3UzeIrW/2V+89Zt/bFajXChG6 pG6YUsYIXlJuAEJrcsWR9gsQ6KNlZodXtT+yPcNj5hWBVxEgGbeoIwXDAG+7rDx+WvnE cGspUJVnNVbTxBLiMxqupmj+2yL8my80YpryIGRb/OLNR4M7AYl8DDtdT8sQVmtZck/Y zA0/VluVzozmNR6OiJNkLc6xbHmj6hKIsuO26oP3gw0qGWrNaVM/WOG7zgeouC8IxquB hFTg== Received: by 10.52.70.15 with SMTP id i15mr7524946vdu.100.1349134344987; Mon, 01 Oct 2012 16:32:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.62.71 with HTTP; Mon, 1 Oct 2012 16:31:44 -0700 (PDT) From: Sharad Singhai Date: Mon, 1 Oct 2012 16:31:44 -0700 Message-ID: Subject: Re: [PATCH] Fix test breakage, was: Add option for dumping to stderr (issue6190057) To: Xinliang David Li Cc: Michael Meissner , David Edelsohn , Richard Guenther , "H.J. Lu" , Gabriel Dos Reis , "gcc-patches@gcc.gnu.org" , Andrew Pinski X-System-Of-Record: true X-Gm-Message-State: ALoCoQmcUblrFxt4upYdf5+9lsAMoApETjXjnw7H52r05BhTDvdLCySTqCrZ6tItoJ5gKnM6kv9JIZTwgAoBHhoLwACD0O4RCqdwRED5WEdiIAvX0TKY4W5JJdvds/wBI1Fama4FU7JUlQ9QxrTFpCcimfs0/o3eZKmP/DJN5SdlQk9ItRx21n9iM1TGPa3Onn2teXI/aSoz Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Here is a patch to fix test breakage caused by r191883. Bootstrapped on x86_64 and tested with make -k check RUNTESTFLAGS="--target_board=unix/\{,-m32\}". Okay for trunk? Thanks, Sharad 2012-10-01 Sharad Singhai * tree-vect-stmts.c (vectorizable_operation): Add missing return. testsuite/Changelog * gfortran.dg/vect/vect.exp: Change verbose vectorizor dump options to fix test failures caused by r191883. * gcc.dg/tree-ssa/gen-vect-11.c: Likewise. * gcc.dg/tree-ssa/gen-vect-2.c: Likewise. * gcc.dg/tree-ssa/gen-vect-32.c: Likewise. * gcc.dg/tree-ssa/gen-vect-25.c: Likewise. * gcc.dg/tree-ssa/gen-vect-11a.c: Likewise. * gcc.dg/tree-ssa/gen-vect-26.c: Likewise. * gcc.dg/tree-ssa/gen-vect-11b.c: Likewise. * gcc.dg/tree-ssa/gen-vect-11c.c: Likewise. * gcc.dg/tree-ssa/gen-vect-28.c: Likewise. * testsuite/gcc.target/i386/vect-double-1.c: Fix test. Missing entry from r191883. Index: testsuite/gfortran.dg/vect/vect.exp =================================================================== --- testsuite/gfortran.dg/vect/vect.exp (revision 191883) +++ testsuite/gfortran.dg/vect/vect.exp (working copy) @@ -26,7 +26,7 @@ set DEFAULT_VECTCFLAGS "" # These flags are used for all targets. lappend DEFAULT_VECTCFLAGS "-O2" "-ftree-vectorize" "-fno-vect-cost-model" \ - "-ftree-vectorizer-verbose=4" "-fdump-tree-vect-stats" + "-fdump-tree-vect-details" # If the target system supports vector instructions, the default action # for a test is 'run', otherwise it's 'compile'. Save current default. Index: testsuite/gcc.dg/tree-ssa/gen-vect-11.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-11.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-11.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fwrapv -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fwrapv -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fwrapv -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fwrapv -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-2.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-2.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-2.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-32.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-32.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-32.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-25.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-25.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-25.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-11a.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-11a.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-11a.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-26.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-26.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-26.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-11b.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-11b.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-11b.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-11c.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-11c.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-11c.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: testsuite/gcc.dg/tree-ssa/gen-vect-28.c =================================================================== --- testsuite/gcc.dg/tree-ssa/gen-vect-28.c (revision 191883) +++ testsuite/gcc.dg/tree-ssa/gen-vect-28.c (working copy) @@ -1,6 +1,6 @@ /* { dg-do run { target vect_cmdline_needed } } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats" } */ -/* { dg-options "-O2 -ftree-vectorize -ftree-vectorizer-verbose=4 -fdump-tree-vect-stats -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -mno-sse" { target { i?86-*-* x86_64-*-* } } } */ #include Index: tree-vect-stmts.c =================================================================== --- tree-vect-stmts.c (revision 191883) +++ tree-vect-stmts.c (working copy) @@ -3657,6 +3657,7 @@ vectorizable_operation (gimple stmt, gimple_stmt_i if (dump_kind_p (MSG_MISSED_OPTIMIZATION)) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, "not worthwhile without SIMD support."); + return false; } if (!vec_stmt) /* transformation not required. */