From patchwork Wed Nov 9 10:24:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janus Weil X-Patchwork-Id: 692683 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tDMkR1vrDz9vDV for ; Wed, 9 Nov 2016 21:25:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="yuoVSTpS"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=F4ICPzMcigd6/lp 6GaxsGxOUchyT2FjAmpC9vyYMT76l5iUue8xa18B8BzeBl7KYyAUL0jJCiYUSfgu wH38r568/MaALchVH1+43zWFvMEEyf5qIO4TP3mwDgM85oLRv3HuBP3apt3RqsNL 4tmFzMHqN23meDG+/Lxky83AXOvE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=BuDY/22squVJogkuUgLIy ngWtkg=; b=yuoVSTpS8jmV2CgOJoNgoWyqYa8CEpUogmdYLghVO89tytWV0q4UG l/Xx8la3j6PPLW7Wh9FYboHhsDLN0RW7W3zBN4YuVX1I9hpZY+EY7k7t2Beh99Ly yhZZy/g4aNUFLBee6bj8LqKp6WoeK/n0oDJ3/0FVKyYCXXdykYHedo= Received: (qmail 73646 invoked by alias); 9 Nov 2016 10:24:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 73621 invoked by uid 89); 9 Nov 2016 10:24:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=no version=3.3.2 spammy=ts.type, tstype, UD:ts.type, UD:u.derived X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f196.google.com Received: from mail-yw0-f196.google.com (HELO mail-yw0-f196.google.com) (209.85.161.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 10:24:43 +0000 Received: by mail-yw0-f196.google.com with SMTP id b66so5164803ywh.2; Wed, 09 Nov 2016 02:24:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=F6liDVm0nbezsNa+231OHg3V1xYVVWCj/N1rBaVBbBk=; b=KtlKGsN9lRcLz40NUqef9/vT2JwJPualdR3P65c36WkVfa1mOS0cBKlXBbhw3fm+Vr AL982iV/2q2RHcuUDJbQ5z+k/i1gwUMQQLpfUdMN4CXaBUxzPvl2HtCU50kJQihkSypm 6fgNVdOHrV44WwBH7yevVsdXZGhrXsSqVc398pJlk8YHT2PhtuCr9bSXM2RoYF3fk2nQ ZZOMeRKmaVQ9xT8RUiUocegkLcJ+tQ2k58JxXEyEKWRgbQnoOHYnJd1BussdRkJD5A28 8Y9Iigsq7EaQXIX5CCbbd9gyCn440oGfhMcsvvYPFcI8FHntr7Ot5Gs4RwwMlX/LuXHQ lVtw== X-Gm-Message-State: ABUngvf+blZuB5r9hSETwUt2ETHyF72TVy63beBBvfrWd1tjidJTlvd5+XTgClci5IXIAxwgfk4zA3dFowKXcQ== X-Received: by 10.129.167.3 with SMTP id e3mr17540029ywh.60.1478687081546; Wed, 09 Nov 2016 02:24:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.52.2 with HTTP; Wed, 9 Nov 2016 02:24:41 -0800 (PST) In-Reply-To: <20161109105424.17a9d83a@vepi2> References: <20161109105424.17a9d83a@vepi2> From: Janus Weil Date: Wed, 9 Nov 2016 11:24:41 +0100 Message-ID: Subject: Re: [Patch, Fortran, committed] PR 71894: [OOP] ICE in gfc_add_component_ref, at fortran/class.c:227 To: Andre Vehreschild Cc: gfortran , gcc-patches Hi Andre, sorry, didn't want to be impolite. I was just not aware that it makes a big difference whether I attach the patch or post the link. Patch below. Cheers, Janus 2016-11-09 10:54 GMT+01:00 Andre Vehreschild : > Hi Janus, > > may I ask you to attach also the "obvious" patches to the mail you send to the > list? It is far more comfortable to take a look at the patch in the mail than > open the webpage. Furthermore is it considered polite to attach the patches > even when they are obvious. This is not to treat you badly, but to ensure a > certain quality of gfortran. When a diff is attached I look at it, but I will > not open the link, not when I am only on a mobile. > > Thank you in advance, > Andre > > On Wed, 9 Nov 2016 10:35:10 +0100 > Janus Weil wrote: > >> Hi all, >> >> I have committed to trunk another obvious patch to fix an ICE on invalid code: >> >> https://gcc.gnu.org/viewcvs?rev=241993&root=gcc&view=rev >> >> Cheers, >> Janus > > > -- > Andre Vehreschild * Email: vehre ad gmx dot de Index: gcc/fortran/class.c =================================================================== --- gcc/fortran/class.c (Revision 241992) +++ gcc/fortran/class.c (Arbeitskopie) @@ -224,7 +224,8 @@ gfc_add_component_ref (gfc_expr *e, const char *na break; tail = &((*tail)->next); } - if (derived->components->next->ts.type == BT_DERIVED && + if (derived->components && derived->components->next && + derived->components->next->ts.type == BT_DERIVED && derived->components->next->ts.u.derived == NULL) { /* Fix up missing vtype. */