diff mbox

Recent Go patch broke Alpha bootstrap

Message ID CAKOQZ8weoXVfboA76Owh+QX0LUawCUcW9xSULhgFpFvECJrkeg@mail.gmail.com
State New
Headers show

Commit Message

Ian Lance Taylor Nov. 11, 2013, 7:41 p.m. UTC 
On Fri, Nov 8, 2013 at 1:10 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Fri, Nov 8, 2013 at 12:39 AM, Ian Lance Taylor <iant@google.com> wrote:
>
>>> Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed:
>>>
>> Thanks for the patch and report.  This patch should fix them.
>> Bootstrapped and tested on x86_64-unknown-linux-gnu, not that that
>> proves much.  Committed to mainline.
>
> With your patch, I was able to compile libgo and run libgo testsuite.
> There are two new testsuite failures for newly introduced tests:
>
> --- FAIL: TestKillStartProcess (0.00 seconds)
>         os_test.go:1173: Failed to build exe
> /tmp/go-build420056795/main.exe: exec: "go": executable file not found
> in $PATH
> --- FAIL: TestKillFindProcess (0.00 seconds)
>         os_test.go:1173: Failed to build exe
> /tmp/go-build353151102/main.exe: exec: "go": executable file not found
> in $PATH
> FAIL
> FAIL: os
> gmake[2]: *** [os/check] Error 1
>
> This should be trivial, I have no go in $PATH (IIRC, we already have
> fixed failure like this).

Thanks for the bug report.  Fixed with the appended patch.  Committed
to mainline.

Ian
diff mbox

Patch

diff -r 283d5ed3b086 libgo/go/os/os_test.go
--- a/libgo/go/os/os_test.go	Mon Nov 11 09:46:39 2013 -0800
+++ b/libgo/go/os/os_test.go	Mon Nov 11 11:39:53 2013 -0800
@@ -1142,6 +1142,7 @@ 
 }
 
 func testKillProcess(t *testing.T, processKiller func(p *Process)) {
+	t.Skip("gccgo does not have a go command")
 	dir, err := ioutil.TempDir("", "go-build")
 	if err != nil {
 		t.Fatalf("Failed to create temp directory: %v", err)