| Message ID | CAJMcOU_N2PzaAvgvHeqjdCuccyHdgqbUtCzq5Xn-P9ZAhMPr3w@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On 01/29/2015 01:53 PM, Jack Howarth wrote: > PR libffi/64855 > * testsuite/lib/libffi.exp: Don't set targetabis on darwin. Ok. r~
On Jan 29, 2015, at 1:56 PM, Richard Henderson <rth@redhat.com> wrote: > On 01/29/2015 01:53 PM, Jack Howarth wrote: >> PR libffi/64855 >> * testsuite/lib/libffi.exp: Don't set targetabis on darwin. > > Ok. Committed revision 220264.
Index: libffi/testsuite/lib/libffi.exp =================================================================== --- libffi/testsuite/lib/libffi.exp (revision 220263) +++ libffi/testsuite/lib/libffi.exp (working copy) @@ -310,7 +310,7 @@ proc run-many-tests { testcases extra_fl set targetabis { "" } if [string match $compiler_vendor "gnu"] { if { ([istarget "i?86-*-*"] || [istarget "x86_64-*-*"]) - && [is-effective-target ia32] } { + && [is-effective-target ia32] && ![istarget "*-*-darwin*"] } { set targetabis { "" "-DABI_NUM=FFI_STDCALL -DABI_ATTR=__STDCALL__"
The attached patch fixes PR64855 by not setting targetabis on darwin in testsuite/lib/libffi.exp as suggested by Iain Sandoe. Confirmed on x86_64-apple-darwin14 to eliminate the libffi regressions at -m32/-m64. Okay for gcc trunk? Jack 2015-01-29 Jack Howarth <howarth.at.gcc@gmail.com> PR libffi/64855 * testsuite/lib/libffi.exp: Don't set targetabis on darwin.