From patchwork Fri Nov 27 13:11:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SmnFmcOtIEVuZ2VsdGhhbGVy?= X-Patchwork-Id: 549459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B028D140319 for ; Sat, 28 Nov 2015 00:11:21 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=GZyPBzxR; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:cc:content-type; q=dns; s=default; b=SHCmreZ2iMxKU57zvKBdr N24PS1dJuTAFpIQLD8aZwf3J+syfhvQ8yGfKMQ3FAxzuMLzxnwTFctxwnBwoaUg8 owWCbAdUGs+wlVvhtWlujP6CStPK6fdXAQt2GnQdX1sNbG4CJMYz8KiV/eGHh7vf tER8jew84pIEb3HyQCabBY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:cc:content-type; s=default; bh=s31FR8v5X/mSupRLfs02XpBTjuM =; b=GZyPBzxR2mhR07g99YCHzdw2d+QUcaYsZlcGgfEFQEsA9OP1CFqjQowppeY wqKvwMjM5Oi5Yv/MylgCPQKxHMyDtLbJpQzUrHGvOT72TJbRxfKj+IfHRV1bxLqb cbNbZXtZcjYQrKwEYQTMnEyyXWXLqPWaIjy5b+KAMeodm9AM= Received: (qmail 111725 invoked by alias); 27 Nov 2015 13:11:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 111716 invoked by uid 89); 27 Nov 2015 13:11:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, MALFORMED_FREEMAIL, MISSING_HEADERS, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ig0-f171.google.com Received: from mail-ig0-f171.google.com (HELO mail-ig0-f171.google.com) (209.85.213.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 27 Nov 2015 13:11:13 +0000 Received: by igl9 with SMTP id 9so27211803igl.0 for ; Fri, 27 Nov 2015 05:11:11 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.50.66.229 with SMTP id i5mr8671993igt.5.1448629871189; Fri, 27 Nov 2015 05:11:11 -0800 (PST) Received: by 10.64.106.103 with HTTP; Fri, 27 Nov 2015 05:11:11 -0800 (PST) In-Reply-To: <56585176.3070907@redhat.com> References: <56585176.3070907@redhat.com> Date: Fri, 27 Nov 2015 14:11:11 +0100 Message-ID: Subject: Re: [PATCH] Fix PR68029 From: =?UTF-8?B?SmnFmcOtIEVuZ2VsdGhhbGVy?= Cc: gcc-patches@gcc.gnu.org X-IsSubscribed: yes 2015-11-27 13:49 GMT+01:00 Bernd Schmidt : > On 11/27/2015 01:30 PM, Jiří Engelthaler wrote: >> >> Sorry for international characters in my name. It should be >> >> Jiri Engelthaler >> >> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří : > > > There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael > Ávila de Espíndola. But I think there should be two spaces before the email > address. You are right - two spaces. >> PR driver/68029 >> * opts-common.c (prune_options): fdiagnostics_color ignored >> if it was as first parameter > > > This should read "Don't ignore -fdiagnostics-color if it is the first > parameter." Full sentences with punctuation. Changelog modified. Thank you for recommendation, this is my first patch to GCC. Engy 2015-11-27 Jiri Engelthaler PR driver/68029 * opts-common.c (prune_options): Don't ignore -fdiagnostics-color if it is the first parameter. gcc/opts-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/opts-common.c b/gcc/opts-common.c index d9bf4d4..24967cc 100644 --- a/gcc/opts-common.c +++ b/gcc/opts-common.c @@ -885,7 +885,7 @@ keep: } } - if (fdiagnostics_color_idx > 1) + if (fdiagnostics_color_idx >= 1) { /* We put the last -fdiagnostics-color= at the first position after argv[0] so it can take effect immediately. */