diff mbox

Fix PR68029

Message ID CAHODtZTCthR7sA5DDbeZWXF0CEAsg45CZdHKk0n8zWg4+jTnkw@mail.gmail.com
State New
Headers show

Commit Message

Jiří Engelthaler Nov. 27, 2015, 12:30 p.m. UTC 
Sorry for international characters in my name. It should be

Jiri Engelthaler

2015-11-27 13:29 GMT+01:00 Engelthaler Jiří <Jiri.Engelthaler@zat.cz>:
>
>
> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-owner@gcc.gnu.org] On Behalf Of Jiří Engelthaler
> Sent: Friday, November 27, 2015 11:23 AM
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] Fix PR68029
>
> Hi all,
>   the attached patch fixes PR68029 where GCC -fdiagnostics_color parameter was ignored if it was as first parameter. The problem is in GCC 6.0 version only so should be applied to the trunk.
>
>
> Jiří Engelthaler
2015-11-27  Jiri Engelthaler <engycz@gmail.com>

	PR driver/68029
	* opts-common.c (prune_options): fdiagnostics_color ignored
	if it was as first parameter
gcc/opts-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bernd Schmidt Nov. 27, 2015, 12:49 p.m. UTC | #1 
On 11/27/2015 01:30 PM, Jiří Engelthaler wrote:
> Sorry for international characters in my name. It should be
>
> Jiri Engelthaler
>
> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří <Jiri.Engelthaler@zat.cz>:

There is precedent for non-ASCII characters in ChangeLogs. Grep for 
Rafael Ávila de Espíndola. But I think there should be two spaces before 
the email address.

> 	PR driver/68029
> 	* opts-common.c (prune_options): fdiagnostics_color ignored
> 	if it was as first parameter

This should read "Don't ignore -fdiagnostics-color if it is the first
parameter." Full sentences with punctuation.

Otherwise this seems ok.


Bernd
Jiří Engelthaler Nov. 27, 2015, 1:10 p.m. UTC | #2 
2015-11-27 13:49 GMT+01:00 Bernd Schmidt <bschmidt@redhat.com>:
> On 11/27/2015 01:30 PM, Jiří Engelthaler wrote:
>>
>> Sorry for international characters in my name. It should be
>>
>> Jiri Engelthaler
>>
>> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří <Jiri.Engelthaler@zat.cz>:
>
>
> There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael
> Ávila de Espíndola. But I think there should be two spaces before the email
> address.

You are right - two spaces.

>>         PR driver/68029
>>         * opts-common.c (prune_options): fdiagnostics_color ignored
>>         if it was as first parameter
>
>
> This should read "Don't ignore -fdiagnostics-color if it is the first
> parameter." Full sentences with punctuation.

Changelog modified.

Thank you for recommendation, this is my first patch to GCC.

Engy
diff mbox

Patch

diff --git a/gcc/opts-common.c b/gcc/opts-common.c
index d9bf4d4..24967cc 100644
--- a/gcc/opts-common.c
+++ b/gcc/opts-common.c
@@ -885,7 +885,7 @@  keep:
 	}
     }
 
-  if (fdiagnostics_color_idx > 1)
+  if (fdiagnostics_color_idx >= 1)
     {
       /* We put the last -fdiagnostics-color= at the first position
 	 after argv[0] so it can take effect immediately.  */