diff mbox

[google] Add DW_AT and DW_FORM codes for Fission

Message ID CAHACq4oxGHtfNd9m9HsP7Tq+h5jwo_-zo0rHu7ws4-LFrE7kBA@mail.gmail.com
State New
Headers show

Commit Message

Cary Coutant Jan. 26, 2012, 10:50 p.m. UTC 
> OK to backport this from trunk to google/main and google/gcc-4_6?

Sorry, that diff isn't right, since an earlier version of this patch
is already in those branches. Here's the right diff...

-cary


2012-01-26  Cary Coutant  <ccoutant@google.com>

       * dwarf2.h (enum dwarf_form): Update Fission extensions, add
wiki reference.
       (enum dwarf_attribute): Likewise.

Comments

Diego Novillo Jan. 26, 2012, 10:51 p.m. UTC | #1 
On 1/26/12 5:50 PM, Cary Coutant wrote:
>> OK to backport this from trunk to google/main and google/gcc-4_6?
>
> Sorry, that diff isn't right, since an earlier version of this patch
> is already in those branches. Here's the right diff...

The second hunk was already in?  Still OK.


Diego.
Cary Coutant Jan. 26, 2012, 10:56 p.m. UTC | #2 
> The second hunk was already in?  Still OK.

Yeah, Jakub asked me to change the numbers for the DW_FORM codes for
upstream checkin, but the DW_AT codes we're using are OK.

-cary
diff mbox

Patch

Index: include/dwarf2.h
===================================================================
--- include/dwarf2.h	(revision 183586)
+++ include/dwarf2.h	(working copy)
@@ -189,10 +189,10 @@  enum dwarf_form
     DW_FORM_exprloc = 0x18,
     DW_FORM_flag_present = 0x19,
     DW_FORM_ref_sig8 = 0x20,
-    /* Extensions for Fission.  */
-    DW_FORM_GNU_ref_index = 0x70,
-    DW_FORM_GNU_addr_index = 0x71,
-    DW_FORM_GNU_str_index = 0x72
+    /* Extensions for Fission.  See http://gcc.gnu.org/wiki/DebugFission.  */
+    DW_FORM_GNU_ref_index = 0x1f00,
+    DW_FORM_GNU_addr_index = 0x1f01,
+    DW_FORM_GNU_str_index = 0x1f02
   };

 /* Attribute names and codes.  */
@@ -372,7 +372,7 @@  enum dwarf_attribute
     DW_AT_GNU_all_source_call_sites = 0x2118,
     /* Section offset into .debug_macro section.  */
     DW_AT_GNU_macros = 0x2119,
-    /* Extensions for Fission.  */
+    /* Extensions for Fission.  See http://gcc.gnu.org/wiki/DebugFission.  */
     DW_AT_GNU_dwo_name = 0x2130,
     DW_AT_GNU_dwo_id = 0x2131,
     DW_AT_GNU_ref_base = 0x2132,