From patchwork Thu Apr 23 08:52:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Terry Guo X-Patchwork-Id: 463913 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5049714012C for ; Thu, 23 Apr 2015 18:52:52 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=EWHr47bj; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=O7Cdn2yMCJysdgcieR jl5ZbsyrbP4hmwcLJ8egOqwUCXV+Gtp9g3ZDOgBZc9Q1wsi2NuCYrupgQSQrUXUZ 4qretNnKTmLNoqaNvqZ9vJO/cOxvBd8BVLLGykVz+brveVaSjpkQC23dHjpO5M0g VGHNcvhPs+U4uIk0TnO+fsOsQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=CyQUa6pAZV46Gnz9Exfmk6LX lnk=; b=EWHr47bjZ0tP2L7J6JYRYA1Vz/y67dhZXn2hroQHsP9sEpLViZZbsDVH PWYdVgOyz9vVOqSeRxqaVLklVwr+hiYi2gUZghBr64PqHQkpOLyDjLlVrnt4Byji ZxCIVVkLq11V8m0zI51CXgLZdnD/nlpONfucBkt2P5vPZlJfLsA= Received: (qmail 59957 invoked by alias); 23 Apr 2015 08:52:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 59936 invoked by uid 89); 23 Apr 2015 08:52:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 23 Apr 2015 08:52:41 +0000 Received: by wiax7 with SMTP id x7so7541029wia.0 for ; Thu, 23 Apr 2015 01:52:38 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.192.104 with SMTP id hf8mr3438000wjc.44.1429779158676; Thu, 23 Apr 2015 01:52:38 -0700 (PDT) Received: by 10.194.189.10 with HTTP; Thu, 23 Apr 2015 01:52:38 -0700 (PDT) In-Reply-To: <5538AF5C.5010608@arm.com> References: <5538ABE8.6060606@arm.com> <5538AF5C.5010608@arm.com> Date: Thu, 23 Apr 2015 16:52:38 +0800 Message-ID: Subject: Re: [Patch][ARM]Correct options for arm test case pr65710 From: Terry Guo To: Kyrill Tkachov Cc: GCC Patches , Ramana Radhakrishnan X-IsSubscribed: yes On Thu, Apr 23, 2015 at 4:37 PM, Kyrill Tkachov wrote: > > On 23/04/15 09:25, Terry Guo wrote: >> >> On Thu, Apr 23, 2015 at 4:23 PM, Kyrill Tkachov >> wrote: >>> >>> Hi Terry, >>> >>> On 23/04/15 02:56, Terry Guo wrote: >>>> >>>> /* { dg-do compile } */ >>>> -/* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */ >>>> +/* { dg-options "-mthumb -O2 -mfloat-abi=soft" } */ >>>> >>> >>> If you have really need the -mthumb here, don't you also >>> need to check for a thumb effective target? >>> I see in the testsuite we use things like: >>> /* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ >>> or >>> /* { dg-require-effective-target arm_thumb2_ok } */ >>> >>> Kyrill >>> >> The -mthumb is necessary to reproduce this bug currently. But it is >> better to enable running this test for other targets, so I prefer not >> limiting this case for thumb1 target. > > Hi Terry, > > I had a closer look. This test has lots of warnings so > you really need that -w in the original options as well. > I was concerned that if you try adding -mthumb when we're > testing a target that doesn't support Thumb (say -march=armv4) > you'll get an error "target CPU does not support THUMB instructions" > but having tried it out myself, I see that we have this as a warning, > not an error, so the -w will silence it! > > I would prefer if you added a: > > /* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ > > > So that the test will use Thumb (1 or 2) if possible, and not > test irrelevant to this test (defaulting -marm) behaviour otherwise. > > Kyrill > > > Patch is updated per your suggestion. Is it OK now? BR, Terry diff --git a/gcc/testsuite/gcc.target/arm/pr65710.c b/gcc/testsuite/gcc.target/arm/pr65710.c index 139bc64..227059b 100644 --- a/gcc/testsuite/gcc.target/arm/pr65710.c +++ b/gcc/testsuite/gcc.target/arm/pr65710.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ -/* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */ +/* { dg-options "-mthumb -O2 -mfloat-abi=soft -w" } */ +/* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ struct ST { char *buffer;