diff mbox

[C++] PR c++/80812

Message ID CAFk2RUbhjh3RGDOEurUrF6H5j95VyMXR3F43noDij0mD5Q3Gaw@mail.gmail.com
State New
Headers show

Commit Message

Ville Voutilainen May 25, 2017, 9:29 a.m. UTC 
Tested on Linux-x64, running full suite on Linux-ppc64. It seems fitting
to put the test into the library tests, we don't have separate tests
on the front-end side for __is_constructible, so I think adding such
would be a separate job.

2017-05-25  Ville Voutilainen  <ville.voutilainen@gmail.com>

    cp/

    PR c++/80812
    * method.c (constructible_expr): Strip array types before calling
    build_value_init.

    libstdc++/

    PR c++/80812
    * testsuite/20_util/is_constructible/80812.cc: New.

Comments

Jason Merrill May 31, 2017, 8:34 p.m. UTC | #1 
On 05/25/2017 05:29 AM, Ville Voutilainen wrote:
> Tested on Linux-x64, running full suite on Linux-ppc64. It seems fitting
> to put the test into the library tests, we don't have separate tests
> on the front-end side for __is_constructible, so I think adding such
> would be a separate job.
> 
> 2017-05-25  Ville Voutilainen  <ville.voutilainen@gmail.com>
> 
>      cp/
> 
>      PR c++/80812
>      * method.c (constructible_expr): Strip array types before calling
>      build_value_init.

OK.

Jason
diff mbox

Patch

diff --git a/gcc/cp/method.c b/gcc/cp/method.c
index 8aa4f3e..aa607d5 100644
--- a/gcc/cp/method.c
+++ b/gcc/cp/method.c
@@ -1188,7 +1188,7 @@  constructible_expr (tree to, tree from)
   else
     {
       if (from == NULL_TREE)
-	return build_value_init (to, tf_none);
+	return build_value_init (strip_array_types (to), tf_none);
       else if (TREE_CHAIN (from))
 	return error_mark_node; // too many initializers
       from = build_stub_object (TREE_VALUE (from));
diff --git a/libstdc++-v3/testsuite/20_util/is_constructible/80812.cc b/libstdc++-v3/testsuite/20_util/is_constructible/80812.cc
new file mode 100644
index 0000000..17af9ae
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/is_constructible/80812.cc
@@ -0,0 +1,29 @@ 
+// { dg-do compile { target c++11 } }
+// Copyright (C) 2017 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <type_traits>
+
+struct X
+{
+  X() {}
+};
+
+void test01()
+{
+  static_assert(std::is_constructible<X[4]>::value);
+}