diff mbox

[COMMITTED] MAINTAINERS (Write After Approval): Add myself.

Message ID CAFk2RUY7SKqS=A85kGiUZ+SjN5_kaz6QhFF38fptoW-zMj0iOw@mail.gmail.com
State New
Headers show

Commit Message

Ville Voutilainen July 29, 2015, 5:29 p.m. UTC 
Fyi.

2015-07-29  Ville Voutilainen  <ville.voutilainen@gmail.com>
        * MAINTAINERS (Write After Approval): Add myself.

Comments

Marek Polacek July 29, 2015, 6:48 p.m. UTC | #1 
On Wed, Jul 29, 2015 at 08:29:34PM +0300, Ville Voutilainen wrote:
> Fyi.
> 
> 2015-07-29  Ville Voutilainen  <ville.voutilainen@gmail.com>
>         * MAINTAINERS (Write After Approval): Add myself.

There should be a blank line between these two lines.

	Marek
Ville Voutilainen July 29, 2015, 7:18 p.m. UTC | #2 
On 29 July 2015 at 21:48, Marek Polacek <polacek@redhat.com> wrote:
> On Wed, Jul 29, 2015 at 08:29:34PM +0300, Ville Voutilainen wrote:
>> Fyi.
>>
>> 2015-07-29  Ville Voutilainen  <ville.voutilainen@gmail.com>
>>         * MAINTAINERS (Write After Approval): Add myself.
>
> There should be a blank line between these two lines.

Ok, I added the blank line and committed the change as obvious. :)
Ville Voutilainen July 29, 2015, 7:19 p.m. UTC | #3 
On 29 July 2015 at 22:18, Ville Voutilainen <ville.voutilainen@gmail.com> wrote:
> On 29 July 2015 at 21:48, Marek Polacek <polacek@redhat.com> wrote:
>> On Wed, Jul 29, 2015 at 08:29:34PM +0300, Ville Voutilainen wrote:
>>> Fyi.
>>>
>>> 2015-07-29  Ville Voutilainen  <ville.voutilainen@gmail.com>
>>>         * MAINTAINERS (Write After Approval): Add myself.
>>
>> There should be a blank line between these two lines.
>
> Ok, I added the blank line and committed the change as obvious. :)

Although the commit message for this supposedly obvious change is f**ked up
since it claims I modified MAINTAINERS, whereas I modified ChangeLog.
Such fun.
Marek Polacek July 29, 2015, 7:24 p.m. UTC | #4 
On Wed, Jul 29, 2015 at 10:19:52PM +0300, Ville Voutilainen wrote:
> Although the commit message for this supposedly obvious change is f**ked up
> since it claims I modified MAINTAINERS, whereas I modified ChangeLog.
> Such fun.

The commit message doesn't matter that much.  Your last change looks ok.

	Marek
diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index 4fcf016..bf49729 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,6 @@ 
+2015-07-29  Ville Voutilainen  <ville.voutilainen@gmail.com>
+	* MAINTAINERS (Write After Approval): Add myself.
+
 2012-12-29  Ben Elliston  <bje@gnu.org>
 
 	* config.sub, config.guess: Import from upstream.
diff --git a/MAINTAINERS b/MAINTAINERS
index bdfd2be..1e9211a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -592,6 +592,7 @@  Andre Vehreschild				<vehre@gmx.de>
 Alex Velenko					<alex.velenko@arm.com>
 Ilya Verbin					<iverbin@gmail.com>
 Kugan Vivekanandarajah				<kuganv@linaro.org>
+Ville Voutilainen				<ville.voutilainen@gmail.com>
 Tom de Vries					<tom@codesourcery.com>
 Nenad Vukicevic					<nenad@intrepid.com>
 Feng Wang					<fengwang@nudt.edu.cn>