From patchwork Sun Jan 27 13:21:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 215987 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 665FD2C0090 for ; Mon, 28 Jan 2013 00:21:30 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1359897691; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Date:Message-ID:Subject:From:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=L/X9n+E oEmtQeeKHiQtJB9DX3YM=; b=NE23QB4xj7oH36e6IffJ3s+rScBQIfbqOzhSsE3 /WSoNpB/DCXyAJ7soWlTwzpja7ceMSpUIBSCX6M1ubgUv96noHjiWEnE1z/bPsYY Ki4GjFkAQVkaVIUUH1uiApORnnKjwfSiGtoo4ZsOpdyT1YIwa2S5LFgpxet7JXk9 9vFg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:X-Received:Received:Date:Message-ID:Subject:From:To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=jgLktm+79TY8Y5FNNF5PK4eG4NMkva3eG8/feQua7FETJl8j33zQl9EiFmseuI OeoCfY4qNp22bMNPPm9+YEwNPTROxrt83J+KZPwTnPCjxc2A1JW5Ae85+WBlsJ7w TCClmZQ/0O8rtXDFdOynvGSdVYJkHnaqqNmustH4q9F4Q=; Received: (qmail 24118 invoked by alias); 27 Jan 2013 13:21:19 -0000 Received: (qmail 24107 invoked by uid 22791); 27 Jan 2013 13:21:16 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Jan 2013 13:21:09 +0000 Received: by mail-oa0-f48.google.com with SMTP id h2so1930012oag.7 for ; Sun, 27 Jan 2013 05:21:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.12.103 with SMTP id x7mr9158144oeb.56.1359292868315; Sun, 27 Jan 2013 05:21:08 -0800 (PST) Received: by 10.182.49.68 with HTTP; Sun, 27 Jan 2013 05:21:08 -0800 (PST) Date: Sun, 27 Jan 2013 14:21:08 +0100 Message-ID: Subject: [PATCH, i386]: Fix PR 56114, x86_64-linux-gnu-gcc generate wrong asm instruction MOVABS for intel syntax From: Uros Bizjak To: gcc-patches@gcc.gnu.org Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello! 2013-01-27 Uros Bizjak PR target/56114 * config/i386/i386.md (*movabs_1): Add square brackets around operand 0 in movabs insn template for -masm=intel asm alternative. (*movabs_2): Ditto for operand 1. testsuite/ChangeLog: 2013-01-27 Uros Bizjak PR target/56114 * gcc.target/i386/pr56114.c: New test. Tested on x86_64-pc-linux-gnu, committed to mainline SVN, will be backported to other release branches. Uros. Index: config/i386/i386.md =================================================================== --- config/i386/i386.md (revision 195488) +++ config/i386/i386.md (working copy) @@ -2308,7 +2308,7 @@ (match_operand:SWI1248x 1 "nonmemory_operand" "a,r"))] "TARGET_LP64 && ix86_check_movabs (insn, 0)" "@ - movabs{}\t{%1, %P0|%P0, %1} + movabs{}\t{%1, %P0|[%P0], %1} mov{}\t{%1, %a0|%a0, %1}" [(set_attr "type" "imov") (set_attr "modrm" "0,*") @@ -2322,7 +2322,7 @@ (mem:SWI1248x (match_operand:DI 1 "x86_64_movabs_operand" "i,r")))] "TARGET_LP64 && ix86_check_movabs (insn, 1)" "@ - movabs{}\t{%P1, %0|%0, %P1} + movabs{}\t{%P1, %0|%0, [%P1]} mov{}\t{%a1, %0|%0, %a1}" [(set_attr "type" "imov") (set_attr "modrm" "0,*") Index: testsuite/gcc.target/i386/pr56114.c =================================================================== --- testsuite/gcc.target/i386/pr56114.c (revision 0) +++ testsuite/gcc.target/i386/pr56114.c (working copy) @@ -0,0 +1,10 @@ +/* { dg-do assemble } */ +/* { dg-options "-O2 -masm=intel" } */ +/* { dg-require-effective-target lp64 } */ +/* { dg-require-effective-target masm_intel } */ + +long +foo2 (void) +{ + return *(volatile int *) 0xFEE00000; +}