From patchwork Thu Aug 26 20:11:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1521336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=AOnFKNtF; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GwYsn69XZz9sW4 for ; Fri, 27 Aug 2021 06:12:12 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 782933858413 for ; Thu, 26 Aug 2021 20:12:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 782933858413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1630008729; bh=a6aLlaeV4Q7+9qxadhBnaGVuN57tIMuXuur6HXoVADE=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=AOnFKNtFTlWXP4FY58lUJHfWquTsK1Vy7R77FSmaV1LC/W12Aw1EauPidIZBMs0BI KqOtNt40bnO66u/IeBnrZEyrTcWWGuQqG0aIxkb4dWRJQmwOe1grnVTHfU2NNrpGwq RgzcAhEv2dB5G+oEi7xetUBaYT4mTCkFq/5Z8Tho= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by sourceware.org (Postfix) with ESMTPS id 22A6E3858D3C for ; Thu, 26 Aug 2021 20:11:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22A6E3858D3C Received: by mail-qk1-x733.google.com with SMTP id b64so4949799qkg.0 for ; Thu, 26 Aug 2021 13:11:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=a6aLlaeV4Q7+9qxadhBnaGVuN57tIMuXuur6HXoVADE=; b=tgEqIFjKvNpa2UxhsR6WaVVDlKLUpWTMXb0U+n8bnJ1nSjRkCHXCjG235PIq/PHQ6Z Qxnb3I3xh5AfGx8SNccNif5E+C/BITRUk06dIXVoE9Fmohy6VpW5pLVAuc/p8QwcH2GY dqTCULL0Gea29kRc1X0NV3WPaYffBlQz0uEJBImjwFVCHOv9CF82rIUFRXO7VpxJiZmh QMn1odCvQ+EX3W+I0Bi7U8IQIDsx76oIULU/hS/iyjq+Hzxpi23IqlJNgCuefYq0fB2k NwZuDaKqOFtSkmoyJ2i+EV/aZnCIhTB9UtvcKgu8ZO3wULv2jC+tkE7UrasmlF5FR2Aa WmNA== X-Gm-Message-State: AOAM5305hhwYYC71Du89gxRhq2uBINPpYkzesW3+aHZLefse8C5+j0xy UqM28pB8xldZbeF7X6ADlqbiLgNIhxwmWj5ZG6U2J1jciMqg+g== X-Google-Smtp-Source: ABdhPJxDCXpttU4hGmaYP2u/ZZSSJYolZdXan3OZIaP01goq+FXMB08mn6FXU2kbLRCOS/NAvNLQsI0r/80UlNTn2uM= X-Received: by 2002:a37:a094:: with SMTP id j142mr5604543qke.465.1630008699288; Thu, 26 Aug 2021 13:11:39 -0700 (PDT) MIME-Version: 1.0 Date: Thu, 26 Aug 2021 22:11:28 +0200 Message-ID: Subject: [PATCH] [i386] Call force_reg unconditionally. To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" There is no point to check RTXes before calling force_reg, force_reg checks for REG RTX by itself. 2021-08-26 Uroš Bizjak gcc/ * config/i386/i386.md (*btr_1): Call force_reg unconditionally. (conditional moves with memory inputs splitters): Ditto. * config/i386/sse.md (one_cmpl2): Simplify. No functional changes. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 41d85623ad6..de34916c1cc 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -12728,8 +12728,7 @@ (clobber (reg:CC FLAGS_REG))])] { operands[0] = lowpart_subreg (SImode, operands[0], mode); - if (MEM_P (operands[1])) - operands[1] = force_reg (mode, operands[1]); + operands[1] = force_reg (mode, operands[1]); operands[1] = lowpart_subreg (SImode, operands[1], mode); }) @@ -19352,10 +19351,8 @@ [(set (match_dup 0) (if_then_else:SWI248 (match_dup 1) (match_dup 2) (match_dup 3)))] { - if (MEM_P (operands[2])) - operands[2] = force_reg (mode, operands[2]); - if (MEM_P (operands[3])) - operands[3] = force_reg (mode, operands[3]); + operands[2] = force_reg (mode, operands[2]); + operands[3] = force_reg (mode, operands[3]); }) (define_insn "*movqicc_noc" @@ -19603,10 +19600,8 @@ [(set (match_dup 0) (if_then_else:MODEF (match_dup 1) (match_dup 2) (match_dup 3)))] { - if (MEM_P (operands[2])) - operands[2] = force_reg (mode, operands[2]); - if (MEM_P (operands[3])) - operands[3] = force_reg (mode, operands[3]); + operands[2] = force_reg (mode, operands[2]); + operands[3] = force_reg (mode, operands[3]); }) ;; Don't do conditional moves with memory inputs diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 13889687793..d689617ac39 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -14084,10 +14084,10 @@ (match_dup 2)))] "TARGET_SSE" { + operands[2] = CONSTM1_RTX (mode); + if (!TARGET_AVX512F) - operands[2] = force_reg (mode, CONSTM1_RTX (mode)); - else - operands[2] = CONSTM1_RTX (mode); + operands[2] = force_reg (mode, operands[2]); }) (define_insn "one_cmpl2"