From patchwork Fri Apr 29 10:51:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 616684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qx9Vy6fv6z9t7j for ; Fri, 29 Apr 2016 20:51:53 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=EPmV5ONA; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=yu7rSYjMUAJ5axbl19 LuqbDH3GPoNX6itg/E0bvpTtuAbe+AnS2ArMAz6UvaQvSeETumss/DV+05t5ibYL wULMvYZ2bX3EHgXN6TaiKjTtv2QRIA+5Lpn1R5Bj/thbEU5FblY0dZSw3IA3EXUB QPRnaMlDXSvofvJDv5o3zK3y4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=kDUWze38LdtnZK96EfWUBbaH TeY=; b=EPmV5ONA3ek5gYICPZLiih1WMzbMxeiDGZE/pnXYtIreAC4F/McEC3hv gGX0YlYppHhP44jbi/X5HrjIHXKjt8sNR9WQN1T/vloaqvnlVzwxHxGyDmbkI0dN DYvjbuuXsYUmOd0AK6TM6cmRnlR9tNVqzP4H45LuWfUDm2al+Q4= Received: (qmail 50894 invoked by alias); 29 Apr 2016 10:51:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 50876 invoked by uid 89); 29 Apr 2016 10:51:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1467, clever X-HELO: mail-yw0-f175.google.com Received: from mail-yw0-f175.google.com (HELO mail-yw0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 Apr 2016 10:51:35 +0000 Received: by mail-yw0-f175.google.com with SMTP id t10so179026610ywa.0 for ; Fri, 29 Apr 2016 03:51:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=6O1UhsvUbRovUr1trzkAkdIPmD5AD51SiYibfPmxF/o=; b=BoK8rNUFetkmaG23KIUBEvyGucuwC8G+kAVWYrfgJwvLmeOVvGQSwD7LUonhJrQSsM vi0hN/hYo5wdQ2jslYVldVMkILO7CaSPqOIPw0/2AHEkFno4+7i3IOc47r7GlLc98QZR TXJh+OjwZCnsO41sLEV5Li0pxzS0NHVPDKF4D3X7n92QxNiStf5sgM4xZt/qXRFPSsS1 sd4IZthgv8FS4ngLZODZbHv+zYcL6JJm0A+MZdafAkrDXuMpUyyVTJaCg3g71J6ZMWDq 5OO74CNLsP4RV6ni1YQNdjg5YFVP8G/ZQHw+WY5BshsH3WzSxbFIGQf4w07nnNt7HTzF X1iw== X-Gm-Message-State: AOPr4FV8/WeDxcnul/lq6bIS6hOFKAswHBn5XvtSBskHH+6lFWN1zWXYjPj9ionsOW81Jwqfzw1bDHZxEApMFg== MIME-Version: 1.0 X-Received: by 10.176.64.104 with SMTP id h95mr11019960uad.84.1461927093435; Fri, 29 Apr 2016 03:51:33 -0700 (PDT) Received: by 10.103.76.220 with HTTP; Fri, 29 Apr 2016 03:51:33 -0700 (PDT) In-Reply-To: <3799415.uPfXC5v7Nr@polaris> References: <3466465.kPQ0hp1mLX@polaris> <3799415.uPfXC5v7Nr@polaris> Date: Fri, 29 Apr 2016 12:51:33 +0200 Message-ID: Subject: Re: [PATCH, i386]: Extend TARGET_READ_MODIFY{, _WRITE} peepholes to all integer modes From: Uros Bizjak To: Eric Botcazou Cc: "gcc-patches@gcc.gnu.org" On Fri, Apr 29, 2016 at 12:17 PM, Eric Botcazou wrote: >> I'm testing the attached patch. Does it fix your ada failures? > > No, it totally breaks stack checking. :-( Eh, I was trying to be too clever. Attached patch was actually tested on a couple of cases. It generates the same assembly as before. Uros. Index: i386.md =================================================================== --- i386.md (revision 235620) +++ i386.md (working copy) @@ -88,6 +88,7 @@ UNSPEC_SET_GOT_OFFSET UNSPEC_MEMORY_BLOCKAGE UNSPEC_STACK_CHECK + UNSPEC_PROBE_STACK ;; TLS support UNSPEC_TP @@ -17552,6 +17553,29 @@ DONE; }) +(define_expand "probe_stack" + [(match_operand 0 "memory_operand")] + "" +{ + rtx (*insn) (rtx) + = (GET_MODE (operands[0]) == DImode + ? gen_probe_stack_di : gen_probe_stack_si); + + emit_insn (insn (operands[0])); + DONE; +}) + +;; Use OR for stack probes, this is shorter. +(define_insn "probe_stack_" + [(set (match_operand:W 0 "memory_operand" "=m") + (unspec:W [(const_int 0)] UNSPEC_PROBE_STACK)) + (clobber (reg:CC FLAGS_REG))] + "" + "or{}\t{$0, %0|%0, 0}" + [(set_attr "type" "alu1") + (set_attr "mode" "") + (set_attr "length_immediate" "1")]) + (define_insn "adjust_stack_and_probe" [(set (match_operand:P 0 "register_operand" "=r") (unspec_volatile:P [(match_operand:P 1 "register_operand" "0")]