From patchwork Tue May 21 17:59:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1102945 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-501382-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 457k8G4c5Qz9s9T for ; Wed, 22 May 2019 04:00:41 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=IFH+wjN5wvCK7jovVfJ9WZZbCPvK2JuaJdXdMqzDvozfKC C+siOnqDJnYvrhopzD0Oijk7PPFze7Mnv5XokekoMJI3CnjnlvAoycedoAX69h3e 1ii6VMzSeSYPXuT4ewE5ZRvZyAi4QaiXnANnq9O648iTRfrmKevSl4fb876r0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=4yxl9njK+eG4YCBiLaSpv848jis=; b=pdEv0OaBZKZzqFytN/YJ atyIYOkW8IUP0GeqvNbIi1nmvJxqrw4IZNDmZQCZx9/ACHGbosTkv7C0cxEXO5tC g6iXq3KwkO26dsWwjsAY5VslLc8sK4LGvFY9Rc/zQ9GlIS71P+49QjUmpRNMzKaB jCO68OSOfeZmeKl9+jIAur4= Received: (qmail 65968 invoked by alias); 21 May 2019 18:00:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 65852 invoked by uid 89); 21 May 2019 18:00:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-io1-f49.google.com Received: from mail-io1-f49.google.com (HELO mail-io1-f49.google.com) (209.85.166.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 May 2019 18:00:13 +0000 Received: by mail-io1-f49.google.com with SMTP id a17so14657298iot.8 for ; Tue, 21 May 2019 11:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=aSNtOA8qWVBh+8b/0EZ3dmijTxy/9FIzu7YF7O86h34=; b=JaTPjvUYmqkaGw76tFsn6E588pgGTZ/KQS/3BfOotVb7zuDvoMvvrmRoOraccxF08+ laUxztvUXOkpwuTlK7CqPnES+u76/9ng1gGNptcWol4DUjR+P9T2O7HbJruc4nbjfH4p KfK+Z2E04aBofNC+v0GzTmJv/c+kyVb8ioDW2bzo84etpfufZcBabdoSeFgWNCYp4ob7 My+ah47OpX1OusBG2y3DPLAocoEPfAjAbhEtg32EOg8Xrvr+RIlmcpGAbmdgG8n0IzdE 3Uc1mlmbmUH7mb5qGU72wtkYnh9+R6Y/4yhCEd6HbzzpEIIMueIjG1c7XlHvHD1mN/Tj VZig== MIME-Version: 1.0 From: Uros Bizjak Date: Tue, 21 May 2019 19:59:54 +0200 Message-ID: Subject: [PATCH, i386]: Fix PR90547, ICE in gen_lowpart_general To: "gcc-patches@gcc.gnu.org" 2019-05-21 Uroš Bizjak PR target/90547 * config/i386/i386.md (anddi_1 to andsi_1_zext splitter): Avoid calling gen_lowpart with CONST operand. testsuite/ChangeLog: 2019-05-21 Uroš Bizjak PR target/90547 * gcc.target/i386/pr90547.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline SVN, patch will be backported to all release branches. Uros. Index: config/i386/i386.md =================================================================== --- config/i386/i386.md (revision 271467) +++ config/i386/i386.md (working copy) @@ -8525,6 +8525,14 @@ operands[2] = shallow_copy_rtx (operands[2]); PUT_MODE (operands[2], SImode); } + else if (GET_CODE (operands[2]) == CONST) + { + /* (const:DI (plus:DI (symbol_ref:DI ("...")) (const_int N))) */ + operands[2] = copy_rtx (operands[2]); + PUT_MODE (operands[2], SImode); + PUT_MODE (XEXP (operands[2], 0), SImode); + PUT_MODE (XEXP (XEXP (operands[2], 0), 0), SImode); + } else operands[2] = gen_lowpart (SImode, operands[2]); }) Index: testsuite/gcc.target/i386/pr90547.c =================================================================== --- testsuite/gcc.target/i386/pr90547.c (nonexistent) +++ testsuite/gcc.target/i386/pr90547.c (working copy) @@ -0,0 +1,21 @@ +/* PR target/90547 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +void +foo () +{ + void *g[] = {&&a, &&b}; + + for (unsigned c = 0x1F;; c >>= 1) + { + unsigned d = (long)("a"+1); + long e = 8; + + while (e) + { + a: goto *g[c&d]; + b: e--; + } + } +}