From patchwork Tue Mar 13 19:14:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 146471 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0C72CB6EF3 for ; Wed, 14 Mar 2012 06:14:42 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1332270883; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=dNPpqYUoADmXc9/45DQzHp7Tqj4=; b=wJTTKSy8iIriLbisrXkyB8NcIlKshDPqS6o0UYM47yJIdZbOqmTyWPYBMt+WbT AJeuC60zKLYktIa3vMwf7vopm4c5imO6GtVmEhcTgfId9RAoELT5HjCPYxaSze4O jOoZyahKtENcRdo5DXf1Shfxi23+W6iXmeK7u47ttgFoQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=MMpc3MeI8oucWB+ji44ONRWQ/veZlnltihtaYt7uF0gu0YKOalhCxzaNrlcv0Q kEyeOz/wEWYJOhjwFSiqGIc097bPl3F06ntBS3Lb8Jrma+U9fft8n+wN+Ebt/OAX frD/AQBIpSvZd9ela0JojlPW4kxoRmymjoQIBO7nFAPoM=; Received: (qmail 29290 invoked by alias); 13 Mar 2012 19:14:37 -0000 Received: (qmail 29280 invoked by uid 22791); 13 Mar 2012 19:14:35 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Mar 2012 19:14:21 +0000 Received: by yhjj56 with SMTP id j56so982225yhj.20 for ; Tue, 13 Mar 2012 12:14:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.244.33 with SMTP id r33mr3977487anh.54.1331666060411; Tue, 13 Mar 2012 12:14:20 -0700 (PDT) Received: by 10.146.241.18 with HTTP; Tue, 13 Mar 2012 12:14:20 -0700 (PDT) In-Reply-To: References: <20120305113416.GV18768@tyan-ft48-01.lab.bos.redhat.com> Date: Tue, 13 Mar 2012 20:14:20 +0100 Message-ID: Subject: Re: [PATCH, i386] RTM support From: Uros Bizjak To: Kirill Yukhin Cc: Jakub Jelinek , gcc-patches List , "H.J. Lu" , Andi Kleen , Richard Henderson , Tobias Burnus Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sun, Mar 11, 2012 at 10:16 AM, Kirill Yukhin wrote: >> >> The patch is OK for mainline, if there are no further comments in next 24h. > > According to Tobias's input, I've added few lines about RTM to > doc/invoke.texi. If no objections - I'll commit the patch tomorrow. A small no-op change - there is no need for a constraint in an expand pattern. Plus some formatting. 2012-03-13 Uros Bizjak * config/i386/i386.md (xbegin): Remove constraint from expander. Tested on x86_64-pc-linux-gnu, committed to mainline SVN. Uros. Index: i386.md =================================================================== --- i386.md (revision 185350) +++ i386.md (working copy) @@ -18206,7 +18206,7 @@ (set_attr "memory" "unknown")]) (define_expand "xbegin" - [(set (match_operand:SI 0 "register_operand" "=a") + [(set (match_operand:SI 0 "register_operand" "") (unspec_volatile:SI [(match_dup 1)] UNSPECV_XBEGIN))] "TARGET_RTM" { @@ -18258,8 +18258,8 @@ { emit_insn (gen_xtest_1 ()); - ix86_expand_setcc (operands[0], EQ, gen_rtx_REG (CCZmode, FLAGS_REG), const0_rtx); - + ix86_expand_setcc (operands[0], EQ, + gen_rtx_REG (CCZmode, FLAGS_REG), const0_rtx); DONE; })