diff mbox

[testsuite] : Correct testcase for LLP64 targets

Message ID CAEwic4a+bDnTqPLSfcNdYPYxeRXE1+HW0uq9qhSOY0doiV43Sg@mail.gmail.com
State New
Headers show

Commit Message

Kai Tietz March 17, 2014, 9:57 a.m. UTC 
2014-03-17 10:53 GMT+01:00 Jakub Jelinek <jakub@redhat.com>:
> On Mon, Mar 17, 2014 at 10:50:35AM +0100, Rainer Orth wrote:
>> Hi Kai,
>>
>> > Index: gcc.c-torture/compile/20010327-1.c
>> > ===================================================================
>> > --- gcc.c-torture/compile/20010327-1.c    (Revision 208594)
>> > +++ gcc.c-torture/compile/20010327-1.c    (Arbeitskopie)
>> > @@ -1,4 +1,5 @@
>> >  /* { dg-require-effective-target ptr32plus } */
>> > +/* { dg-skip-if "" { { i?86-*-* x86_64-*-* } && { llp64 } } { "*" } { "" } } */
>>
>> the usual comments apply:
>>
>> * add a comment/PR reference as the first arg to dg-skip-if explaining
>>   the skip
>>
>> * omit the default args { "*" } { "" }
>
> Or perhaps just drop dg-require-effective-target directive and instead do
> /* { dg-do compile { target { ptr32plus && ! llp64 } } } */
>
>         Jakub

Yeah, omitting the dg-require-effective-target directive looks to me
like the best thing to do.  To add a skip-directive is superflous.

Ok with patch following patch?

Kai
diff mbox

Patch

Index: 20010327-1.c
===================================================================
--- 20010327-1.c    (Revision 208594)
+++ 20010327-1.c    (Arbeitskopie)
@@ -1,4 +1,4 @@ 
-/* { dg-require-effective-target ptr32plus } */
+/* { dg-do compile { ptr32plus && !llp64 } } */

 /* This testcase tests whether GCC can produce static initialized data
    that references addresses of size 'unsigned long', even if that's not