diff mbox

[testsuite] : Correct testcase for LLP64 targets

Message ID CAEwic4ZqHmkUtxzAg5mQ8YzNM==EkYwJU3iSAfVZQyWuPez9dw@mail.gmail.com
State New
Headers show

Commit Message

Kai Tietz March 17, 2014, 9:01 a.m. UTC 
Hi,

this patch corrects a regression seen in
gcc.c-torture/compile/20010327-1.c for LLP64 targets.

ChangeLog

2013-03-17  Kai Tietz  <ktietz@redhat.com>

        * gcc.c-torture/compile/20010327-1.c: Adjust testcase for LLP64 targets.

Ok for apply?

Regards,
Kai

Comments

Rainer Orth March 17, 2014, 9:50 a.m. UTC | #1 
Hi Kai,

> Index: gcc.c-torture/compile/20010327-1.c
> ===================================================================
> --- gcc.c-torture/compile/20010327-1.c    (Revision 208594)
> +++ gcc.c-torture/compile/20010327-1.c    (Arbeitskopie)
> @@ -1,4 +1,5 @@
>  /* { dg-require-effective-target ptr32plus } */
> +/* { dg-skip-if "" { { i?86-*-* x86_64-*-* } && { llp64 } } { "*" } { "" } } */

the usual comments apply:

* add a comment/PR reference as the first arg to dg-skip-if explaining
  the skip

* omit the default args { "*" } { "" }

	Rainer
Jakub Jelinek March 17, 2014, 9:53 a.m. UTC | #2 
On Mon, Mar 17, 2014 at 10:50:35AM +0100, Rainer Orth wrote:
> Hi Kai,
> 
> > Index: gcc.c-torture/compile/20010327-1.c
> > ===================================================================
> > --- gcc.c-torture/compile/20010327-1.c    (Revision 208594)
> > +++ gcc.c-torture/compile/20010327-1.c    (Arbeitskopie)
> > @@ -1,4 +1,5 @@
> >  /* { dg-require-effective-target ptr32plus } */
> > +/* { dg-skip-if "" { { i?86-*-* x86_64-*-* } && { llp64 } } { "*" } { "" } } */
> 
> the usual comments apply:
> 
> * add a comment/PR reference as the first arg to dg-skip-if explaining
>   the skip
> 
> * omit the default args { "*" } { "" }

Or perhaps just drop dg-require-effective-target directive and instead do
/* { dg-do compile { target { ptr32plus && ! llp64 } } } */

	Jakub
diff mbox

Patch

Index: gcc.c-torture/compile/20010327-1.c
===================================================================
--- gcc.c-torture/compile/20010327-1.c    (Revision 208594)
+++ gcc.c-torture/compile/20010327-1.c    (Arbeitskopie)
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target ptr32plus } */
+/* { dg-skip-if "" { { i?86-*-* x86_64-*-* } && { llp64 } } { "*" } { "" } } */

 /* This testcase tests whether GCC can produce static initialized data
    that references addresses of size 'unsigned long', even if that's not