From patchwork Fri Feb 10 18:23:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 726661 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vKjyq43Fnz9s6n for ; Sat, 11 Feb 2017 05:24:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="hECjgY7l"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=Rgb9SxYODv8PosW3py3+wH7rkZb5KuQBrZ7h/FvPZddS06 CL4oBPrlghUcvixitB1MffRYVTCiOAb9oUHCbOcXi3PZ3IgnYovx7ZDh/oR2aVIp HOjUGncSZ3U8jQC0xgUDsTZMoNW1AF3R4F+8u+Ld7zUo55+QUXBEW9T5E6nJY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=69/qB6Us/oXk1Xx/1DBC8pwNfFM=; b=hECjgY7lMNxnl1I1XL9O qr+QL8VuNojpLL4+Z8HnkV2PRJFEP45klTatzAmbbHm/LYt7drZXCt7BLGUqPGcQ YqNBAYOvfJS6wGKBnOibCMU0L13oT5ZHqllAnkLXPN+F1eINXSYNXIkPMJx1b9nl k6vj1SRIZ82+L3DwX5WPGH8= Received: (qmail 41067 invoked by alias); 10 Feb 2017 18:24:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 41036 invoked by uid 89); 10 Feb 2017 18:24:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=improperly X-HELO: mail-ot0-f177.google.com Received: from mail-ot0-f177.google.com (HELO mail-ot0-f177.google.com) (74.125.82.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Feb 2017 18:24:16 +0000 Received: by mail-ot0-f177.google.com with SMTP id f9so34516750otd.1 for ; Fri, 10 Feb 2017 10:24:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kfEe3LENNn5XRiFRUYkOjlMQAwU7uuLoGGYP5eoSx4U=; b=PAUg4qDRAJTT8r8IcBskx+hLcMcTiCVKbovAYVLTXNMY4dNpFxwDqlhZmrxCpK2ZCY maWO913bO5+ag+Pd9mba3HEaUjUwjbKAPm9SloS1uP9u4WFGKBjsFLN6nDLaGIZ4K7OJ kyzWe5N/cbPTXF/Rj9fNStIbsEo43aF6Uyzy2n2cS0IN7pWTv2gKrvfm8m/vyVc2/Dur B4zUqrSDAPAIAnenso41MyWa3sCGsx8XS6FShxqak1H2DJFodDaTTei7JS4iVwDI4N6S D2gzh6xLCRzbj5qJRSqw4VnWBe8enWy06lQnlCYDCVCs0iOs27txnf8lsVCTbPvibgui eafw== X-Gm-Message-State: AMke39m1J7PrMglkvsba0JGdm2M02y6y+JeeSRI1/lhTaYivJBgOIw34Z7eUP6oHJW+IBkYnRzUPBI8Rv1PX7kkS X-Received: by 10.157.19.43 with SMTP id f40mr6065324ote.189.1486751046158; Fri, 10 Feb 2017 10:24:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.128.198 with HTTP; Fri, 10 Feb 2017 10:23:45 -0800 (PST) From: Jason Merrill Date: Fri, 10 Feb 2017 13:23:45 -0500 Message-ID: Subject: C++ PATCH for c++/71285 (member of fold-expr) To: gcc-patches List X-IsSubscribed: yes The fold-expressions code was improperly using unknown_type_node, which means unresolved overload; an expression whose type is unknown due to type-dependence should have null type. Tested x86_64-pc-linux-gnu, applying to trunk. commit e0fecc36cbee5afb56837b883d4091d180b880b5 Author: Jason Merrill Date: Fri Feb 10 12:51:59 2017 -0500 PR c++/71285 - member of fold-expression * semantics.c (finish_unary_fold_expr) (finish_binary_fold_expr): Use null type for fold-expressions. diff --git a/gcc/cp/semantics.c b/gcc/cp/semantics.c index e9fc4aa..6a47476 100644 --- a/gcc/cp/semantics.c +++ b/gcc/cp/semantics.c @@ -9437,7 +9437,7 @@ finish_unary_fold_expr (tree expr, int op, tree_code dir) // Build the fold expression. tree code = build_int_cstu (integer_type_node, abs (op)); - tree fold = build_min (dir, unknown_type_node, code, pack); + tree fold = build_min_nt_loc (UNKNOWN_LOCATION, dir, code, pack); FOLD_EXPR_MODIFY_P (fold) = (op < 0); return fold; } @@ -9463,7 +9463,7 @@ finish_binary_fold_expr (tree pack, tree init, int op, tree_code dir) { pack = make_pack_expansion (pack); tree code = build_int_cstu (integer_type_node, abs (op)); - tree fold = build_min (dir, unknown_type_node, code, pack, init); + tree fold = build_min_nt_loc (UNKNOWN_LOCATION, dir, code, pack, init); FOLD_EXPR_MODIFY_P (fold) = (op < 0); return fold; } diff --git a/gcc/testsuite/g++.dg/cpp1z/fold9.C b/gcc/testsuite/g++.dg/cpp1z/fold9.C new file mode 100644 index 0000000..578b8d0 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/fold9.C @@ -0,0 +1,12 @@ +// PR c++/71285 +// { dg-options -std=c++1z } + +template +void spurious(Args... args) +{ + (... + args).member; +} + +int main() +{ +}