From patchwork Mon Jan 15 21:25:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "A. Skrobov" X-Patchwork-Id: 861079 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-471303-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="wGIrrFYK"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zL5yh3Tnyz9sR8 for ; Tue, 16 Jan 2018 08:26:51 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=ufwJ2taspTwHTSbP9XaGaJU+nX1FpFI1LphzkUqUyBcR8Z /g7L9mSx5UEAo527S66mg3LVLyN/EKBELpfVvnrDr16IfHa3NeDyUYtFmFRbQY4Z m1gBySixQLEvDxeX6OeP8BhJ4gNuBVojqNuZmzLgcL6sjAm5z7TItMBFCfUqo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=PQ/jLTZaysPLJex717Bw4OvPcs4=; b=wGIrrFYKru8+prJJNDvK JpFjATUg6H1R1s0oTb+CAhpMrY37rWUjGzfHbifVhTtSPtyZLzuDWR0WLSTsWlSd sBUOFZ76jdOKlL9v30e7fx4zN+fbqpg/DigTkvQP6hXf5rcGlmhdD2sePKamEVOz DqfZKLgijNFOVsya1agbh1w= Received: (qmail 58577 invoked by alias); 15 Jan 2018 21:26:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 58048 invoked by uid 89); 15 Jan 2018 21:25:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f66.google.com Received: from mail-oi0-f66.google.com (HELO mail-oi0-f66.google.com) (209.85.218.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Jan 2018 21:25:30 +0000 Received: by mail-oi0-f66.google.com with SMTP id d124so9199994oib.13 for ; Mon, 15 Jan 2018 13:25:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=cKSs37XTULhNDnKJknZTgSgW2BNXGFSrQqfk5ic6/as=; b=msPTG7AGpn7eVGyL6weqjJqrrCoNeRMNOlpnNNRCgeVo0iNIbHz7SXcNM0KHKJWIiX q6Mkj45B91b4/pScgbw2pemAbzzmxFhZCa17ZsQXkirXBo5o21hNq3r5CzQhXc9sAGCn tskt7DS0KKpV0BqDvqRJ7LxbCfxfeEJ7nU6xz6q6Ch480yvpb/Ux13FBokS6aYjjdGoj 4Th3cX3qBJ9XpOuKRtMuY2cI/9D+6FpgGpyM6nR7d4pO9ztYIsQ+zNGfA0B+ezt6hFgl Q2og+p6m2HppEs1CoogsMh1QXEVsqTNci/tazFtileazsGRwr7coL6QjgQPBt1b9HxSX iH6A== X-Gm-Message-State: AKGB3mKzJsEbIqgUnO7ODHb5rv8OS6R+QsUlXQKCzcbikK1UWiwN+zeC utKeTncqCNYMnhWRvkz4gUQ9HcRUUjS7PE6YpCGPTA== X-Google-Smtp-Source: ACJfBovZXVy59j+EBhcnNPV6iB6iJlQ+l81Q5okkSYv77ycgvkXIZuBq9hlfn+2xslBoymHvbIFFsGqLD4vztma0At8= X-Received: by 10.202.108.14 with SMTP id h14mr17071380oic.189.1516051528579; Mon, 15 Jan 2018 13:25:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.92.131 with HTTP; Mon, 15 Jan 2018 13:25:27 -0800 (PST) From: "A. Skrobov" Date: Mon, 15 Jan 2018 23:25:27 +0200 Message-ID: Subject: [PATCH] Drop unused parameter of insert_save() To: gcc-patches@gcc.gnu.org The only caller passes `before_p=1`, and I cannot imagine a use case for it with `before_p=0` 2018-01-15 Artyom Skrobov tyomitch@gmail.com * caller-save.c: Drop unused parameter of insert_save() --- gcc/caller-save.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) int i; @@ -1314,7 +1314,7 @@ insert_save (struct insn_chain *chain, int before_p, int regno, pat = gen_rtx_SET (mem, gen_rtx_REG (GET_MODE (mem), regno)); code = reg_save_code (regno, GET_MODE (mem)); - new_chain = insert_one_insn (chain, before_p, code, pat); + new_chain = insert_one_insn (chain, 1, code, pat); /* Set hard_regs_saved and dead_or_set for all the registers we saved. */ for (k = 0; k < numregs; k++) diff --git a/gcc/caller-save.c b/gcc/caller-save.c index df1c9691e0c2..db1ab2caee9a 100644 --- a/gcc/caller-save.c +++ b/gcc/caller-save.c @@ -88,7 +88,7 @@ static void mark_set_regs (rtx, const_rtx, void *); static void mark_referenced_regs (rtx *, refmarker_fn *mark, void *mark_arg); static refmarker_fn mark_reg_as_referenced; static refmarker_fn replace_reg_with_saved_mem; -static int insert_save (struct insn_chain *, int, int, HARD_REG_SET *, +static int insert_save (struct insn_chain *, int, HARD_REG_SET *, machine_mode *); static int insert_restore (struct insn_chain *, int, int, int, machine_mode *); @@ -861,7 +861,7 @@ save_call_clobbered_regs (void) for (regno = 0; regno < FIRST_PSEUDO_REGISTER; regno++) if (TEST_HARD_REG_BIT (hard_regs_to_save, regno)) - regno += insert_save (chain, 1, regno, &hard_regs_to_save, save_mode); + regno += insert_save (chain, regno, &hard_regs_to_save, save_mode); /* Must recompute n_regs_saved. */ n_regs_saved = 0; @@ -1252,7 +1252,7 @@ insert_restore (struct insn_chain *chain, int before_p, int regno, /* Like insert_restore above, but save registers instead. */ static int -insert_save (struct insn_chain *chain, int before_p, int regno, +insert_save (struct insn_chain *chain, int regno, HARD_REG_SET *to_save, machine_mode *save_mode) {