| Message ID | CABtf2+SNFmRWD4-7WN15NA9dPX5neD=io8=DJovBb9F_CLXy_A@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [libvtv] Fix testsuite issue. | expand |
On Tue, 19 Feb 2019, Caroline Tice wrote: > One of the testsuite tests for libvtv is failing due to an incorrect > signature for the function > "main". This patch fixes that. > > Testing: The libvtv testsuite failed 4 tests without this fix; it > passes all of them with it. > > Ok to commit? OK. So it looks like while it's documented libvtv is built even without --enable-vtable-verify it actually isn't and thus tests are not run when not configuring with --enable-vtable-verify and no tests are run. Richard. > -- Caroline Tice > cmtice@google.com > > Index: libvtv/ChangeLog > =================================================================== > --- libvtv/ChangeLog (revision 269022) > +++ libvtv/ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2019-02-19 Caroline Tice <cmtice@google.com> > + > + Fix testsuite > + * testsuite/libvtv.cc/const_vtable.cc (main): Fix function signature. > + > 2019-01-01 Jakub Jelinek <jakub@redhat.com> > > Update copyright years. > Index: libvtv/testsuite/libvtv.cc/const_vtable.cc > =================================================================== > --- libvtv/testsuite/libvtv.cc/const_vtable.cc (revision 269022) > +++ libvtv/testsuite/libvtv.cc/const_vtable.cc (working copy) > @@ -28,7 +28,7 @@ > ~D(); > }; > extern "C" int printf(const char *,...); > -main() > +int main(int argc, char**argv) > { > try { > D *d = new D; > >
Index: libvtv/ChangeLog =================================================================== --- libvtv/ChangeLog (revision 269022) +++ libvtv/ChangeLog (working copy) @@ -1,3 +1,8 @@ +2019-02-19 Caroline Tice <cmtice@google.com> + + Fix testsuite + * testsuite/libvtv.cc/const_vtable.cc (main): Fix function signature. + 2019-01-01 Jakub Jelinek <jakub@redhat.com> Update copyright years. Index: libvtv/testsuite/libvtv.cc/const_vtable.cc =================================================================== --- libvtv/testsuite/libvtv.cc/const_vtable.cc (revision 269022) +++ libvtv/testsuite/libvtv.cc/const_vtable.cc (working copy) @@ -28,7 +28,7 @@ ~D(); }; extern "C" int printf(const char *,...); -main() +int main(int argc, char**argv) { try { D *d = new D;