From patchwork Fri May 26 16:08:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 767452 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wZ9z76kHgz9s86 for ; Sat, 27 May 2017 02:08:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Lzw2UWNd"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=Is2naHRjDlryJM+V4DtdvAP61/E84tbDPyx04DvPJ9lGCi +mFZ2f5bS0I8CdG5d3jTRknuFOMStMuwigtYtSZ4vH6dnAnyrCkVRFD3sXRAe7o7 8GQvpbmOiR+BuvnfzG51o7WQMD0EplQu0eMZ2T8muiqxOQBLFmJo3HuAC+lCE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=k4GudzYA6n80n1svDDCZWsateEA=; b=Lzw2UWNdexru3C20nPhc Lu1NoUQFA0MuBWtOYzijTqDP/m6MFTetN5759ZHhn4+Ej6reVG4TWVYOdQwPMEJC V5Xp05GRYrY9elupUX5kPin4JV7bQ8FUIDM3Zh/N9/z+4VLRU1qxKX9QHnYgEeLs DglwFDsAhgRgE2E2EQ+YpT0= Received: (qmail 83534 invoked by alias); 26 May 2017 16:08:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 81303 invoked by uid 89); 26 May 2017 16:08:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-vk0-f41.google.com Received: from mail-vk0-f41.google.com (HELO mail-vk0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 16:08:00 +0000 Received: by mail-vk0-f41.google.com with SMTP id y190so7751562vkc.1 for ; Fri, 26 May 2017 09:08:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=UKSwQWe0T9A9nWTq2BqQOE3e+uhQpd5AIbJxtwhOla4=; b=rebq1LXl9BcSf6LJ+UQuHblQ97F3cTNgTjzHIKY7ATR6aEOEiK8CM3bE2cWzXGEKom Hdd1/eMOVTfYneXqI0Jojk9g58Pb4O9ZmHR32jLH+CH4pEDSQHUwtbQGrvngA7RGWyst vqTe4jqOseCnMnRbyC7K1wljd0NfedEJucf6NnHIbNzF9OuGnHvIFP8ZSRteI9ux7PMb W+h0lKivl0KCmK41HXQrXmy+O5DOLIfElZCkN6xR1s22SLKMx17yQ017bTBWiFj0jqdI KMFYPcyMyHX/nY0J8AnOc2r4Jsoh8ZvPde3+vfBdW5p0fOzwfG7bFf5qck2w+yFEt6BA xrVg== X-Gm-Message-State: AODbwcBTeGT+pJXa4/ANpxf8NXvPB4Frm0XOG8O9Ok/HD6TQd8jMCpbX X38z85EuDY27e4VYlVHldPj+CpGIvA== X-Received: by 10.31.57.4 with SMTP id g4mr1269068vka.51.1495814882224; Fri, 26 May 2017 09:08:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.96.201 with HTTP; Fri, 26 May 2017 09:08:01 -0700 (PDT) From: Iain Buclaw Date: Fri, 26 May 2017 18:08:01 +0200 Message-ID: Subject: [PATCH 3/3] [D] libiberty: Prefix mangled D initializer symbols To: gcc-patches X-IsSubscribed: yes This is instead of adding a `.init$' postfix, which gave it a property-style name. My rationale being that "initializer for symbol" is much more informative when inspecting D runtime type information in gdb, which is the only place where you would encounter references to this compiler-generated symbol. commit a99454b6c27a2564fe1a40c46b1fb593c664ef20 Author: Iain Buclaw Date: Fri May 26 16:44:35 2017 +0200 libiberty/ChangeLog: 2017-05-26 Iain Buclaw * d-demangle.c (dlang_identifier): Prefix mangled init symbols with `initializer for'. * testsuite/demangle-expected: Update tests. diff --git a/libiberty/d-demangle.c b/libiberty/d-demangle.c index 829050bc0b8..08690de9bd3 100644 --- a/libiberty/d-demangle.c +++ b/libiberty/d-demangle.c @@ -864,7 +864,8 @@ dlang_identifier (string *decl, const char *mangled, else if (strncmp (mangled, "__initZ", len+1) == 0) { /* The static initialiser for a given symbol. */ - string_append (decl, "init$"); + string_prepend (decl, "initializer for "); + string_setlength (decl, string_length (decl) - 1); mangled += len; return mangled; } diff --git a/libiberty/testsuite/d-demangle-expected b/libiberty/testsuite/d-demangle-expected index 7bf8b1725f9..547a2ddec39 100644 --- a/libiberty/testsuite/d-demangle-expected +++ b/libiberty/testsuite/d-demangle-expected @@ -587,7 +587,7 @@ demangle.test(scope char() scope function) # --format=dlang _D8demangle4test6__initZ -demangle.test.init$ +initializer for demangle.test # --format=dlang _D8demangle4test6__vtblZ