From patchwork Wed Feb 13 18:57:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sriraman Tallam X-Patchwork-Id: 220229 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2FA0D2C0084 for ; Thu, 14 Feb 2013 05:57:55 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1361386676; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:Date:Message-ID: Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=TusM7IlwM/YEe9tiD7SAzpbjWS8=; b=gxdfKXuwA3/XXf3 5R4/CI4ElOEEw5EN9CYeRKsJnyLr0g63OuiigbGGkNRWoH67tu6wqZdZnldhlDc3 bMtoMCWAUBwAnT25YdHVjdcz63vfMhwWIt833zzcp9LrzNe+a9tsZ8+4cCVJd5Rv Lo14kR75cjqIpERQd9g7qNSsXS/Q= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:X-Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=YV1k6nTS32YRUMa5eQJoQaOrNRV5E4inbmQ7M4TpcM6imtPOwELshBJisLgZio BhxBH6uxwKlspVPB77YvgC6MaOI8hllPlkDwBKh5fCzBmDhKBnhI/b/B8WWSkUFD pnWyWhdk/az45tnXABdrrXKLG530Fj8+EJHOxIF90DUbo=; Received: (qmail 32440 invoked by alias); 13 Feb 2013 18:57:52 -0000 Received: (qmail 32430 invoked by uid 22791); 13 Feb 2013 18:57:51 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f44.google.com (HELO mail-oa0-f44.google.com) (209.85.219.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Feb 2013 18:57:43 +0000 Received: by mail-oa0-f44.google.com with SMTP id h1so1660846oag.3 for ; Wed, 13 Feb 2013 10:57:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=9HaYSi9EA6SI+eAkbhaoCSSgTiMu13XKAZEuOCCKrfY=; b=iUvX7KznHaTbSM5YN1QYu8sGrsXp4pK6SYSr2mTsV7tWgcQ0ygi0P1zG+yTndqfRhk qkJM3jr5xWfKMWzOI0B3+oR5564MxXcUNDVojn5kbDoBvAFPkx5iEhFlhsXE/Upud7RS GwLUxEnSThcZSbLUT55xb77P1NcJKQvYKXVELQTPeSrIIgiUWGKtKrjhZKwpz7p9FOfu sQodnf4s6T0U2lTao7Gq01hmbWSJ7WX2h9hCktcLHGB0usVF4VKkX5ljO+yn6yKTalkm YvenZyz2O71qLmV32oTsGWpn8BrtAh5554laKV9WLgHP8cg6uUePckTGvcW87yV6pYs8 NNlg== MIME-Version: 1.0 X-Received: by 10.182.216.65 with SMTP id oo1mr17268438obc.95.1360781862569; Wed, 13 Feb 2013 10:57:42 -0800 (PST) Received: by 10.182.75.166 with HTTP; Wed, 13 Feb 2013 10:57:42 -0800 (PST) In-Reply-To: References: <20130118202236.GE7269@tucnak.redhat.com> <50FAC778.9040702@redhat.com> <20130121143248.GM7269@tucnak.redhat.com> <51092641.7080005@redhat.com> <5113BA64.5040709@redhat.com> Date: Wed, 13 Feb 2013 10:57:42 -0800 Message-ID: Subject: Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2) From: Sriraman Tallam To: Andreas Schwab Cc: Jason Merrill , GCC Patches , Richard Henderson , Jakub Jelinek X-Gm-Message-State: ALoCoQn79HhITTOyroHg0u1KUgDwrEtINXaaMsfP7tkUpOIME9KmXBygTLtd487ccqTVfq9yCIsejKiVxusLScbLAgtEcc17mDmowkfCSO3M8rjg3ktwfsf5NDdjGwlvN7+xOtfZP6oVnGS7Wx6DUoAJSinLBMdlHeFwFKOQbefV2zKjOvPZbnmEG81xsK5l5U1RTRndvCx4 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, Feb 13, 2013 at 7:46 AM, Sriraman Tallam wrote: > > On Feb 13, 2013 1:21 AM, "Andreas Schwab" wrote: >> >> Sriraman Tallam writes: >> >> > Index: gcc/testsuite/g++.dg/ext/mv12-aux.C >> > =================================================================== >> > --- gcc/testsuite/g++.dg/ext/mv12-aux.C (revision 0) >> > +++ gcc/testsuite/g++.dg/ext/mv12-aux.C (revision 0) >> > @@ -0,0 +1,11 @@ >> > +// Test case to check if multiversioning works as expected when the >> > versions >> > +// are defined in different files. Auxiliary file for mv12.C. >> > +// { dg-do compile } >> > + >> > +#include "mv12.h" >> > + >> > +__attribute__ ((target ("sse4.2"))) >> > +int foo () >> >> FAIL: g++.dg/ext/mv12-aux.C -std=c++11 (test for excess errors) >> Excess errors: >> /daten/aranym/gcc/gcc-20130213/gcc/testsuite/g++.dg/ext/mv12.h:5:47: >> warning: target attribute is not supported on this machine [-Wattributes] >> /daten/aranym/gcc/gcc-20130213/gcc/testsuite/g++.dg/ext/mv12.h:6:46: >> warning: target attribute is not supported on this machine [-Wattributes] >> /daten/aranym/gcc/gcc-20130213/gcc/testsuite/g++.dg/ext/mv12-aux.C:8:10: >> warning: target attribute is not supported on this machine [-Wattributes] > > I will fix this asap. Sorry about this. I committed a trivial patch to fix this problem. mv12-aux.C is auxiliary to mv12.C and should have the same test directives as mv12.C. 2013-02-13 Sriraman Tallam * g++.dg/ext/mv12-aux.C: Add directives to match mv12.C. Thanks Sri > > Sri > >> >> Andreas. >> >> -- >> Andreas Schwab, SUSE Labs, schwab@suse.de >> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 >> "And now for something completely different." Index: g++.dg/ext/mv12-aux.C =================================================================== --- g++.dg/ext/mv12-aux.C (revision 196025) +++ g++.dg/ext/mv12-aux.C (working copy) @@ -1,7 +1,10 @@ // Test case to check if multiversioning works as expected when the versions // are defined in different files. Auxiliary file for mv12.C. -// { dg-do compile } +// { dg-do compile { target i?86-*-* x86_64-*-* } } +// { dg-require-ifunc "" } +// { dg-options "-O2" } + #include "mv12.h" This should fix the problem.