From patchwork Mon Nov 5 04:04:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sriraman Tallam X-Patchwork-Id: 197134 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3436A2C0094 for ; Mon, 5 Nov 2012 15:04:35 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1352693076; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:Date:Message-ID:Subject:From:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=y1skAM3 qxYwproXadp/tjlqDCn8=; b=vxQpo3CYxKCMTqR0F/JqPQp1L5N75gYTrBLyXRY lZvebF0ITY/6II2U5mtiNWuaQh8l8YaLeZX5DYvyzEX04aNQOVqIaaNoX+15Rm7/ +2pZtiAyKroAfxYkEstnHT6aGZODGhm8pkMZTfPD4jAWVWV6/Pu0XZC3hXqBNzbX rtSg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Content-Type:X-System-Of-Record:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=HVyy7PBjrlrxSh3PGmaf030cY47NcKtVHxNjGCBPGGbsnKNDDUcU+ORD80v45x M0dvXElqQ7J+eUFEZCSifY5iH6gx2VehDuUgwv8qjvCX9z9SVTcT5VqPaqm+mhjZ buj9f8JNTIxlg47/rRm8qFy/AsoxVwvC3mqagPiHJurPc=; Received: (qmail 18798 invoked by alias); 5 Nov 2012 04:04:08 -0000 Received: (qmail 18777 invoked by uid 22791); 5 Nov 2012 04:04:06 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Nov 2012 04:04:01 +0000 Received: by mail-oa0-f47.google.com with SMTP id h1so5507131oag.20 for ; Sun, 04 Nov 2012 20:04:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :x-system-of-record:x-gm-message-state; bh=WF30Tuh8gQS/es/hjcgyYnZfSQLD9UfEuS5Q/m4Du2E=; b=LACUZBcVA0pQpda4fl/aM2FEBok4hhalMgC+2H+2a5rmFIlHCfalTFe0T2761Ij/Bo SW0VEWqajqvuzoKABVB5O3wDSOfMENRH8E9BDaPfSTw399Z5r+IQDGTxE4e/YrmkGbNR zNg5LJ7XCpeX3FIJFqDSkQrQEl+Eoku6QW0fzTO1bkKQ4WeJpMP3wVDsKTPabOpWX+eK fBHUxe1YKDo2M+oy69BCiuNiifx30/g1fOPj4FscMxm+sGsr81zAVQho7zYqoy2TQZ5/ BTY8YY2zVCwfkNpcEXJV+oFQqcVNRdlAiGBvA/DcXeNxnpr1I+SCcygkVXzqF2c97wDO rCrg== MIME-Version: 1.0 Received: by 10.182.52.105 with SMTP id s9mr6880598obo.25.1352088240297; Sun, 04 Nov 2012 20:04:00 -0800 (PST) Received: by 10.182.176.106 with HTTP; Sun, 4 Nov 2012 20:04:00 -0800 (PST) Date: Sun, 4 Nov 2012 20:04:00 -0800 Message-ID: Subject: Using -ffunction-sections and -p From: Sriraman Tallam To: GCC Patches , Ian Lance Taylor , David Li , gcc@gcc.gnu.org X-System-Of-Record: true X-Gm-Message-State: ALoCoQkz4Li6a/wIwU+culsXQGSbokt8LfuY9828Ffw5vAgroPL985DRt3cP2QmVKv8qamUrCvlFtD8cemItAEsuH+on7hSjs1N4Lkc8M2j+1WXTddPJdUZMLf9C8njw6cECVRce/2uYPlN937fsz1kV+2JuKBMmCzZqZ+0dUQq4a+FUuOGmFF4q+fyv1xb4mL3gEqtITnz3 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, Currently, using -ffunction-sections and -p together results in a warning. I ran into this problem when compiling the kernel. This is discussed in this thread: http://gcc.gnu.org/ml/gcc-help/2008-11/msg00128.html Ian's reply suggests this warning is no longer necessary and can be removed. Is this patch alright to commit with all tests passing: * toplev.c (process_options): Do not warn when -ffunction-sections and -fprofile are used together. { Thanks, -Sri. --- toplev.c (revision 193117) +++ toplev.c (working copy) @@ -1467,12 +1467,6 @@ process_options (void) } } - if (flag_function_sections && profile_flag) - { - warning (0, "-ffunction-sections disabled; it makes profiling impossible"); - flag_function_sections = 0; - } - #ifndef HAVE_prefetch if (flag_prefetch_loop_arrays > 0)