diff mbox

[Committed] New testcase for conditional move with conditional compares

Message ID CA+=Sn1mu=DvX6rVsuRwU1a17ewW6kLB5T2DgO6DwLDe6_M1OGQ@mail.gmail.com
State New
Headers show

Commit Message

Andrew Pinski June 23, 2014, 9:12 p.m. UTC 
Hi,
  When looking at the current conditional compare patch, I find that
we don't have a testcase to test that we don't ICE for the case where
we have conditional compares and conditional moves where the moves are
of floating point types.

This patch adds that testcase to the C torture compile test to make
sure we don't ICE (which I think we do currently).

Thanks,
Andrew Pinski

2014-06-23  Andrew Pinski  <apinski@cavium.com>

* gcc.c-torture/compile/20140723-1.c: New testcase.

Comments

Kyrylo Tkachov June 24, 2014, 9:08 a.m. UTC | #1 
On 23/06/14 22:12, Andrew Pinski wrote:
> Hi,
>    When looking at the current conditional compare patch, I find that
> we don't have a testcase to test that we don't ICE for the case where
> we have conditional compares and conditional moves where the moves are
> of floating point types.
>
> This patch adds that testcase to the C torture compile test to make
> sure we don't ICE (which I think we do currently).

FWIW, this doesn't ICE for me with aarch64-none-elf trunk.

Kyrill

> Thanks,
> Andrew Pinski
>
> 2014-06-23  Andrew Pinski  <apinski@cavium.com>
>
> * gcc.c-torture/compile/20140723-1.c: New testcase.
Andrew Pinski June 24, 2014, 3:27 p.m. UTC | #2 
> On Jun 24, 2014, at 2:08 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> 
> 
>> On 23/06/14 22:12, Andrew Pinski wrote:
>> Hi,
>>   When looking at the current conditional compare patch, I find that
>> we don't have a testcase to test that we don't ICE for the case where
>> we have conditional compares and conditional moves where the moves are
>> of floating point types.
>> 
>> This patch adds that testcase to the C torture compile test to make
>> sure we don't ICE (which I think we do currently).
> 
> FWIW, this doesn't ICE for me with aarch64-none-elf trunk.

I meant with conditional compare patches applied. 

Thanks,
Andrew

> 
> Kyrill
> 
>> Thanks,
>> Andrew Pinski
>> 
>> 2014-06-23  Andrew Pinski  <apinski@cavium.com>
>> 
>> * gcc.c-torture/compile/20140723-1.c: New testcase.
> 
>
diff mbox

Patch

Index: gcc.c-torture/compile/20140723-1.c
===================================================================
--- gcc.c-torture/compile/20140723-1.c	(revision 0)
+++ gcc.c-torture/compile/20140723-1.c	(revision 0)
@@ -0,0 +1,4 @@ 
+double f(double a, double b, int c, int d)
+{
+  return (c>10&&d>20)?a:b;
+}
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 211915)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@ 
+2014-06-23  Andrew Pinski  <apinski@cavium.com>
+
+	* gcc.c-torture/compile/20140723-1.c: New testcase.
+
 2014-06-23  Marek Polacek  <polacek@redhat.com>
 
 	PR c/61553