diff mbox

[PATCH/AARCH64] Fix -mcpu/arch=native support for LSE

Message ID CA+=Sn1mZmRVLqf_5mHDQZUCX1r0HSiQh=HgLZAHfyXdZ2OBx4w@mail.gmail.com
State New
Headers show

Commit Message

Andrew Pinski Dec. 11, 2015, 7:54 p.m. UTC 
Hi,
  The Linux kernel calls lse as atomics in /proc/cpuinfo.  We should
change aarch64-option-extensions.def to take that into account.

OK?  Bootstrapped and tested on aarch64-linux-gnu with no regressions
and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
see if lse gets enabled.

Thanks,
Andrew Pinski

ChangeLog:
 * config/aarch64/aarch64-option-extensions.def (LSE): Change
FEAT_STRING to "atomics".

Comments

Andrew Pinski Dec. 19, 2015, 3:57 a.m. UTC | #1 
On Fri, Dec 11, 2015 at 11:54 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
>   The Linux kernel calls lse as atomics in /proc/cpuinfo.  We should
> change aarch64-option-extensions.def to take that into account.
>
> OK?  Bootstrapped and tested on aarch64-linux-gnu with no regressions
> and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
> see if lse gets enabled.

Ping.


apinski@arm64:~/src/linux-upstream$ cat /proc/cpuinfo |head -9
processor       : 0
BogoMIPS        : 200.00
Features        : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics
CPU implementer : 0x43
CPU architecture: 8
CPU variant     : 0x1
CPU part        : 0x0a1
CPU revision    : 0



>
> Thanks,
> Andrew Pinski
>
> ChangeLog:
>  * config/aarch64/aarch64-option-extensions.def (LSE): Change
> FEAT_STRING to "atomics".
Richard Earnshaw (lists) Dec. 21, 2015, 1:31 p.m. UTC | #2 
On 11/12/15 19:54, Andrew Pinski wrote:
> Hi,
>   The Linux kernel calls lse as atomics in /proc/cpuinfo.  We should
> change aarch64-option-extensions.def to take that into account.
> 
> OK?  Bootstrapped and tested on aarch64-linux-gnu with no regressions
> and tested with -mcpu=native on ThunderX T88 pass 2 with Linux 4.4 to
> see if lse gets enabled.
> 
> Thanks,
> Andrew Pinski
> 
> ChangeLog:
>  * config/aarch64/aarch64-option-extensions.def (LSE): Change
> FEAT_STRING to "atomics".
> 

Matthew checked in the original patch and he's currently on vacation, so
I can't check why he put 'lse' here.  However, I've checked with the
kernel team and they've confirmed that 'atomics' is correct, so OK.

R.

> 
> fixlse.diff.txt
> 
> 
> Index: aarch64-option-extensions.def
> ===================================================================
> --- aarch64-option-extensions.def	(revision 231572)
> +++ aarch64-option-extensions.def	(working copy)
> @@ -40,4 +40,4 @@ AARCH64_OPT_EXTENSION ("simd", AARCH64_F
>  		       AARCH64_FL_SIMD | AARCH64_FL_CRYPTO, "asimd")
>  AARCH64_OPT_EXTENSION("crypto",	AARCH64_FL_CRYPTO | AARCH64_FL_FPSIMD,  AARCH64_FL_CRYPTO,   "aes pmull sha1 sha2")
>  AARCH64_OPT_EXTENSION("crc",	AARCH64_FL_CRC,                         AARCH64_FL_CRC,                        "crc32")
> -AARCH64_OPT_EXTENSION("lse",	AARCH64_FL_LSE,                         AARCH64_FL_LSE,                        "lse")
> +AARCH64_OPT_EXTENSION("lse",	AARCH64_FL_LSE,                         AARCH64_FL_LSE,                        "atomics")
>
diff mbox

Patch

Index: aarch64-option-extensions.def
===================================================================
--- aarch64-option-extensions.def	(revision 231572)
+++ aarch64-option-extensions.def	(working copy)
@@ -40,4 +40,4 @@  AARCH64_OPT_EXTENSION ("simd", AARCH64_F
 		       AARCH64_FL_SIMD | AARCH64_FL_CRYPTO, "asimd")
 AARCH64_OPT_EXTENSION("crypto",	AARCH64_FL_CRYPTO | AARCH64_FL_FPSIMD,  AARCH64_FL_CRYPTO,   "aes pmull sha1 sha2")
 AARCH64_OPT_EXTENSION("crc",	AARCH64_FL_CRC,                         AARCH64_FL_CRC,                        "crc32")
-AARCH64_OPT_EXTENSION("lse",	AARCH64_FL_LSE,                         AARCH64_FL_LSE,                        "lse")
+AARCH64_OPT_EXTENSION("lse",	AARCH64_FL_LSE,                         AARCH64_FL_LSE,                        "atomics")