From patchwork Tue Nov 22 15:07:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 127102 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B6F771007D1 for ; Wed, 23 Nov 2011 02:07:41 +1100 (EST) Received: (qmail 27099 invoked by alias); 22 Nov 2011 15:07:35 -0000 Received: (qmail 27091 invoked by uid 22791); 22 Nov 2011 15:07:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2beaomr07.btconnect.com (HELO mail.btconnect.com) (213.123.26.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 15:07:18 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2beaomr07.btconnect.com with ESMTP id FGO15526; Tue, 22 Nov 2011 15:07:16 +0000 (GMT) Message-Id: From: Iain Sandoe To: GCC Patches Mime-Version: 1.0 (Apple Message framework v936) Subject: [Patch libitm] minor adjustment to make flags. Date: Tue, 22 Nov 2011 15:07:15 +0000 Cc: Richard Henderson , Rainer Orth X-Mirapoint-IP-Reputation: reputation=Good-1, source=Queried, refid=tid=0001.0A0B0301.4ECBBAA4.006C, actions=tag X-Junkmail-Premium-Raw: score=7/50, refid=2.7.2:2011.11.22.134814:17:7.944, ip=81.138.1.83, rules=__HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CT_TEXT_PLAIN, __CTE, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __MULTIPLE_RCPTS_CC_X2, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, BODY_SIZE_1100_1199, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, RDNS_SUSP, BODY_SIZE_2000_LESS, BODY_SIZE_7000_LESS, NO_URI_FOUND, MULTIPLE_RCPTS X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B020D.4ECBBAA5.0005, ss=1, re=0.000, fgs=0, ip=0.0.0.0, so=2011-07-25 19:15:43, dmn=2011-05-27 18:58:46, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, since: libitm_la_LDFLAGS are now correctly applied Darwin no longer gets the "-Wl,- undefined,dynamic_lookup" (which I had mentioned before was surprising me with -no-undefined in libitm_la_LDFLAGS). Anyway, to make weak refs work with Darwin, we need that - and it turns out that other GCC libs are built without "-no-undefined". is the following OK for trunk? Iain libitm: * Makefile.am (libitm_la_LDFLAGS): Remove "-no-undefined". * Makefile.in: Regenerate. Index: libitm/Makefile.am =================================================================== --- libitm/Makefile.am (revision 181618) +++ libitm/Makefile.am (working copy) @@ -54,8 +54,7 @@ libitm_version_info = -version-info $(libtool_VERS # want or need libstdc++. libitm_la_DEPENDENCIES = $(libitm_version_dep) libitm_la_LINK = $(LINK) $(libitm_la_LDFLAGS) -libitm_la_LDFLAGS = $(libitm_version_info) $(libitm_version_script) \ - -no-undefined +libitm_la_LDFLAGS = $(libitm_version_info) $(libitm_version_script) libitm_la_SOURCES = \ aatree.cc alloc.cc alloc_c.cc alloc_cpp.cc barrier.cc beginend.cc \