From patchwork Tue Nov 12 04:41:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Iyer, Balaji V" X-Patchwork-Id: 290533 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1D2672C0096 for ; Tue, 12 Nov 2013 15:41:50 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=vumnBwaOu5SJGreCApTIKcPCtnai1fqe13Jjpyok0/9a36hJE0FFO CNF1iqvKz0175KFtXUkUklTpdWwffs0dRkepoF2dmu37en2AqXvz8wZ1fUSl3xam y2PAStzaFUs/jgZnIEWPgpnmWUAcyPV7EtNyMNii5/DPJFqbyoxc4o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=iS72ZgC8r4Wm9uySadUimFkUjSI=; b=mfZWv6eYH0WkcONl2xV/b8O5NVC5 S9K2IRi1DwnItWS7QBcyKpMaqd54ujWMPdAS6ETcozKfsZK2ScRXLhOobdz4rjQv +rVd/KXPcZODT+OoRbW/gVHWpp24LCDyfEUfeTvb+Hmm5L8E+OPDv+CViYHA9453 9N/8rZGAOD4NYfw= Received: (qmail 21658 invoked by alias); 12 Nov 2013 04:41:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21649 invoked by uid 89); 12 Nov 2013 04:41:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, SPF_PASS, URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mga09.intel.com Received: from Unknown (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2013 04:41:16 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 11 Nov 2013 20:37:38 -0800 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2013 20:41:02 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.19.17.221) by FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 11 Nov 2013 20:41:02 -0800 Received: from fmsmsx101.amr.corp.intel.com ([169.254.1.24]) by fmsmsx152.amr.corp.intel.com ([169.254.6.75]) with mapi id 14.03.0123.003; Mon, 11 Nov 2013 20:41:01 -0800 From: "Iyer, Balaji V" To: David Edelsohn CC: GCC Patches , "Joseph S. Myers" Subject: RE: PING Cilk Plus failures on non-LTO targets Date: Tue, 12 Nov 2013 04:41:00 +0000 Message-ID: References: In-Reply-To: MIME-Version: 1.0 X-IsSubscribed: yes > -----Original Message----- > From: David Edelsohn [mailto:dje.gcc@gmail.com] > Sent: Monday, November 11, 2013 11:36 AM > To: Iyer, Balaji V > Cc: GCC Patches; Joseph S. Myers > Subject: Re: PING Cilk Plus failures on non-LTO targets > > On Mon, Nov 4, 2013 at 11:06 AM, David Edelsohn > wrote: > > Balaji, > > > > I am seeing a large number of libcilkrts failures on AIX. These all > > are of the form: > > > > Executing on host: /tmp/20131103/gcc/xgcc -B/tmp/20131103/gcc/ > > /nasfarm/edelsohn /src/src/gcc/testsuite/c-c++-common/cilk- > plus/CK/sync_wo_spawn.c -fno-diagnosti > > cs-show-caret -fdiagnostics-color=never -O0 -flto -g -fcilkplus - > L/tmp/2013110 > > 3/powerpc-ibm-aix7.1.0.0/./libcilkrts/.libs -fcilkplus -S -o > > sync_wo_spawn.s (timeout = 300) > > cc1: error: LTO support has not been enabled in this configuration > > compiler exited with status 1 > > > > If the feature / functionality requires LTO, the tests should check > > that LTO is supported with check_effective_target_lto, either in each > > relevant test or in cilk-plus.exp. > > Balaji, > > I continue to see extra Cilk Plus failures on AIX. Tests that require LTO should > check that the target supports LTO. > Hi David, Here is a patch that should fix this issue. Is this Patch OK to install? Thanks, Balaji V. iyer. > Thanks, David Index: testsuite/gcc.dg/cilk-plus/cilk-plus.exp =================================================================== --- testsuite/gcc.dg/cilk-plus/cilk-plus.exp (revision 204591) +++ testsuite/gcc.dg/cilk-plus/cilk-plus.exp (working copy) @@ -18,6 +18,7 @@ load_lib gcc-dg.exp +load_lib lto.exp if { ![check_effective_target_cilkplus] } { return; @@ -48,8 +49,9 @@ dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O2 -std=c99 -fcilkplus $ALWAYS_CFLAGS" " " dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O2 -ftree-vectorize -fcilkplus $ALWAYS_CFLAGS" " " dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O3 -g -fcilkplus $ALWAYS_CFLAGS" " " +if { [check_effective_target_lto] } { dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O3 -flto -g -fcilkplus $ALWAYS_CFLAGS" " " +} - dg-finish Index: testsuite/ChangeLog =================================================================== --- testsuite/ChangeLog (revision 204591) +++ testsuite/ChangeLog (working copy) @@ -1,3 +1,8 @@ +2013-11-11 Balaji V. Iyer + + * gcc.dg/cilk-plus/cilk-plus.exp: Added a check for LTO before running + LTO tests. + 2013-11-08 Cong Hou PR tree-optimization/58508