From patchwork Sun May 19 14:10:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Dominique_d=27Humi=C3=A8res?= X-Patchwork-Id: 1101569 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-501099-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lps.ens.fr Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="h/DQWYrO"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 456P891cw5z9sBb for ; Mon, 20 May 2019 00:10:56 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :content-type:content-transfer-encoding:mime-version:subject :message-id:date:cc:to; q=dns; s=default; b=i5Sm9pzFrRjWocS65JJt bA3xlNmiKH/NtTY+UbjmKrZeMGesO3lZQU51V1jfH3PXDs/2iMxzi/kIAoYLLfHA AbkURL4aw/+kbfuSFMo9DHQPPF7+6rZ54ng/0J/7/hXOtxuwH9pWDZeiToeoM2pa N2MI50O8LeqgJyk6xOivVoE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :content-type:content-transfer-encoding:mime-version:subject :message-id:date:cc:to; s=default; bh=6IyZYFOCAsYyXwznCicrnZkWWe k=; b=h/DQWYrOLtF+i4TQFq60S/9o1sBorNia5vEute0OjVjDgq15ZCyqFbOrVF fQf3e0H5F3SB1OOSzj8TQlIYsxAJOIrnws3qUe9Dwc+Omv7VLhSYDfwRX7TRFehm m/wxgSPq212ll+JBIP3fJ5DFk5k/0kMt3ukAv9k/hE39/yU8g= Received: (qmail 121034 invoked by alias); 19 May 2019 14:10:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 121018 invoked by uid 89); 19 May 2019 14:10:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL, BAYES_20, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=UD:pr90500-2.c, target_clones, UD:pr90500-1.c, haswell X-HELO: nef.ens.fr Received: from nef2.ens.fr (HELO nef.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 May 2019 14:10:45 +0000 X-ENS-nef-client: 129.199.120.1 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id x4JEAfPt010089 ; Sun, 19 May 2019 16:10:41 +0200 Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id 3E0E711B; Sun, 19 May 2019 16:10:41 +0200 (CEST) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oGsM6SYkYzZC; Sun, 19 May 2019 16:10:41 +0200 (CEST) Received: from [192.168.1.11] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10]) by mailhost.lps.ens.fr (Postfix) with ESMTPSA id 0656C113; Sun, 19 May 2019 16:10:40 +0200 (CEST) From: =?utf-8?q?Dominique_d=27Humi=C3=A8res?= Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: dg-require-ifunc syntax Message-Id: Date: Sun, 19 May 2019 16:10:37 +0200 Cc: marxin@gcc.gnu.org, Jakub Jelinek , Iain Sandoe To: gcc-patches AFAICT the syntax for dg-require-ifunc seems to be /* { dg-require-ifunc "" } */ with two sets of exceptions: (1) gcc.target/i386/pr90500-*.c which explains FAIL: gcc.target/i386/pr90500-1.c (test for errors, line 6) FAIL: gcc.target/i386/pr90500-1.c (test for warnings, line 6) FAIL: gcc.target/i386/pr90500-1.c (test for excess errors) FAIL: gcc.target/i386/pr90500-2.c (test for errors, line 6) FAIL: gcc.target/i386/pr90500-2.c (test for warnings, line 6) FAIL: gcc.target/i386/pr90500-2.c (test for excess errors) and is fixed with the trivial patch (2) gcc.target/i386/pr84723-*.c which succeed on darwin. What is the suitable fix for that? (a) Fix the dg-require-ifunc as above? (b) Remove the line? TIA Dominique --- ../_clean/gcc/testsuite/gcc.target/i386/pr90500-1.c 2019-05-16 17:34:09.000000000 +0200 +++ gcc/testsuite/gcc.target/i386/pr90500-1.c 2019-05-18 14:28:12.000000000 +0200 @@ -1,6 +1,6 @@ /* PR middle-end/84723 */ /* { dg-do compile } */ -/* { dg-require-ifunc } */ +/* { dg-require-ifunc "" } */ __attribute__((target_clones("arch=haswell", "default"))) int __tanh() {} __typeof(__tanh) tanhf64 __attribute__((alias("__tanh")))/* { dg-error "clones for .target_clones. attribute cannot be created" } */ --- ../_clean/gcc/testsuite/gcc.target/i386/pr90500-2.c 2019-05-16 17:34:09.000000000 +0200 +++ gcc/testsuite/gcc.target/i386/pr90500-2.c 2019-05-18 14:28:25.000000000 +0200 @@ -1,6 +1,6 @@ /* PR middle-end/84723 */ /* { dg-do compile } */ -/* { dg-require-ifunc } */ +/* { dg-require-ifunc "" } */ __attribute__((target_clones("arch=haswell", "default"))) int __tanh() {} __typeof(__tanh) tanhf64 __attribute__((alias("__tanh"),target_clones("arch=haswell", "default"))); /* { dg-error "clones for .target_clones. attribute cannot be created" } */