From patchwork Wed May 25 14:07:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 97346 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id DEF09B6F91 for ; Thu, 26 May 2011 00:08:04 +1000 (EST) Received: (qmail 568 invoked by alias); 25 May 2011 14:08:03 -0000 Received: (qmail 557 invoked by uid 22791); 25 May 2011 14:08:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 May 2011 14:07:47 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p4PE7khY029568 for ; Wed, 25 May 2011 07:07:46 -0700 Received: from yib12 (yib12.prod.google.com [10.243.65.76]) by wpaz21.hot.corp.google.com with ESMTP id p4PE6qWK023928 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 25 May 2011 07:07:45 -0700 Received: by yib12 with SMTP id 12so5620865yib.1 for ; Wed, 25 May 2011 07:07:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.12.10 with SMTP id p10mr5115537ybi.184.1306332465430; Wed, 25 May 2011 07:07:45 -0700 (PDT) Received: by 10.151.41.13 with HTTP; Wed, 25 May 2011 07:07:45 -0700 (PDT) In-Reply-To: References: <20110525024236.309C62225A6@jade.mtv.corp.google.com> Date: Wed, 25 May 2011 10:07:45 -0400 Message-ID: Subject: Re: [pph] Regularize Streaming (issue4528096) From: Diego Novillo To: Lawrence Crowl Cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, May 25, 2011 at 08:17, Diego Novillo wrote: >> +    case TEMPLATE_DECL: >>     { >> +      pph_output_tree_or_ref_1 (stream, DECL_INITIAL (expr), ref_p, 3); >> +      pph_stream_write_lang_specific (stream, expr, ref_p); >>       pph_output_tree_or_ref_1 (stream, DECL_TEMPLATE_RESULT (expr), ref_p, 3); >>       pph_output_tree_or_ref_1 (stream, DECL_TEMPLATE_PARMS (expr), ref_p, 3); >>       pph_output_tree_or_ref_1 (stream, DECL_CONTEXT (expr), ref_p, 3); >> +      pph_output_uchar (stream, DECL_MEMBER_TEMPLATE_P (expr)); > > There does not seem to be a read operation for DECL_MEMBER_TEMPLATE_P. Fixed with this: 2011-05-25 Diego Novillo * pph-streamer-out.c (pph_stream_write_tree) : Do not write DECL_MEMBER_TEMPLATE_P. Tested and committed to the branch. Diego. diff --git a/gcc/cp/pph-streamer-out.c b/gcc/cp/pph-streamer-out.c index 1168683..6c451ac 100644 --- a/gcc/cp/pph-streamer-out.c +++ b/gcc/cp/pph-streamer-out.c @@ -924,7 +924,6 @@ pph_stream_write_tree (struct output_block *ob, tree expr, bool ref_p) pph_output_tree_or_ref_1 (stream, DECL_TEMPLATE_RESULT (expr), ref_p, 3); pph_output_tree_or_ref_1 (stream, DECL_TEMPLATE_PARMS (expr), ref_p, 3); pph_output_tree_or_ref_1 (stream, DECL_CONTEXT (expr), ref_p, 3); - pph_output_uchar (stream, DECL_MEMBER_TEMPLATE_P (expr)); break; }