Message ID | BANLkTi=pHmvoK3vXdrcM6m5=vOm5OrRASw@mail.gmail.com |
---|---|
State | New |
Headers | show |
I'd like to put this patch into google/main while it's being reviewed for trunk. Original message: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02075.html Rietveld: http://codereview.appspot.com/4440072 Bootstraps on x86_64, with testsuite output identical to a vanilla build. OK for google/main? -cary
On Wed, Apr 27, 2011 at 16:24, Cary Coutant <ccoutant@google.com> wrote: >>> set_debug_level should not use global state; this needs to check >>> opts->x_debug_info_level (not the global debug_info_level) and set >>> opts->x_generate_debug_line_table. >> >> Oops, missed that. Thanks! > > I've uploaded the revised patch to > http://codereview.appspot.com/4440072 -- should I also post it here? Yeah, not everyone on the list is using the web interface. Diego.
On Fri, Apr 29, 2011 at 16:36, Cary Coutant <ccoutant@google.com> wrote: > I'd like to put this patch into google/main while it's being reviewed for trunk. > > Original message: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02075.html > > Rietveld: http://codereview.appspot.com/4440072 > > Bootstraps on x86_64, with testsuite output identical to a vanilla build. > > OK for google/main? Yes. Diego.
>> OK for google/main? > > Yes. Thanks, committed to google/main. -cary
diff --git a/gcc/opts.c b/gcc/opts.c index 72f4d51..ee8c2b0 100644 --- a/gcc/opts.c +++ b/gcc/opts.c @@ -1872,7 +1872,8 @@ set_debug_level (enum debug_info_type type, int extended, const char *arg, opts->x_debug_info_level = (enum debug_info_levels) argval; } - generate_debug_line_table = debug_info_level >= DINFO_LEVEL_NORMAL; + opts->x_generate_debug_line_table = (opts->x_debug_info_level + >= DINFO_LEVEL_NORMAL); }