From patchwork Mon Feb 2 16:17:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Suchanek X-Patchwork-Id: 435583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B588A14012E for ; Tue, 3 Feb 2015 03:20:55 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=dsNQaphOJvIDzlNbj6t3ItUgyNfO4K0oFPaP3pBCZxmYvlXAQzVkS /wrNNxQUhpIQ6qoyp+RqsT3zKoH2uGd0uCNMfzQR1kiobD/NAKpEjQ4OAnOu1Owl 8Zm13f6Saw1YTmYCOLGAGfTckmbez4fYSzbtW/d4YT84L9fsnQ13r8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=w+eHaGxOz5DSz5ii4SLQDbg2acA=; b=r53tZbsxR2h7DPdwvNmEl5VZjaem 3EDYdhlNnlh9uYY6JYOfll50W6slivMIB2Pz/Opzrw1YTSP9lFsdqCOSQboTBGfw elEpsckVmQ5FsGzQ43EuNvYTs2siQna7a3tXqHqEqWWxsIOdwEv8ILIUp/zWyXTv kJa5hm+MOnyHQNI= Received: (qmail 24581 invoked by alias); 2 Feb 2015 16:18:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24551 invoked by uid 89); 2 Feb 2015 16:18:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Feb 2015 16:18:03 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id B847829867511; Mon, 2 Feb 2015 16:17:57 +0000 (GMT) Received: from hhmail02.hh.imgtec.org (10.100.10.20) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 2 Feb 2015 16:18:00 +0000 Received: from hhmail02.hh.imgtec.org ([::1]) by hhmail02.hh.imgtec.org ([::1]) with mapi id 14.03.0224.002; Mon, 2 Feb 2015 16:18:00 +0000 From: Robert Suchanek To: Richard Sandiford CC: "gcc-patches@gcc.gnu.org" , Matthew Fortune , "Catherine_Moore@mentor.com" Subject: RE: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain Date: Mon, 2 Feb 2015 16:17:57 +0000 Message-ID: References: <87vbjnnp8n.fsf@e105548-lin.cambridge.arm.com> In-Reply-To: <87vbjnnp8n.fsf@e105548-lin.cambridge.arm.com> MIME-Version: 1.0 > Please could you add a comment explaining that the mips_nanlegacy is there > because of the #include of system headers that might not compile with > -mnan=legacy? I agree that that's a good reason, but it's not obvious > without a comment. (And without a comment this could start a precendent > of things being skipped in cases where the mips.exp options machinery > could be updated instead.) > True. Clarification added. Ok for trunk? Regards, Robert 2015-02-02 Robert Suchanek * gcc.target/mips/loongson-simd.c: Update comment to clarify the need for mips_nanlegacy target. diff --git a/gcc/testsuite/gcc.target/mips/loongson-simd.c b/gcc/testsuite/gcc.target/mips/loongson-simd.c index 949632e..9c3ebce 100644 --- a/gcc/testsuite/gcc.target/mips/loongson-simd.c +++ b/gcc/testsuite/gcc.target/mips/loongson-simd.c @@ -21,7 +21,10 @@ along with GCC; see the file COPYING3. If not see /* { dg-do run } */ /* loongson.h does not handle or check for MIPS16ness or microMIPSness. There doesn't seem any good reason for it to, given - that the Loongson processors do not support either. */ + that the Loongson processors do not support either. The effective target + mips_nanlegacy is required for a toolchain without the legacy NaN support + because inclusion of some system headers e.g. stdint.h will fail due to not + finding stubs-o32_hard.h. */ /* { dg-require-effective-target mips_nanlegacy } */ /* { dg-options "isa=loongson -mhard-float -mno-micromips -mno-mips16 -flax-vector-conversions" } */