Message ID | B40CE3C3-49D3-4E10-888C-8647A07FB92C@sandoe-acoustics.co.uk |
---|---|
State | New |
Headers | show |
On 29 Jun 2010, at 21:27, IainS wrote: > > On 29 Jun 2010, at 20:22, Joern Rennecke wrote: > >> Quoting "H.J. Lu" <hjl.tools@gmail.com>: >> >> > This patch caused: >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44719 >> >> I have checked in the attached patch as obvious. > > it also caused a bootstrap fail on powerpc-apple-darwin9. > I am bootstrapping with the following - but you might like to see if > any other targets have a similar issue: > > Index: gcc/config/darwin.c > =================================================================== > --- gcc/config/darwin.c (revision 161563) > +++ gcc/config/darwin.c (working copy) > @@ -1864,7 +1864,7 @@ darwin_override_options (void) > > /* Disable -freorder-blocks-and-partition for > darwin_emit_unwind_label. */ > if (flag_reorder_blocks_and_partition > - && (targetm.asm_out.unwind_label == darwin_emit_unwind_label)) > + && (targetm.asm_out.emit_unwind_label == > darwin_emit_unwind_label)) > { > inform (input_location, > "-freorder-blocks-and-partition does not work with > exceptions " > this is actually needed on *-*-darwin* I've checked it on {i686,powerpc}-apple-darwin9 and x86_64-apple- darwin10 - although the latter does not complete bootstrap for other reasons, it does pass the stage that relates to this patch). IMO, this would qualify as "obvious", may I apply it to trunk? Iain
On 30 Jun 2010, at 09:27, IainS wrote: > > On 29 Jun 2010, at 21:27, IainS wrote: > >> >> On 29 Jun 2010, at 20:22, Joern Rennecke wrote: >> >>> Quoting "H.J. Lu" <hjl.tools@gmail.com>: >>> >>> > This patch caused: >>>> >>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44719 >>> >>> I have checked in the attached patch as obvious. >> >> it also caused a bootstrap fail on powerpc-apple-darwin9. >> I am bootstrapping with the following - but you might like to see >> if any other targets have a similar issue: >> >> Index: gcc/config/darwin.c >> =================================================================== >> --- gcc/config/darwin.c (revision 161563) >> +++ gcc/config/darwin.c (working copy) >> @@ -1864,7 +1864,7 @@ darwin_override_options (void) >> >> /* Disable -freorder-blocks-and-partition for >> darwin_emit_unwind_label. */ >> if (flag_reorder_blocks_and_partition >> - && (targetm.asm_out.unwind_label == darwin_emit_unwind_label)) >> + && (targetm.asm_out.emit_unwind_label == >> darwin_emit_unwind_label)) >> { >> inform (input_location, >> "-freorder-blocks-and-partition does not work with >> exceptions " >> > > this is actually needed on *-*-darwin* > I've checked it on {i686,powerpc}-apple-darwin9 and x86_64-apple- > darwin10 - although the latter does not complete bootstrap for other > reasons, it does pass the stage that relates to this patch). > > IMO, this would qualify as "obvious", may I apply it to trunk? ci as obvious, r161606 Iain
Index: gcc/config/darwin.c =================================================================== --- gcc/config/darwin.c (revision 161563) +++ gcc/config/darwin.c (working copy) @@ -1864,7 +1864,7 @@ darwin_override_options (void) /* Disable -freorder-blocks-and-partition for darwin_emit_unwind_label. */ if (flag_reorder_blocks_and_partition - && (targetm.asm_out.unwind_label == darwin_emit_unwind_label)) + && (targetm.asm_out.emit_unwind_label == darwin_emit_unwind_label)) {